mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Rik van Riel <riel@redhat.com>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] rcu: fix build error for sysrq workaround
Date: Mon, 28 Apr 2014 15:40 +0200	[thread overview]
Message-ID: <8486148.XCakAkJiju@wuerfel> (raw)

I got a build error in linux-next today, coming from:
http://ozlabs.org/~akpm/mmots/broken-out/sysrqrcu-suppress-rcu-stall-warnings-while-sysrq-runs.patch

I saw the problem has already been reported by other people, but couldn't find
a fix. This is what I used locally to avoid the build error. Not sure if it's
correct to do nothing though.

Please just ignore if the problem has already been solved independently.

	Arnd

(re-sent with mailing list on Cc)

9<-----------
From: Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] rcu: fix build error for sysrq workaround

Patch "sysrq,rcu: suppress RCU stall warnings while sysrq runs"
introduced two new functions, but they are unavailable if
CONFIG_RCU_STALL_COMMON is not set, so we have to provide
an alternative implementation, doing nothing.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index e9cc71c..26e1771 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -247,8 +247,15 @@ void rcu_idle_enter(void);
 void rcu_idle_exit(void);
 void rcu_irq_enter(void);
 void rcu_irq_exit(void);
+
+#ifdef CONFIG_RCU_STALL_COMMON
 void rcu_sysrq_start(void);
 void rcu_sysrq_end(void);
+#else
+static inline void rcu_sysrq_start(void) { }
+static inline void rcu_sysrq_end(void) { }
+
+#endif
 
 #ifdef CONFIG_RCU_USER_QS
 void rcu_user_enter(void);

                 reply	other threads:[~2014-04-28 13:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8486148.XCakAkJiju@wuerfel \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®