From: neil.armstrong@linaro.org
To: Maulik Shah <maulik.shah@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support
Date: Mon, 23 Jun 2025 08:21:01 +0200 [thread overview]
Message-ID: <84868edc-87fd-44ff-949f-60191f9bee35@linaro.org> (raw)
In-Reply-To: <20250623-rsc_v4-v1-1-275b27bc5e3c@oss.qualcomm.com>
On 23/06/2025 07:49, Maulik Shah wrote:
> Register offsets for v3 and v4 versions are backward compatible. Assign v3
> offsets for v4 and all higher versions to avoid end up using v2 offsets.
>
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---
> drivers/soc/qcom/rpmh-rsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index cb82e887b51d4401edba713348eed9621622b73b..fdab2b1067dbb13efbbef5cc3ef795a65fc2d6a1 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -1072,7 +1072,7 @@ static int rpmh_rsc_probe(struct platform_device *pdev)
> drv->ver.minor = rsc_id & (MINOR_VER_MASK << MINOR_VER_SHIFT);
> drv->ver.minor >>= MINOR_VER_SHIFT;
>
> - if (drv->ver.major == 3)
> + if (drv->ver.major >= 3)
> drv->regs = rpmh_rsc_reg_offset_ver_3_0;
> else
> drv->regs = rpmh_rsc_reg_offset_ver_2_7;
>
> ---
> base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
> change-id: 20250623-rsc_v4-ec10a1aadbb8
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2025-06-23 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 5:49 Maulik Shah
2025-06-23 6:21 ` neil.armstrong [this message]
2025-06-23 9:29 ` Konrad Dybcio
2025-07-17 4:31 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84868edc-87fd-44ff-949f-60191f9bee35@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maulik.shah@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®