From: Dan Carpenter <dan.carpenter@linaro.org>
To: Calvince Otieno <calvncce@gmail.com>
Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <error27@gmail.com>, Archana <craechal@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Simon Horman <horms@kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging/wlan-ng: remove strcpy() use in favor of strscpy()
Date: Thu, 12 Oct 2023 13:15:04 +0300 [thread overview]
Message-ID: <848becd6-9f65-4316-a2f0-ebf2ed2f5758@kadam.mountain> (raw)
In-Reply-To: <f0c12a00-ad9e-45b2-9cb2-7a84f4f10ef9@kadam.mountain>
On Thu, Oct 12, 2023 at 01:03:40PM +0300, Dan Carpenter wrote:
> The simplest approach is to do a:
>
> git grep strscpy | grep " - 1"
>
> But the better approach would be to write a Smatch or Coverity check to
> prevent these in the future.
I meant Coccinelle not Coverity. Duh...
Also btw, sometimes we want to keep the "don't necessarily terminate the
string behavior". That's rare and ugly, but it does exist.
regards,
dan carpenter
prev parent reply other threads:[~2023-10-12 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 5:27 Calvince Otieno
2023-10-12 9:17 ` Bagas Sanjaya
2023-10-12 9:57 ` Calvince Otieno
2023-10-12 10:03 ` Dan Carpenter
2023-10-12 10:15 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=848becd6-9f65-4316-a2f0-ebf2ed2f5758@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=bagasdotme@gmail.com \
--cc=calvncce@gmail.com \
--cc=craechal@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®