mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Dmitry Osipenko <digetx@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] Support headset on Tegra boards that use WM8903
Date: Thu, 9 Apr 2020 10:54:42 -0600	[thread overview]
Message-ID: <848cc6c5-e8e4-2796-3ee1-3e12a3e92c54@wwwdotorg.org> (raw)
In-Reply-To: <5c9c995a-a571-e543-e680-30739cb1561c@gmail.com>

On 4/9/20 8:52 AM, Dmitry Osipenko wrote:
> 30.03.2020 23:40, Dmitry Osipenko пишет:
>> Hello,
>>
>> Some devices have a 4-pin jack instead of a 3-pin and currently the
>> WM8903 configuration is hardcoded to the case of 3-pin jack in the
>> Tegra's ASoC driver. A new device-tree property is required in order
>> to convey that hardware has a 4-pin jack, and thus, microphone's
>> detection needs to be done in a different way.
>>
>> In particular this is needed for Acer A500 tablet device that has
>> a 4-pin headset jack, otherwise userspace sees headset instead of
>> headphones and internal microphone isn't enabled by ALSA UCM rule
>> when it should be. Please review and apply, thanks in advance.
>>
>> Dmitry Osipenko (2):
>>   dt-bindings: sound: tegra-wm8903: Document new nvidia,headset property
>>   ASoC: tegra: tegra_wm8903: Support nvidia,headset property
>>
>>  .../devicetree/bindings/sound/nvidia,tegra-audio-wm8903.txt | 1 +
>>  sound/soc/tegra/tegra_wm8903.c                              | 6 +++++-
>>  2 files changed, 6 insertions(+), 1 deletion(-)
>>
> 
> Jon / Stephen, are you okay with this patchset? Could you please ack it?
> Thanks in advance.

It looks plausible based on commit descriptions, but I don't remember
the details of those APIs well enough to actually review the code change.

  reply	other threads:[~2020-04-09 16:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-30 20:40 Dmitry Osipenko
2020-03-30 20:40 ` [PATCH v1 1/2] dt-bindings: sound: tegra-wm8903: Document new nvidia,headset property Dmitry Osipenko
2020-04-10 17:44   ` Rob Herring
2020-04-14 14:47   ` Applied "ASoC: tegra-wm8903: Document new nvidia, headset property" to the asoc tree Mark Brown
2020-03-30 20:40 ` [PATCH v1 2/2] ASoC: tegra: tegra_wm8903: Support nvidia,headset property Dmitry Osipenko
2020-04-14 14:47   ` Applied "ASoC: tegra: tegra_wm8903: Support nvidia, headset property" to the asoc tree Mark Brown
2020-04-09 14:52 ` [PATCH v1 0/2] Support headset on Tegra boards that use WM8903 Dmitry Osipenko
2020-04-09 16:54   ` Stephen Warren [this message]
2020-04-09 17:13     ` Dmitry Osipenko
2020-04-09 17:29       ` Mark Brown
2020-04-09 17:33         ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=848cc6c5-e8e4-2796-3ee1-3e12a3e92c54@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®