From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D68C2F39C7 for ; Wed, 21 Jan 2026 04:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768968541; cv=none; b=eXQ0jspEFusugjEwNUXQ7Vcj0TMO+6C4C4ZvQOBqI8KbkPe52m32DlgtuvUZ1NsKKbhv5YbF50IkECBflMOA8wNHRFSNJrq8lyqvDmJCYKjMOxljviOwsZ2GqOpKVAQ9rTBvabbGV1ve4rO/yuYqXSJxgKEvyFM9BNihVUIsbgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768968541; c=relaxed/simple; bh=o30k9E1o9ocTKSpuBX2i5MTmcEsomKYiKwIKJXTKNcw=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=JsYIZCwewmGeAGFFsD5DHK3aFNdTV9fn7eMdc+dYwDTPeH1m6kvFw7U6Rdj96Fd4KIDcg4dxY69d0FYu5j+iKlsjpvscfCqxg2w3LH+yVWkPwAZS9lGK33ByeW9HDDrKEZnokjTKK+rLaXxu7T58Q1yfpAo0FnHaeeFq5bOTbng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fz3iRJzE; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=dP3obej0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fz3iRJzE"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="dP3obej0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768968530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vHHkm5Bjk5imhl4lGVMoSCR5TkexCwEXfLnS8LKrLe0=; b=Fz3iRJzEnlEqhHHR/zec4OiU7I8yUbhl2Ie2VmN4jNYWHVySRpqhqQo6Aqs/6YGXXmqmou fdnWeLQUBaxIn4NG7YTP6KkS27CuFALL8m+6BBxeUtkihJGmso+1ATiqe0hBsYSs1Jk+Xz JSgDcLam3XaWJTc6xfADp7Kxg/XYauw= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-qjr4mL_KPXK8WcG8AhgKeQ-1; Tue, 20 Jan 2026 23:08:47 -0500 X-MC-Unique: qjr4mL_KPXK8WcG8AhgKeQ-1 X-Mimecast-MFC-AGG-ID: qjr4mL_KPXK8WcG8AhgKeQ_1768968527 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89467edcd21so50498326d6.0 for ; Tue, 20 Jan 2026 20:08:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768968527; x=1769573327; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=vHHkm5Bjk5imhl4lGVMoSCR5TkexCwEXfLnS8LKrLe0=; b=dP3obej0QE3CdAvTdVLwhvL++bTfuMdT97fhDhTp3xBzDjNqM/U8I5lhVIyVP81TcM tK2XnB2Agith6kAMZmzBuzt7o2JaWk5kFTfkXJVidhpgVBuWDH1ArQI/hinm/3d7oXhi eOhHgfebakG6181NtPI+3VHC0QNX7PjnvX/xKNtCNqZT1jBsVa3pwamxAKUtm02RNb30 42436JRxk4ABADtrGA6QppXlhQtBpGuVVaj2U71I5/xC56I++1mLIWT7GH1Yhx+13ivs 83YGQDg19AXYGLmr+2yJmQadP1PYy8j+giyWZ5iZCNYUL0uqGTcOV84DDe9W1WsUYQNf NwKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768968527; x=1769573327; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vHHkm5Bjk5imhl4lGVMoSCR5TkexCwEXfLnS8LKrLe0=; b=Ac20u8K7ezrkAptLT2RHw7um2jYk0S0/+1EGIB9pEsLKvmJ4J1iXsqcUz5gS/m0Q0X JVB+xyCk6DnN1w2z6+MwKKIVzzob3kXsFT0yK3yfFzcZJ40YyUAWeLeHCY/vn8yJ8l4g Os+phhokskhVF+VBeSH5p89W74OOpeX/TH53e2W8M253Je2JEa9yTQsU7jW7yexQk4G1 65Ykk2EprhPa0LC75wSHTRDN61z6SjY3CXgcd22KpQk0le2qDNjkYY8OLfFjex6xB3Q7 HkYphwupJvFllbmtOl2esOXCJAQcPdMtNVkdoxfTGJxpeMww0ZlMNUSXQcFV6YSxQ2Vp SUgQ== X-Forwarded-Encrypted: i=1; AJvYcCV+bVtyFpVRlocentRUBsCF62EV6R/HgbN0qX9tlwjM+qXxxvVIbUHS8ybKX42bh2eZoq7qa3ubNne7QGI=@vger.kernel.org X-Gm-Message-State: AOJu0YyIeDrfX2fER/38koxMSq8qqvyzcE/vCn1ZzTJc5SXkkzoSbYT0 X+hJruJDVk52n0GuisxjNR/+BNlh8QevQvxOWdbE7UQktH5kdR1zLfN7O0AnnLzErnhGKjCgFcY 3AU4G+lopbzMXmuEDysbFnIa/jOoijVEIAWtJ014OcFwku7L3P+O4JsN6Ml6DUFzNkw== X-Gm-Gg: AZuq6aKdtoEG0v6f9BsaQXtCEaaXb//8xGuLTCKT1RTtInx80iUADv4jt0g77kdAjCe b4HVjCWsol7DEPy5ZtFfNAK3W57O8NPpGnitZcJUJ2ovAdOSB3MWx2cojw/YjhLgNdHa41zuRsF YbqGZvqeB7WP8ROBs2Fr2Sapl8krzvKGkc1f938y0N9Mx/YBIhd5erfNohwu0S40p18eRT2lgU5 KfJkzKoyBpTMEIp3j4wMFS5KYpekdFBtLwH/BRZvkZTNxVaEyHv1CLRXJcVKWIS083EfJCWy3OE 2Eo3PcU5hK9Rs2mR831uD3wItQqSLonHk4BtzpzztW5lk+hc0QARTYTpFpvNmWYfC7rQ0CBjl0s hLeLQGC8zY04orrxmVK2FHTG2VqsfJh77eyGFqYsxgBasCRk+n3bKoJj1 X-Received: by 2002:a05:6214:1243:b0:890:6331:7e88 with SMTP id 6a1803df08f44-8942e4b8f8fmr239200966d6.44.1768968527026; Tue, 20 Jan 2026 20:08:47 -0800 (PST) X-Received: by 2002:a05:6214:1243:b0:890:6331:7e88 with SMTP id 6a1803df08f44-8942e4b8f8fmr239200806d6.44.1768968526744; Tue, 20 Jan 2026 20:08:46 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89471f6b0ebsm5902146d6.55.2026.01.20.20.08.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 20:08:46 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <84955de9-823f-4b3d-9107-f7d4aee38b88@redhat.com> Date: Tue, 20 Jan 2026 23:08:45 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] audit: Quit audit_free_names() early if name list empty To: Al Viro Cc: Paul Moore , Eric Paris , Christian Brauner , linux-kernel@vger.kernel.org, audit@vger.kernel.org, Richard Guy Briggs , Ricardo Robaina References: <20260121023509.410423-1-longman@redhat.com> <20260121031105.GB3183987@ZenIV> Content-Language: en-US In-Reply-To: <20260121031105.GB3183987@ZenIV> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/20/26 10:11 PM, Al Viro wrote: > On Tue, Jan 20, 2026 at 09:35:08PM -0500, Waiman Long wrote: >> Optimize audit_free_names() by quitting early if the name list is empty. >> This eliminates the need to acquire and release the fs_struct spinlock >> in path_put(). > Why would path_put() go anywhere need fs_struct spinlock??? > path_put() is defined in include/linux/fs_struct.h. It calls read_seq{un}lock_excl(&fs->seq) which, in turn, acquires the releases the spinlock underneath the seqlock_t. Cheers, Longman