From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F0BC4332F for ; Tue, 20 Dec 2022 13:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233856AbiLTNE0 (ORCPT ); Tue, 20 Dec 2022 08:04:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233825AbiLTNET (ORCPT ); Tue, 20 Dec 2022 08:04:19 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 218BF167F9; Tue, 20 Dec 2022 05:04:17 -0800 (PST) Received: from [192.168.1.15] (91-154-32-225.elisa-laajakaista.fi [91.154.32.225]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 82A6056D; Tue, 20 Dec 2022 14:04:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671541456; bh=ZvxB9T70TZ+qvTHqWsyTCrDs0kOqGqkVtT2zxrsKU+M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Hfe8povylTwTJG50jVH0Tn86842ASz9JpSTsbusSKKZes9PP6XL5b5jd/sDohCNTq vyb1DV8if6dwIrMQ37CmKoPNnxvP2rjgWz59tfsW8UG/PgasyHhqBQvWWwB1FG+N57 FjRtiEzmfPSgLw0YXs9+kWhWajNsiJo2fq6HYRA4= Message-ID: <84977593-4671-7582-d5f2-cf69755f1145@ideasonboard.com> Date: Tue, 20 Dec 2022 15:04:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v6 5/5] drm/tidss: Enable Dual and Duplicate Modes for OLDI Content-Language: en-US To: Aradhya Bhatia , Jyri Sarha , Rob Herring , David Airlie , Daniel Vetter , Krzysztof Kozlowski Cc: DRI Development List , Devicetree List , Linux Kernel List , Nishanth Menon , Vignesh Raghavendra , Rahul T R , Devarsh Thakkar , Jayesh Choudhary References: <20221119173019.15643-1-a-bhatia1@ti.com> <20221119173019.15643-6-a-bhatia1@ti.com> From: Tomi Valkeinen In-Reply-To: <20221119173019.15643-6-a-bhatia1@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/11/2022 19:30, Aradhya Bhatia wrote: > The AM625 DSS IP contains 2 OLDI TXes which can work together to enable 2 > cloned displays of or even a single dual-link display with higher > resolutions like WUXGA (1920x1200@60fps) with a reduced OLDI clock > frequency. > > Configure the necessary register to enable and disable the OLDI TXes > with required modes configurations. > > Signed-off-by: Aradhya Bhatia > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index f26129fb1d8f..cf43de6216a5 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -1012,8 +1012,8 @@ static void dispc_enable_oldi(struct dispc_device *dispc, u32 hw_videoport, > int count = 0; > > /* > - * For the moment DUALMODESYNC, MASTERSLAVE, MODE, and SRC > - * bits of DISPC_VP_DSS_OLDI_CFG are set statically to 0. > + * For the moment MASTERSLAVE, and SRC bits of DISPC_VP_DSS_OLDI_CFG are > + * always set to 0. > */ > > if (fmt->data_width == 24) > @@ -1030,6 +1030,26 @@ static void dispc_enable_oldi(struct dispc_device *dispc, u32 hw_videoport, > > oldi_cfg |= BIT(0); /* ENABLE */ > > + switch (dispc->oldi_mode) { > + case OLDI_SINGLE_LINK_SINGLE_MODE: > + /* All configuration is done for this mode. */ > + break; > + > + case OLDI_SINGLE_LINK_CLONE_MODE: > + oldi_cfg |= BIT(5); /* CLONE MODE */ > + break; > + > + case OLDI_DUAL_LINK_MODE: > + oldi_cfg |= BIT(11); /* DUALMODESYNC */ > + oldi_cfg |= BIT(3); /* data-mapping field also indicates dual-link mode */ > + break; > + > + default: > + dev_warn(dispc->dev, "%s: Incorrect oldi mode. Returning.\n", > + __func__); > + return; > + } > + > dispc_vp_write(dispc, hw_videoport, DISPC_VP_DSS_OLDI_CFG, oldi_cfg); > > while (!(oldi_reset_bit & dispc_read(dispc, DSS_SYSSTATUS)) && Reviewed-by: Tomi Valkeinen Tomi