From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbdAWMG7 (ORCPT ); Mon, 23 Jan 2017 07:06:59 -0500 Received: from mout.web.de ([217.72.192.78]:62854 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdAWMG4 (ORCPT ); Mon, 23 Jan 2017 07:06:56 -0500 Subject: Re: blk-throttle: Move three assignments for the variable "ret" in tg_set_max() To: Johannes Thumshirn , linux-block@vger.kernel.org References: <75495d45-cfc4-9740-39e4-bd4c3e71232b@users.sourceforge.net> <20170123091510.GA3517@linux-x5ow.site> <130ce081-e9a2-4744-c74b-b73bea5ae98c@users.sourceforge.net> <20170123114609.GA8200@linux-x5ow.site> Cc: Jens Axboe , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <849a1dbc-f4c0-caf0-ad7e-706c08127c68@users.sourceforge.net> Date: Mon, 23 Jan 2017 13:06:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170123114609.GA8200@linux-x5ow.site> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:XVSwQvainTrA7wHl4iMIhe0sEqSrLhkFkhRA5d1yFLcJaX9D6dX r5Rcl2qgQOVlLWzx5UGCU43Jjo+X2pgs6nKA8Sur8EWZyqwY+Z0rHIifjI+f66Lo0sYgBpw LXmQkcpR2U59Dsy/4JGEBTI6ada1sHBex2dU16qMvpnT2R/648w0Jy6Fvl37oyqyLhHKyq2 5br5MejoJ/2qtiVxfz5eA== X-UI-Out-Filterresults: notjunk:1;V01:K0:TXf5Jn07PxU=:Jrl6WkTSp1I7/fI+Nht5yX +KA7Gto0nizQDgahlJeg34m8FbM66Em/sJuoKgVUuVAJMs+50UjjK4MwmrCa6mG+AG5v9zWp0 FAIXx12anUrMuyXpHQVT1yg/vyFS+SfZ+/9mEjycRP2Ub5hlXCNiuDv6hEX/+0K0aU3asx7pp dsDJzF/jM5WMSDe5taXQVBf2bBjzP11+4VjTS5tPUFqwsS+KC2QOiFoHMw5/J0PR3g9EtSSWA YPb8V8o9vnLX6zy55zdhBgumS1FAFN7ZNxqHt/aO4tGVDdvKYmU4TPooEaPQBubONZtL+32bk 4GU2IiuutraSHcNPslxFYQefuVhgWKjXJLuZL+19lDQubN9aACr9dwOw4jOqGsBq/qn1ZOE8v t3gUl/1KOPXtU7RYvHFdioS9wxhS5mK5pyPw8KVu5uQ4FFsG0aimR4kQrmoTfTRRfDxS/996v OIdLGLQUNCMKl9RaA7YI4uAkKQ4tzIG6SEWqXzR/4waoJCGAVRxyLtpaHX95wU0m/xfw3w87/ igeHXf24GeXyel/13QAxUsQ6KGnKwZf7unRCRLmsWX9eiOaNn9v3Ghq42umltESqTa0yyMj8n aEne5p83/ZVJEgmBE8nKWc+GLQ2MdbpEXuYYsEPB1zE4gHUJuJJAZUPZiE3KfE5HqYSRGXJle xwy1coO4sGiiGCtcL8D5FLsrMRVQVCYEdwHwFFKhr8jbJxefO/nLRwbQRcwIbbfP60pkNQDSB NZYMx+HqVIloMi4vIFp6ivJ9G5it35JUeOhuokwFHp45/27RFvKx8+ky66iCepZc48im48Yoa jcEOvHE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> We have got different preferences for the placement of error code settings. > Yes we do, so what's the point? Both are OK. Can a function implementation be executed a bit faster in the case that error codes will usually only matter if they would be set after a concrete software failure > Please don't go down that road it opens so much potential for needless bikeshedding > and waste all of our (including your) time. I would appreciate to clarify involved run time consequences a bit more. Regards, Markus