From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755198Ab2ITNTe (ORCPT ); Thu, 20 Sep 2012 09:19:34 -0400 Received: from gate.crashing.org ([63.228.1.57]:55940 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752533Ab2ITNTb convert rfc822-to-8bit (ORCPT ); Thu, 20 Sep 2012 09:19:31 -0400 Subject: Re: [RFC][PATCH 2/3] iommu/fsl: Add iommu domain attributes required by fsl PAMU driver. Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: Date: Thu, 20 Sep 2012 08:19:13 -0500 Cc: Wood Scott-B07421 , "joerg.roedel@amd.com" , "iommu@lists.linux-foundation.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Content-Transfer-Encoding: 8BIT Message-Id: <84F4C3DA-4B61-4D1D-9FB3-B3F520BFE022@kernel.crashing.org> References: <1348060632-12997-1-git-send-email-b16395@freescale.com> <1348060632-12997-3-git-send-email-b16395@freescale.com> <6B8A3365-C97E-4742-A0DD-D8FD6BA358EB@kernel.crashing.org> <1348099936.22800.21@snotra> To: Sethi Varun-B16395 X-Mailer: Apple Mail (2.1278) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sep 20, 2012, at 4:46 AM, Sethi Varun-B16395 wrote: > > >> -----Original Message----- >> From: Wood Scott-B07421 >> Sent: Thursday, September 20, 2012 5:42 AM >> To: Kumar Gala >> Cc: Sethi Varun-B16395; joerg.roedel@amd.com; iommu@lists.linux- >> foundation.org; linuxppc-dev@lists.ozlabs.org; linux- >> kernel@vger.kernel.org; Sethi Varun-B16395 >> Subject: Re: [RFC][PATCH 2/3] iommu/fsl: Add iommu domain attributes >> required by fsl PAMU driver. >> >> On 09/19/2012 08:52:27 AM, Kumar Gala wrote: >>> >>> On Sep 19, 2012, at 8:17 AM, >>> wrote: >>> >>>> From: Varun Sethi >>>> >>>> Added the following domain attributes required by FSL PAMU driver: >>>> 1. Subwindows field added to the iommu domain geometry attribute. >>>> 2. Added new iommu stash attribute, which allows setting of the >>>> LIODN specific stash id parameter through IOMMU API. >>>> 3. Added an attribute for enabling/disabling DMA to a particular >>>> memory window. >>>> >>>> Signed-off-by: Varun Sethi >>>> --- >>>> include/linux/iommu.h | 30 ++++++++++++++++++++++++++++++ >>>> 1 files changed, 30 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h index >>>> 7e83370..eaa40c6 100644 >>>> --- a/include/linux/iommu.h >>>> +++ b/include/linux/iommu.h >>>> @@ -44,6 +44,28 @@ struct iommu_domain_geometry { >>>> dma_addr_t aperture_start; /* First address that can be >>> mapped */ >>>> dma_addr_t aperture_end; /* Last address that can be >>> mapped */ >>>> bool force_aperture; /* DMA only allowed in mappable >>> range? */ >>>> + >>>> + /* The subwindows field indicates number of DMA subwindows >>> supported >>>> + * by the geometry. Following is the interpretation of >>>> + * values for this field: >>>> + * 0 : This implies that the supported geometry size is 1 MB >>>> + * with each subwindow size being 4KB. Thus number of >>> subwindows >>>> + * being = 1MB/4KB = 256. >>>> + * 1 : Only one DMA window i.e. no subwindows. >>>> + * value other than 0 or 1 would indicate actual number of >>> subwindows. >>>> + */ >>>> + u32 subwindows; >>>> +}; >>>> + >>>> +/* This attribute corresponds to IOMMUs capable of generating >>>> + * a stash transaction. A stash transaction is typically a >>>> + * hardware initiated prefetch of data from memory to cache. >>>> + * This attribute allows configuring stashig specific parameters >>>> + * in the IOMMU hardware. >>>> + */ >>>> +struct iommu_stash_attribute { >>>> + u32 cpu; /* cpu number */ >>>> + u32 cache; /* cache to stash to: L1,L2,L3 */ >>> >>> seems like this should be enum instead of u32 for cache >>> >>> With enum being something like: >>> >>> enum iommu_attr_stash_cache { >>> IOMMU_ATTR_CACHE_L1, >>> IOMMU_ATTR_CACHE_L2, >>> IOMMU_ATTR_CACHE_L3, >>> }; >> >> Don't we want these structs to be usable via some VFIO ioctl? In that >> case they need to use fixed size types. >> > Yes, this would be usable via vfio ioctl. But, then the caller should be > aware of supported stash targets. May be I should add an interface for the caller, > to query supported stash targets. Guess the caller probably knows, but thinking we should move the #defines for valid values into this file out of pamu specific files. - k