mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tao Ren <taoren@fb.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Christopher Covington <cov@fb.com>, Tian Fang <tfang@fb.com>
Subject: Re: [PATCH] clocksource/drivers/fttmr010: fix set_next_event handler
Date: Thu, 20 Sep 2018 21:09:36 +0000	[thread overview]
Message-ID: <84F9ED20-0964-462E-B389-39B107A232D3@fb.com> (raw)
In-Reply-To: <CACRpkdZGjvLZY7snev5W2rRGgO7bQsSqn5u2v5Nw0tH9sa4yBw@mail.gmail.com>

On 9/20/18, 8:46 AM, "Linus Walleij" <linus.walleij@linaro.org> wrote:
 
> Actually this is much more intuitive too, it is the typical way to handle
> a down-counting timer. Good catch!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thank you Linus for the quick review!
    
> Sorry for any cargo-cult programming on my part :/
> Would be nice to get a nod from the AST2400 users that this works
> for them too, so included them in the To: field.

Make sense. I actually booted up kernel on qemu-palmetto (ast2400) but I'm doubting if test is valid because it depends on how qemu emulates the hardware. It would be great if someone can help to verify the patch on physical ast2400.

> It actually would make kind of sense to restart the up-counting
> timer from zero and set match to whatever value is passed in
> as well, so I might send a patch for this. It's no regression though
> so no hurry with that.

I agree. Besides being more intuitive, timer overflow interrupt (when <cr + cycles> overflows) could also be avoided by resetting the counter.

Thanks,
Tao Ren 


  reply	other threads:[~2018-09-20 21:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 22:13 Tao Ren
2018-09-19 23:16 ` Daniel Lezcano
2018-09-20 15:45 ` Linus Walleij
2018-09-20 21:09   ` Tao Ren [this message]
2018-09-21  3:32     ` Joel Stanley
2018-09-21  6:22       ` Lei YU
2018-09-21 18:11         ` Tao Ren
2018-09-21 18:11       ` Tao Ren
2018-09-24 23:20         ` Joel Stanley
2018-09-25  0:40           ` Tao Ren
2018-09-25 17:13           ` Sai Dasari
2018-09-25 19:16             ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84F9ED20-0964-462E-B389-39B107A232D3@fb.com \
    --to=taoren@fb.com \
    --cc=andrew@aj.id.au \
    --cc=cov@fb.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=joel@jms.id.au \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=tfang@fb.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®