mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: nicolas sitbon <nicolas.sitbon@gmail.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: epoll_ctl and const correctness
Date: Wed, 25 Mar 2009 22:37:14 +0100	[thread overview]
Message-ID: <84a01a8b0903251437l9f9059s3c548b5d35ea47d4@mail.gmail.com> (raw)
In-Reply-To: <49CAA055.5060603@goop.org>

You don't teach me anything, I know that, the fact is the
documentation is incomplete, so rather saying that, please answer my
questions. For the moment, only the documenation and the prototype of
epoll are buggy.

2009/3/25 Jeremy Fitzhardinge <jeremy@goop.org>:
> nicolas sitbon wrote:
>>
>> valgrind confirms this
>> behaviour, so am I wrong?
>
> That doesn't prove very much.  Unlike usermode code, Valgrind doesn't
> instrument the kernel, so it computes the side-effects of kernel operations
> by parsing the syscall stream and simulating the effect.  (That is to say,
> it strengthens your argument somewhat, but valgrind's handling of this
> syscall could be buggy.)
>
>>  or the good prototype is
>>
>> int epoll_ctl(int epfd, int op, int fd, struct epoll_event const *event);
>>
>
> Putting "const" first is conventional.
>
>   J
>

  reply	other threads:[~2009-03-25 21:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 12:45 nicolas sitbon
2009-03-25 16:23 ` Davide Libenzi
2009-03-25 17:27   ` nicolas sitbon
2009-03-27 19:43   ` nicolas sitbon
2009-03-25 21:21 ` Jeremy Fitzhardinge
2009-03-25 21:37   ` nicolas sitbon [this message]
2009-03-27  9:44     ` nicolas sitbon
2009-03-27 21:47       ` Michael Tokarev
2009-03-27 22:17         ` nicolas sitbon
2009-03-27 22:30           ` nicolas sitbon
2009-03-27 22:40             ` Davide Libenzi
2009-03-27 22:42             ` Michael Tokarev
2009-03-27 22:55               ` nicolas sitbon
2009-03-27 23:01                 ` Michael Tokarev
2009-03-27 23:10                   ` nicolas sitbon
2009-03-27 23:16                     ` Michael Tokarev
2009-03-27 23:25                       ` nicolas sitbon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84a01a8b0903251437l9f9059s3c548b5d35ea47d4@mail.gmail.com \
    --to=nicolas.sitbon@gmail.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®