From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 318DAC61DA3 for ; Tue, 21 Feb 2023 23:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbjBUXxe (ORCPT ); Tue, 21 Feb 2023 18:53:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjBUXxD (ORCPT ); Tue, 21 Feb 2023 18:53:03 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1540F9ED4 for ; Tue, 21 Feb 2023 15:53:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677023582; x=1708559582; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QoqD8P6ikBakoLwMBIWameGKAp9SzS0lMN/1Sy3cuio=; b=LYKsuTqWRghHd9g1xNZXyL7kqdux5RDK8e3s0zkv9IBNb++3/deASIb1 ruUS0Qro7SV6JanQn2BpRi/0oF8migIM7o9K3Dy4xG3yYfBBflk1lmGXG 7xHK034yDjF8zFTRfad+zxpWJZxgE/GXiIMQoNMHbGLq3uTLL+Z3s/BCp ZAS/4iZW2rUj2vFKV1WAOoi9nhgvmuGSG9Zg3LfEqGRbsVKusfHjOSd4w e7cLyVkdB1yYXzuvCpFtHc0WulCEutEn4qjwovGBsSc6BrmUbN2HGXHPr 8hHztbgi7rHTs5xm+ub7doEE3d3tSJ7U3WRuN9yWxI/Ml87SCOPnbUxpK w==; X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="332789092" X-IronPort-AV: E=Sophos;i="5.97,317,1669104000"; d="scan'208";a="332789092" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 15:53:00 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="735660217" X-IronPort-AV: E=Sophos;i="5.97,317,1669104000"; d="scan'208";a="735660217" Received: from taevough-mobl.amr.corp.intel.com (HELO [10.209.174.213]) ([10.209.174.213]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 15:52:59 -0800 Message-ID: <84a9fb4c-daf3-84ac-3946-f554a8d5d309@linux.intel.com> Date: Tue, 21 Feb 2023 18:48:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.7.1 Subject: Re: [PATCH V3 3/8] soundwire: amd: register SoundWire manager dai ops To: "Mukunda,Vijendar" , vkoul@kernel.org Cc: alsa-devel@alsa-project.org, amadeuszx.slawinski@linux.intel.com, Mario.Limonciello@amd.com, Sunil-kumar.Dommati@amd.com, Basavaraj.Hiregoudar@amd.com, Mastan.Katragadda@amd.com, Arungopal.kondaveeti@amd.com, Bard Liao , Sanyog Kale , open list References: <20230220100418.76754-1-Vijendar.Mukunda@amd.com> <20230220100418.76754-4-Vijendar.Mukunda@amd.com> <70f873a4-5b41-aede-55b5-8a731c892198@amd.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <70f873a4-5b41-aede-55b5-8a731c892198@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/21/23 16:05, Mukunda,Vijendar wrote: > On 21/02/23 21:29, Pierre-Louis Bossart wrote: >> >> >>> +static const struct snd_soc_dai_ops amd_sdw_dai_ops = { >>> + .hw_params = amd_sdw_hw_params, >> don't you need a .prepare to deal with suspend-resume? > DSP based solution is not implemented yet. > As per our understanding In .prepare () callback, there is > no extra logic needs to be implemented. Because of it, > we have dropped .prepare() callback. You don't need any logic IF the IP keeps its context while suspended. That wasn't the case for us, we had to re-program the registers when resuming.