From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 873BE136A for ; Wed, 22 Jan 2025 11:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737544786; cv=none; b=EEDj/LG+lZSzRKZcaTPMnQ7nZnynQXw+N28mdJYBBDEczvvu0F3x0cyMnCVElvVGH+IkeB1Iae65LEm4RZJpW44xoZRjdlaO5SfgxIgWViLlqW/rgaNnGFpY3naf3VbNAvo+cT4BUiqxrksB6dkhIYBCnaPufec2eJzQgRpX9A4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737544786; c=relaxed/simple; bh=IqEqVflDJ93Yb85wZ2/BENhyZNrdFO07G5djbVNaNkQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=RevMYtMia4w/dRUkpihxcgnsCZB8HPINr9FxfkKPfm+RC5OVRiQeKbAAhLje9HuIHo9ock5pbH5d5sIQcc7ei4AabzFvMtBUvUBcd7kVWDuCAjsko7IFCitoJCA7I0qXsKjHFOnPU8kw1ElJl2C/1zn5Mp7Of0vGeAQA2B5vAeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fEsmx9/9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fEsmx9/9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737544783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VO4NxuxMnjwsU/LY1YLY8S7j1PhjomQTPI5kHZH06GU=; b=fEsmx9/9JeZ17XbdAK+JMAuuiq6rwqZ8P1i1MONEPqmY3ZPfAYq5HkQu9ZJ5jpbBpaTf+v 9Rf86g1jl0Ar8T086GCyK0WF8rhkJtREAJOH4FEGLkf11wZxXq7fALKGxnoxWzZrLSaFgl Qf3pBJoLYpcOIloGPCCcrGIC6FTFUPA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-wMG2hGrhMaOaD5pdISgrgQ-1; Wed, 22 Jan 2025 06:19:42 -0500 X-MC-Unique: wMG2hGrhMaOaD5pdISgrgQ-1 X-Mimecast-MFC-AGG-ID: wMG2hGrhMaOaD5pdISgrgQ Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4361efc9dc6so36673505e9.3 for ; Wed, 22 Jan 2025 03:19:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737544781; x=1738149581; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VO4NxuxMnjwsU/LY1YLY8S7j1PhjomQTPI5kHZH06GU=; b=cPHsev2JiGSSkgw3P3PdkcwntYcnFBcQOVULkGzhCZw5Twnx4JQ4tFXvJAcer9k7dK wSH3VRU/wU51cM1tkp0TbJtuvyt5FucoyHMgCORWJoiBhPSV4nySD6D5yJ8mZ86WV/K1 o8Ym/PJ7N41gwRWRHdJ1IL23B5HyUK754Hx0AlXu16zCHSMxNM+2sajw2S/ZFkH/TYSe b87Tc6jecO+IzKRQCMocfL8z4xTOp1J3aD3OBaezpVc+X0kWH3rhJBKSgPWZHEekMY4r paF93K3IkHU76OT9ArBiD0gndPsZLPYoZNKpiiQ77i6tICFFLzUS9FUEo6ghKNEiNe8p RG6A== X-Forwarded-Encrypted: i=1; AJvYcCV5gjnZTscQG+XXPBY5xRSVMhCpdm8wu8W+66gUtsGeyKEKkT1j60AC5L5TmnSvsFIQE8NlxLT7vn1HCM0=@vger.kernel.org X-Gm-Message-State: AOJu0YxJ/LcOcachyS7iz9fE8poEN3rI/YXeYRTuFH6XbKy8O1XZAigF fyfbsUfoaGFhjm3fVGsgvfJw1kme3HhHMOfdUf5rZT4s2PttyVA1llWDuc8NgTbueM3uaBEV3o0 W2IL3rE2Zq8ZR49AICHPk2Nmha7FkWPo8+NJtK8chQsd2/JGBLxiJAbfUrvHb5Q== X-Gm-Gg: ASbGnctVpRe12ZPLmAyuJh+xpPQPf4OUX7aNhtNgEnbtR14AbpybwMN5nuCzXv5j35C pzz5pIX7YqcFCVB7dw3w7NrCBq742ZcaxCW2tQAAR6SP17i7EVaKSIKxfWSAVGvbXoWIJ/Acnf0 tQ0xaS5q70+qekrhP1pBRc+ZU5Q+FxtB4N/zjKWjDKdvPIIT/lm1U42YKaSvn7DO/cWy6dqDW+R W2dDQG1IZKKRI0bV/Qmq2jGrObmiSeIswsKIgyjfiTaD1WQbsR8IrrSTQ1fgOSoXjaOk3Mc75ye 7XR4by0GMPhH9xbxO46vyYgNfFc1ZwLVWnsyhxqBeP/TlHf2pFg+NtaHJ5uwroCdZZlMpSAgDoL wxlw6imSYAelDIvxaIvAUGA== X-Received: by 2002:a05:600c:4e09:b0:434:fec5:4ef5 with SMTP id 5b1f17b1804b1-438913e99b0mr222364865e9.14.1737544780948; Wed, 22 Jan 2025 03:19:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFzwuqixIWif15892OqVasoESU1D/ZOPZRnbUaKTUhKTDoOnikaLUJ+L76U+4gmNk+/UBKJQ== X-Received: by 2002:a05:600c:4e09:b0:434:fec5:4ef5 with SMTP id 5b1f17b1804b1-438913e99b0mr222364535e9.14.1737544780621; Wed, 22 Jan 2025 03:19:40 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:db00:724d:8b0c:110e:3713? (p200300cbc70bdb00724d8b0c110e3713.dip0.t-ipconnect.de. [2003:cb:c70b:db00:724d:8b0c:110e:3713]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b1ce51a6sm20029755e9.1.2025.01.22.03.19.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 03:19:40 -0800 (PST) Message-ID: <84ae07bf-de57-4b66-bc18-c94727a92cfe@redhat.com> Date: Wed, 22 Jan 2025 12:19:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: gup: fix infinite loop within __get_longterm_locked To: "zhaoyang.huang" , Andrew Morton , Alistair Popple , John Hubbard , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com, aijun.sun@unisoc.com References: <20250122012604.3654667-1-zhaoyang.huang@unisoc.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250122012604.3654667-1-zhaoyang.huang@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22.01.25 02:26, zhaoyang.huang wrote: > From: Zhaoyang Huang > > We can run into an infinite loop in __get_longterm_locked() when > collect_longterm_unpinnable_folios() finds only folios that are isolated > from the LRU or were never added to the LRU. This can happen when all > folios to be pinned are never added to the LRU, for example when > vm_ops->fault allocated pages using cma_alloc() and never added them to > the LRU. > > Fix it by simply taking a look at the list in the single caller, to see > if anything was added. > > Fixes: 67e139b02d99 ("mm/gup.c: refactor check_and_migrate_movable_pages()") > > Reviewed-by: John Hubbard > Suggested-by: David Hildenbrand ^ you should CC all people here. "git send-email" will usually try doing that automatically. :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb