mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf stat: Improve runtime stat for interval mode
Date: Mon, 20 Apr 2020 22:59:17 +0800	[thread overview]
Message-ID: <84bc1330-dbcb-ea13-e1f6-db0fef214003@linux.intel.com> (raw)
In-Reply-To: <20200420091906.GG718574@krava>

Hi Jiri,

On 4/20/2020 5:19 PM, Jiri Olsa wrote:
> On Fri, Apr 17, 2020 at 08:51:54AM +0800, Jin Yao wrote:
> 
> SNIP
> 
>> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
>> index ec053dc1e35c..d5c326ff46d0 100644
>> --- a/tools/perf/builtin-stat.c
>> +++ b/tools/perf/builtin-stat.c
>> @@ -359,6 +359,7 @@ static void process_interval(void)
>>   	clock_gettime(CLOCK_MONOTONIC, &ts);
>>   	diff_timespec(&rs, &ts, &ref_time);
>>   
>> +	perf_stat__reset_rt_stat();
> 
> could you use just existing:
> 
> 	perf_stat__reset_shadow_per_stat(&rt_stat)
> 
> or perhaps event perf_stat__reset_shadow_stats, given
> that we init walltime_nsecs_stats just few lines below
> 
> jirka
>

Yes, I can use the existing function to reset rt_stat, I don't need to 
define a new one.

Posted v2 yet.

Thanks
Jin Yao

>>   	read_counters(&rs);
>>   
>>   	if (STAT_RECORD) {
> 
> SNIP
> 

      reply	other threads:[~2020-04-20 14:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17  0:51 Jin Yao
2020-04-20  5:44 ` kajoljain
2020-04-20  5:48 ` kajoljain
2020-04-20  5:59   ` Jin, Yao
2020-04-20  9:19 ` Jiri Olsa
2020-04-20 14:59   ` Jin, Yao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84bc1330-dbcb-ea13-e1f6-db0fef214003@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome