From: Bryan O'Donoghue <bod@kernel.org>
To: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>,
'Bryan O'Donoghue' <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/9] media: camss: csid: report frame starts from CSID
Date: Wed, 28 Oct 2026 12:30:15 +0000 [thread overview]
Message-ID: <84bc6332-1db6-4c9c-a956-51b76f96352a@kernel.org> (raw)
In-Reply-To: <20261028093003.722745-6-xiaqinghuan@mail.ustc.edu.cn>
On 28/10/2026 09:29, Qianhui Xu wrote:
> + if (val & INFO_CAMIF_SOF) {
> + /* A new SOF may follow an as-yet unhandled completion. */
> + if (done && csid_read_timestamp(csid, CSID_RDI_EOF_TS(i)) <
> + csid_read_timestamp(csid, CSID_RDI_SOF_TS(i))) {
> + camss_buf_done(csid->camss, csid->id, i);
SOF and buf done need not happen in the same interrupt and quite likely
won't.
This logic can't hold over idle entry/exit scenarios.
Also I think we need a different approach to latching qtime regs, generally.
In fact let me follow up this email with a series to enable
V4L2_EVENT_FRAME_SYNC which is the right way IMO to latch SOF.
---
bod
next prev parent reply other threads:[~2026-10-28 12:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 9:29 [PATCH v2 0/9] media: camss: add SM8750 support Qianhui Xu
2026-10-28 9:29 ` [PATCH v2 1/9] dt-bindings: media: add the Qualcomm SM8750 camera subsystem Qianhui Xu
2026-10-28 12:53 ` Krzysztof Kozlowski
2026-10-28 9:29 ` [PATCH v2 2/9] media: camss: csiphy: add CSIPHY 2.4.0 lane settings for SM8750 Qianhui Xu
2026-10-28 9:29 ` [PATCH v2 3/9] media: camss: csid: unwind the power-on path through a single error label Qianhui Xu
2026-10-28 9:29 ` [PATCH v2 4/9] media: camss: csid: add the 980 generation Qianhui Xu
2026-10-28 9:29 ` [PATCH v2 5/9] media: camss: csid: report frame starts from CSID Qianhui Xu
2026-10-28 12:30 ` Bryan O'Donoghue [this message]
2026-10-28 9:30 ` [PATCH v2 6/9] media: camss: video: check that a buffer is DMA contiguous and add a prepare hook Qianhui Xu
2026-10-28 12:32 ` Bryan O'Donoghue
2026-10-28 9:30 ` [PATCH v2 7/9] media: camss: video: stop the subdevices already started when a start fails Qianhui Xu
2026-10-28 9:30 ` [PATCH v2 8/9] media: camss: vfe: add the gen4 block and SM8750 camera subsystem Qianhui Xu
2026-10-28 9:30 ` [PATCH v2 9/9] arm64: dts: qcom: sm8750: add the " Qianhui Xu
2026-10-28 10:10 ` [PATCH v2 0/9] media: camss: add SM8750 support Vladimir Zapolskiy
2026-10-28 12:09 ` Qianhui Xu
2026-10-28 10:42 ` Hangxiang Ma
2026-10-28 12:09 ` Qianhui Xu
2026-10-28 12:17 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84bc6332-1db6-4c9c-a956-51b76f96352a@kernel.org \
--to=bod@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hangxiang.ma@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=xiaqinghuan@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®