From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7B14756BC for ; Tue, 18 Aug 2026 12:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787057454; cv=none; b=rUB61utM2gUaMbkonu1LCYj9f2ppghK6hxBBuQE1v+ddkyilSyB8b6BQBHmQyPF7jZg43GvAtudEfDXN+Bw8sIkwFjT32dJGc7bIKDcrg0QfFYMupX7pC9nV4rWRpbe4EYLxX58RC8WUzt2xFPK65KLnJXegGorg0akc+f2S9IY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787057454; c=relaxed/simple; bh=9UJP0+UnLhNHthhnuhnSoK+fMhRJRgf6rxK9n9XSqLY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VlfLcqd3ENeeqlDhUDp0QvvdA/Ze8q8pbLr2vP14MVFXPYYLPungc3qqqkpTcUCw9nb6eraMT/ArQzwTgfhIaA42CEebUDte7zlalKUHLiCRxV8M9EBalMv+CSotXq6oK8D5ofwOyvnIlKzX6EyEPEvGMKyVI0Gnju88z7fPfeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V5HJDyHM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A5QMnbsh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V5HJDyHM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A5QMnbsh" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IABI3e514957 for ; Tue, 18 Aug 2026 12:50:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4hLfzkQULc5AeeCQ0RZxw/94NH4NiKad2ELWqLQgObE=; b=V5HJDyHM1Q9khnxu N1nhPlxx5Q9glIy0voaF65Gt+8Ww/mZ9MCYR9hUybrpVlfQBbtw1cudIFAddnOiU Zq6eiOgAe2/UDQ8dVmskJSsZmb5zfNr02UdiANc6CtzWhTlrvAoWCne6HIJZCT0P Yp8Beg93Zmyp3flBJOkw9BDu/eWWR2gDPilxAILg6jkXSEiBOhmhsd1cDjf1lg9Y QW7xaCRkN2aGGko0z/3VAv9/cE6thBAjzhu+4r/yo813dPdLFLjUOSA4/zRssbRV 6Dou7itgtNGogf7IVnzfxTI2bf37K1IA2Gmk0jtEhb2b9NWd0PvH+sE5eic7VBNF 8Et9oQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4ea2jhbs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 12:50:48 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8f3951a6d76so9151986d6.0 for ; Tue, 18 Aug 2026 05:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787057448; x=1787662248; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4hLfzkQULc5AeeCQ0RZxw/94NH4NiKad2ELWqLQgObE=; b=A5QMnbshqwe4hkQ6pIzCuH75oFh4+RlgWQ7OkYU4IvFuoDhZ8FAjcJIYdD7CTvS80E bhscWnWkhVhmUYBR7CFlrVbJKU4Hx2MM3jD4DViiVcUbDV9dfHvHwtshK5iW8VXNyrJ+ jLjh17miUL0nqxbDlybDxmMJCqru5518yYSvBll4ul4ujQ6XEn5dcSQpYD+oa/XAK8/m daBRNGlkGyRn8fkjv429ZGP2aOCNMUnnhk13QN8duIQqIMzoDN09VmwFFMB+0Sr/GFi/ QKTJDODHsjxqMRmiTl/ow0M4NzKRsEAyDXwolX1BLbg4VS3/Ts+olETFe57XuKsYky01 oUiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787057448; x=1787662248; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4hLfzkQULc5AeeCQ0RZxw/94NH4NiKad2ELWqLQgObE=; b=rhlqfSjKPrbS/jtGxlxSkzAk+cEeanIerBFcy11e3KyyGA+yWlpMw3JQy0RbuV501/ b2AhFUAAu+V8Agj7jCKmpZKjIwrTsioM+EQlGtsOAXpcPy0QOyH61Tc+Mkty6x8Eb5RZ yba2gXC62zRx0LgK0BL0GDc4nfCqNYsSzaT6sgA1+OTMrCN0wH7SQa5AcJsvW8oZGiKB 2v1uyRm5369i9PhP0s5r5uO6fdK5VmUyMd5aF4TOn3kxay0ZG8zgalUjcLb+0xlou1EO EevQx7ZmmAGG35r6FspPpUZYt62eG+MsQu1N4DE1xngBVj/qdiTwR2HBsWL7CVZXYxcS ihow== X-Forwarded-Encrypted: i=1; AHgh+RorOy8viGAxl4j9febpCnSgMxPo253mmK1Q8p+QymQ3rOgniGRMNq9SKvy2rr2P9RVhAkZ0CWPDbZNbmHo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3sC3CB+/IidxknFBUN229yc4pqkw37T5oBeE3jl7UNL6O5Mqm e9W6LrFNdJdAPghwLQ/yUR9NvoRtXeaeOpQrhZx6oTl6Y6zgceVgwKU64WD/wTwk525Y695h5WG 1T85HaNiiAmsDNTrjapOKP1SxSUe0ewBh1GWOwvFtcPyM0bdiWCRUiSG8k1F/qXf0SX4= X-Gm-Gg: AR+sD12e5h7FVzMUzyb7EXzYdHmWBCH3awdJ2A2e7NDPNk1QUqCh83gtwAvPUgnhYb6 IPZzotyWOcXTyz9NhisISQu6qJX/hN+2/ewEWGUiNBYREqCjhO9Gvx5BjSoqXEGf4goS8nWDuFE SisuojfIwnlerPpmzPKeFH/9seat21RqUlvuVCliEYFkNUB1vXutzZJjpf18A0OSA5Z4HbbuVdX eyRIuZZORn2RDew0JdD59pazeEooDem3jyUUd593sT5/AIw2+gOXxwq46vOqK7cP4BJli260GIX aepOzbTxp1c0GqonnaUFzBsKSp4W7u9DnLUnEBTHMFSMWub8yCS/Tt8JzTUEITeXXZ3CLQiq2fH vUpqoccf4MJMeVAGGQVD0J2Af X-Received: by 2002:ac8:5a8b:0:b0:51c:845b:ac4 with SMTP id d75a77b69052e-52d8547a9e4mr243319941cf.3.1787057447605; Tue, 18 Aug 2026 05:50:47 -0700 (PDT) X-Received: by 2002:ac8:5a8b:0:b0:51c:845b:ac4 with SMTP id d75a77b69052e-52d8547a9e4mr243319601cf.3.1787057447138; Tue, 18 Aug 2026 05:50:47 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2185b99f78sm152538566b.50.2026.08.18.05.50.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 05:50:46 -0700 (PDT) Message-ID: <84be0a35-b088-4ab2-9111-80809d6d2d53@oss.qualcomm.com> Date: Tue, 18 Aug 2026 14:50:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] slimbus: qcom-ngd-ctrl: match downstream DEF_ACT_CHAN encoding To: casey@samaritansolutions.net, Srinivas Kandagatla Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, stable@vger.kernel.org References: <20260807-slimbus-def-act-chan-v1-1-fd542efb3d30@samaritansolutions.net> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260807-slimbus-def-act-chan-v1-1-fd542efb3d30@samaritansolutions.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA5NCBTYWx0ZWRfXxSGXgynixsc0 xBpSJ8wEA3FhDzmCAseaaEGH83kr1W10mQ23CCr7VWuaHF3H3qstikrqz3HH8yKo4ypdzCW+J1y nx8lI+A+SR7+6G4kTFq2x/BQZ5vOLf9YgIDSsTlYscM28ccgmU+iS7ZJIA3yCCdRZozAGheAzpt YAFe6kfAbnzGEvam8Te0AsxqRphPzRsRf0qJN0Bk1pivr7rrOyetOnm9nW4WEZLj5WigIiVKqjL D43KAnaJnJNBnuH/FfP3RPm8sU/afGg6T1nlK7/KAoUJpZJ1ZANbm8UwKZ3yrwfTHQBWqJ5+2nO +mVTIil1tRhywvB+R5eFapf/HWqHiq7WoHJ0uFY3mgc5fMYWStp/OAND0ZsjqhabRYqmIFmAsCR pda3smNCr+OMXWwUS6TzqAHVvbQwMlzOG4QgDuJ8hFlqDBo5Re2KCVlWMP3YBJaq7HKYVEZGG90 7tS9JZD1vjnRQXxvs9A== X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA5NCBTYWx0ZWRfX5+Kq6vICY6kE jBohfp5WbJ5IQwJY7MzuaiKB/BFFH1gGbFnJ73Ju8Lb145xqb/hJlhuADoUEFwFvqlWQRk4eWZm Ur/yKhjnqYiHd4wXPRcn0DSt9tHTsHE= X-Authority-Analysis: v=2.4 cv=XtfK/1F9 c=1 sm=1 tr=0 ts=6a845528 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=oRWL8vWFAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=7S0yl7ldlo6rjceDY6AA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=ZXulRonScM0A:10 a=OIgjcC2v60KrkQgK7BGD:22 a=ZSzuMzu-C871e8vGMv2q:22 X-Proofpoint-ORIG-GUID: zKkk6I_FYk6A4AGAhqO2vHWgnkbxiOPM X-Proofpoint-GUID: zKkk6I_FYk6A4AGAhqO2vHWgnkbxiOPM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180094 On 8/8/26 2:35 AM, Casey Tunturi via B4 Relay wrote: > From: Casey Tunturi > > During my investigations, and some rather incessant cross-checking of > blueline's SLIMbus path, I found that Qualcomm's downstream driver > packs the first DEF_ACT_CHAN byte differently from mainline. Bits [7:5] > hold the data format; bits [4:0] hold the five-bit client number. > > I changed ours to match. It made no immediate difference on my own > hardware: blueline's current values produce 0x0f either way. The > downstream layout is correct and should help devices that use upper > logical-address bits or a non-zero data format. > > Fixes: 52490169cddf ("slimbus: ngd: add stream support") > Cc: stable@vger.kernel.org > Signed-off-by: Casey Tunturi > --- The semantics match, I don't know what side effects that may uncover Acked-by: Konrad Dybcio Konrad