From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A382D1925 for ; Mon, 23 Jun 2025 17:45:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=157.90.84.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750700724; cv=none; b=f05YOxZgVqAItEUsEDexgz7H0JkXSzuFBNGAymOD+K8JO509vYXfxcRRnZj68C6WMh63qWrKrp3Il9RKXkpWyhdohO+KGiaDURGuFcxp4B1/jtNsK3BwYC66TCUtUW2+AXvwRAAQHkV2gX6QAJJpdZld86peI/mXY3T7H4cvbLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750700724; c=relaxed/simple; bh=YPq3XiAKjaGps3EPDCGNbIOCrzzv9LithrDuW2xEyXI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R57FA8hm5H5dTYUmpt+xuG5UASHZaurfXZy5cBidBG+aZvuxuhiLU64TGlJ7WakO2Ew8+Q5EilA02kKt7+aYeX+C9supL1zDaDk6A475BX+XQlPJmq7hR9cnD3xrzFDdu+UwpLpPOHSUcs4rP45n5wJAzhvTsGMVMspaPY/VErQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com; spf=pass smtp.mailfrom=tuxedocomputers.com; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b=lvpQiYLb; arc=none smtp.client-ip=157.90.84.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b="lvpQiYLb" Received: from [192.168.42.116] (pd9e59880.dip0.t-ipconnect.de [217.229.152.128]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPSA id 28CBB2FC01F5; Mon, 23 Jun 2025 19:45:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1750700719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FIN6wGJgM6sJP36YGLE7y7vieoBuFwosp9X9CclnC7M=; b=lvpQiYLbtkqhGBdlC1dtkdukrhKTC4J4f1OHZdRhv1Bm+/G7kcfL/4hLXs7mie0e5XDj6K HP+/WrqSq7kh/XO0syvttWbbjW9RCTfr1NY0Kz5HccumulRYT5iGY1yz/9Q0fL7BlWRp71 5HLui6XjhXoQTzfj5c2XnfzFHag/f5E= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com Message-ID: <84bf5d8f-4c57-4557-8f96-bfcfdbd893c7@tuxedocomputers.com> Date: Mon, 23 Jun 2025 19:45:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] drm/i915/display: Add quirk to force backlight type on some TUXEDO devices To: jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com, tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250411171756.142777-1-wse@tuxedocomputers.com> <20250411171756.142777-2-wse@tuxedocomputers.com> Content-Language: en-US From: Werner Sembach In-Reply-To: <20250411171756.142777-2-wse@tuxedocomputers.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit gentle bump Am 11.04.25 um 17:55 schrieb Werner Sembach: > The display backlight on TUXEDO DX1708 and InsanityBook 15 v1 with panels > AUO 12701 and AUO 12701 must be forced to INTEL_DP_AUX_BACKLIGHT_ON to be > able to control the brightness. > > This could already be archived via a module parameter, but this patch adds > a quirk to apply this by default on the mentioned device + panel > combinations. > > Signed-off-by: Werner Sembach > Cc: stable@vger.kernel.org > --- > .../drm/i915/display/intel_dp_aux_backlight.c | 14 ++++++- > drivers/gpu/drm/i915/display/intel_quirks.c | 42 +++++++++++++++++++ > drivers/gpu/drm/i915/display/intel_quirks.h | 1 + > 3 files changed, 56 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index c846ef4acf5b2..0cac04c98a3e3 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -34,12 +34,14 @@ > * for some reason. > */ > > +#include > #include "i915_utils.h" > #include "intel_backlight.h" > #include "intel_display_core.h" > #include "intel_display_types.h" > #include "intel_dp.h" > #include "intel_dp_aux_backlight.h" > +#include "intel_quirks.h" > > /* > * DP AUX registers for Intel's proprietary HDR backlight interface. We define > @@ -607,11 +609,21 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *connector) > struct drm_device *dev = connector->base.dev; > struct intel_panel *panel = &connector->panel; > bool try_intel_interface = false, try_vesa_interface = false; > + int enable_dpcd_backlight; > + u32 pnl_id; > > /* Check the VBT and user's module parameters to figure out which > * interfaces to probe > */ > - switch (display->params.enable_dpcd_backlight) { > + enable_dpcd_backlight = display->params.enable_dpcd_backlight; > + if (enable_dpcd_backlight == INTEL_DP_AUX_BACKLIGHT_AUTO && > + intel_has_quirk(display, QUIRK_AUO_12701_21229_ENABLE_DPCD_BACKLIGHT)) { > + pnl_id = drm_edid_get_panel_id(panel->fixed_edid); > + if (pnl_id == drm_edid_encode_panel_id('A', 'U', 'O', 0x319d) || > + pnl_id == drm_edid_encode_panel_id('A', 'U', 'O', 0x52ed)) > + enable_dpcd_backlight = INTEL_DP_AUX_BACKLIGHT_ON; > + } > + switch (enable_dpcd_backlight) { > case INTEL_DP_AUX_BACKLIGHT_OFF: > return -ENODEV; > case INTEL_DP_AUX_BACKLIGHT_AUTO: > diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c > index 8b30e9fd936e7..6f724e5712664 100644 > --- a/drivers/gpu/drm/i915/display/intel_quirks.c > +++ b/drivers/gpu/drm/i915/display/intel_quirks.c > @@ -78,6 +78,12 @@ static void quirk_fw_sync_len(struct intel_dp *intel_dp) > drm_info(display->drm, "Applying Fast Wake sync pulse count quirk\n"); > } > > +static void quirk_auo_12701_21229_enable_dpcd_backlight(struct intel_display *display) > +{ > + intel_set_quirk(display, QUIRK_AUO_12701_21229_ENABLE_DPCD_BACKLIGHT); > + drm_info(display->drm, "Applying Display AUO Model 12701 and 21229 Enable DPCD Backlight quirk\n"); > +} > + > struct intel_quirk { > int device; > int subsystem_vendor; > @@ -118,6 +124,12 @@ static int intel_dmi_no_pps_backlight(const struct dmi_system_id *id) > return 1; > } > > +static int intel_dmi_auo_12701_21229_enable_dpcd_backlight(const struct dmi_system_id *id) > +{ > + DRM_INFO("Display AUO model 12701 and 21229 DPCD backlight control on %s\n", id->ident); > + return 1; > +} > + > static const struct intel_dmi_quirk intel_dmi_quirks[] = { > { > .dmi_id_list = &(const struct dmi_system_id[]) { > @@ -164,6 +176,36 @@ static const struct intel_dmi_quirk intel_dmi_quirks[] = { > }, > .hook = quirk_no_pps_backlight_power_hook, > }, > + { > + .dmi_id_list = &(const struct dmi_system_id[]) { > + { > + .callback = intel_dmi_auo_12701_21229_enable_dpcd_backlight, > + .ident = "TUXEDO DX1708", > + .matches = {DMI_MATCH(DMI_BOARD_NAME, "N8xEJEK"), > + }, > + }, > + { > + .callback = intel_dmi_auo_12701_21229_enable_dpcd_backlight, > + .ident = "TUXEDO InsanityBook 15 v1", > + .matches = {DMI_MATCH(DMI_BOARD_NAME, "P95_HP"), > + }, > + }, > + { > + .callback = intel_dmi_auo_12701_21229_enable_dpcd_backlight, > + .ident = "TUXEDO InsanityBook 15 v1", > + .matches = {DMI_MATCH(DMI_BOARD_NAME, "P95_HR"), > + }, > + }, > + { > + .callback = intel_dmi_auo_12701_21229_enable_dpcd_backlight, > + .ident = "TUXEDO InsanityBook 15 v1", > + .matches = {DMI_MATCH(DMI_BOARD_NAME, "P95_HP,HR,HQ"), > + }, > + }, > + { } > + }, > + .hook = quirk_auo_12701_21229_enable_dpcd_backlight, > + }, > }; > > static struct intel_quirk intel_quirks[] = { > diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h b/drivers/gpu/drm/i915/display/intel_quirks.h > index cafdebda75354..38bdbd65d7efb 100644 > --- a/drivers/gpu/drm/i915/display/intel_quirks.h > +++ b/drivers/gpu/drm/i915/display/intel_quirks.h > @@ -20,6 +20,7 @@ enum intel_quirk_id { > QUIRK_LVDS_SSC_DISABLE, > QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK, > QUIRK_FW_SYNC_LEN, > + QUIRK_AUO_12701_21229_ENABLE_DPCD_BACKLIGHT, > }; > > void intel_init_quirks(struct intel_display *display);