From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012037.outbound.protection.outlook.com [52.101.53.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDF4F448CE3 for ; Fri, 24 Jul 2026 18:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.37 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784917363; cv=fail; b=Y4KfiuME9ZoznyRg9rl9F9aSmj9GYtiKxzj7XzCU45TpEVvnt9fDxS0XeHz9tspWwl+AN6aVa62hyXCcDk5EYh5wf25Hz+/Vjbt1reEDxrniYThDib0mbwZKhicPWlL2puuDDdxQbguTlTRPyTakB7tDw+0DPwDOGnuM5nbG1bQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784917363; c=relaxed/simple; bh=v/xuUX2886OncSjEwp1ssbG9hn01rsum7nKa2pHxuFo=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=RqF2hdNYSomjJ07V39x0bjamvgm+mnf1LQumO2LT2vqVghtqBlFTQORzrHHfYJJ8S56h1NGbLyy6Gpv/z7oYNLn6vAQKRUcqZpOkY6nUpZs9SqN9sS4xnCbBp9Y8jgtytnD6ag6NTMx0qlBkgg+qGYSwhEH6qH454YhJIHBgvuU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=nuNwVlxE; arc=fail smtp.client-ip=52.101.53.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="nuNwVlxE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dhMy/7WpyCqmTmCiF/PgIimN7o64zgtIZwHUqhSQx2bBEgU9Ly9SGIqaJMvoBVNbirwNXPxL66GnVKswl5AqriUQvZYyxxii2x9AepX+kMPpb4Zgdg0jD8n/x7J2hqKxXy67IVSVZ8pJtwW1C6360QSWk57fgTuIcDYCrajtm7b3ifne4hdb2SEhsk6xe//zyUJCkwKk4O7hbg20lFt4hxLAX/6EWY1EExpCHF3ZGFpMmrWQgJo1J58bxB6uswFFkdjdqGigppijvkH8uD6JFFIW6PU1OZFk696C0S8AXykHHHRpIDWRUirLmQBAxMnzCcEsDh9nRoLYHhCu8YIHlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PR9QOm4vvNEshvkTqfMB1YBxLhhxHWXaye1/khZz0ws=; b=mbGw00FGyIRRiL3kmtSFykOxf8A0KgryycWcQpSmnaNtmN9JQuay+Lvux7nKNIVNkS6oramQIdYt15Yf+mq/A2os2WtaHVnlW2IFWVzzm7BHdM+mhCEG1bAQp2jNG/yLDIa0cfc3noOfWfBmZz+S0Dy/oa1LDYRzbavPQ4XMcmjpemc4geoBJ99eElzm+AZVeOITRKwYTRAsngFP/PflnYL6jsbLbFHk8D3KgJafCqev1FZX/mvpKMcektDDpQKhDJAbfJVimMFthPKFlhWt/3L4551JwFYOenKcQrHm7XnX35V/S/P1a8Z3zfem1UIqN+Zi63KLLoPXYa5UgT4FxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PR9QOm4vvNEshvkTqfMB1YBxLhhxHWXaye1/khZz0ws=; b=nuNwVlxExBzALDpgxscZ1wYT31i+qSbvLLRN6gTBDIcw2XcR2ATSdj+t/je9t5/TvmyUAJEsYFqpCNV7msMeVpZFOejnCZSjJoMuqYw7tnr/Zlf1FBIxCc36B9cjO0bGVqxNJNIzhhNu/hU9PV+NHqfCBB9qYRAt/kvHYTKv1No= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN7PR12MB8131.namprd12.prod.outlook.com (2603:10b6:806:32d::12) by EAYPR12MB999157.namprd12.prod.outlook.com (2603:10b6:303:2bf::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Fri, 24 Jul 2026 18:22:32 +0000 Received: from SN7PR12MB8131.namprd12.prod.outlook.com ([fe80::c2dd:62c5:67fe:aa46]) by SN7PR12MB8131.namprd12.prod.outlook.com ([fe80::c2dd:62c5:67fe:aa46%4]) with mapi id 15.21.0245.010; Fri, 24 Jul 2026 18:22:31 +0000 Message-ID: <84c3aee9-d03f-4880-8974-99b2a8ee3841@amd.com> Date: Fri, 24 Jul 2026 13:22:29 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] x86/boot: Remove hardcoded boot_param constants To: Brian Gerst , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Borislav Petkov , Ard Biesheuvel , Juergen Gross References: <20260724030256.232690-1-brgerst@gmail.com> <20260724030256.232690-4-brgerst@gmail.com> Content-Language: en-US From: Tom Lendacky Autocrypt: addr=thomas.lendacky@amd.com; keydata= xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmkbaKgFCRZQah8ACgkQ 3v+a5E8wTVPFyg//UYANiuHfxxJET8D6p/vIV0xYcf1SXCG78M+5amqcE/4cCIJWyAT3A1nP zwyQIaIjUlGsXQtNgC1uVteCnMNJCjVQm0nLlJ9IVtXxzRg0QKjuSdZxuL5jrIon4xW9hTJR 94i2v3Fx5UWyP2TB6qZOcB0jgh0l01GHF9/DVJbmQlpvQB4Z1uNv09Q7En6EXi28TSv0Ffd1 p8vKqxwz7CMeAeZpn5i7s1QE/mQtdkyAmhuGD12tNbWzFamrDD1Kq3Em4TIFko0+k5+oQAAf JFaZc1c0D4GtXwvv4y+ssI0eZuOBXapUHeNNVf3JGuF6ZPLNPAe5gMQrmsJinEArVYRQCuDA BZakbKw9YJpGhnSVeCl2zSHcVgXuDs4J2ONxdsGynYv5cjPb4XTYPaE1CZH7Vy1tqma8eErG rcCyP1seloaC1UQcp8UDAyEaBjh3EqvTvgl+SppHz3im0gPJgR9km95BA8iGx9zqDuceATBc +A007+XxdFIsifMGlus0DKPmNAJaLkEEUMedBBxH3bwQ+z8tmWHisCZQJpUeGkwttD1LK/xn KRnu8AQpSJBB2oKAX1VtLRn8zLQdGmshxvsLUkKdrNE6NddhhfULqufNBqul0rrHGDdKdTLr cK5o2dsf9WlC4dHU2PiXP7RCjs1E5Ke0ycShDbDY5Zeep/yhNWLOwU0EVo1liQEQAL7ybY01 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+ LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe /5rkTzBNUwUCaRto5wUJFlBqXgAKCRDe/5rkTzBNUw4/EAClG106SeHXiJ+ka6aeHysDNVgZ 8pUbB2f8dWI7kzD5AZ5kLENnsi1MzJRYBwtg/vVVorZh6tavUwcIvsao+TnV57gXAWr6sKIc xyipxRVEXmHts22I6vL1DirLAoOLAwWilkM+JzbVE3MMvC+cCVnMzzchrMYDTqn1mjCCwiIe u5oop+K/RgeHYPsraumyA9/kj8iazrLM+lORukCNM7+wlRClcY8TGX+VllANym9B6FMxsJ5z Q7JeeXIgyGlcBRME+m3g40HfIl+zM674gjv2Lk+KjS759KlX27mQfgnAPX4tnjLcmpSQJ77I Qg+Azi/Qloiw7L/WsmxEO5ureFgGIYDQQUeM1Qnk76K5Z3Nm8MLHtjw3Q7kXHrbYn7tfWh4B 7w5Lwh6NoF88AGpUrosARVvIAd93oo0B9p40Or4c5Jao1qqsmmCCD0dl7WTJCboYTa2OWd99 oxS7ujw2t1WMPD0cmriyeaFZnT5cjGbhkA+uQGuT0dMQJdLqW3HRwWxyiGU/jZUFjHGFmUrj qFAgP+x+ODm6/SYn0LE0VLbYuEGfyx5XcdNnSvww1NLUxSvuShcJMII0bSgP3+KJtFqrUx9z l+/NCGvn/wMy6NpYUpRSOmsqVv0N71LbtXnHRrJ42LzWiRW2I5IWsb1TfdMAyVToHPNaEb0i WiyqywZI5g== In-Reply-To: <20260724030256.232690-4-brgerst@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR04CA0040.namprd04.prod.outlook.com (2603:10b6:610:77::15) To SN7PR12MB8131.namprd12.prod.outlook.com (2603:10b6:806:32d::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR12MB8131:EE_|EAYPR12MB999157:EE_ X-MS-Office365-Filtering-Correlation-Id: 092583b6-87df-42f8-ce49-08dee9b086be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|22082099003|18002099003|4143699003|11063799006|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: wv//JKOPcAPaNIWFn8LOCLfGgGDNzbpStLa9oVECGP7r4f+fXs/v4sdJ6ia5EwLQNWc1RgTTQIW+MEInZVBGqAuX0V6v2Goyv2aTahxcoivLTNeI0fUzJ/2YeCb35IuAYyC4oR3n6B1C1mWDBsbb/ZMFHUUhxV4qTpS2xHi8t/zC8A6yqiEWkSjJBPF/m62ffwoxJRVwX2QENPOZa1jbcOCRS6cw6uPeIdkis43e38M+zyf6PrR5tCxRvuTx9KKrvRGwqAXoOQma9bMNb4nKhA7LKbr1IVRIxjLpjsCfJtqaG6tOk/aUwbBSsg/HWaQLge7OW7aI1WxReIlVqsTBnK2GTAcCo4NUoyudcFcaJlyvyIpUpjNBvzYs/1GgJTs3TJ9s+UjK/hvLCwj/pbyVMVWxCXBINAT04vInEKOL2A7vglKXnGDGRLYHp954CobL9rCBL77xT2W3RrE+qoKjcD52z2YtI9AWXSc3prziJir7VtYptp3Ak6T+YjlQOOs/+Jk2Kwbs7YN+2J/AM76wFYOq9DBkDQ/JRGCPd6sX9ql5Gg4OJBDm83bHTV29lB6kvZ9qDsguzaOU/dezqepmxt2XPHGy+/C54Porz8QaEQcTf38/sQsyJKtno3x551mdjpmd6wT4J0l7h9S+UTSB2UzYR5VG5gz5vr3N166tEzE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR12MB8131.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(22082099003)(18002099003)(4143699003)(11063799006)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2RBRndjcDN2cVZkU05KelBjM2c5a3FjN2dEVnpVRXdOMjVIZCt3eElhVCtj?= =?utf-8?B?clh6R0NOUjVheWVscHZzUU5pdGJHNVFGdStGVlRzb1IyOEYxSE8zR2lTTWsw?= =?utf-8?B?cmxzM1lIWGF0OWpuM2RoaCs0dmVld2krcWU3dHVXSVA5VE00RTJIYWtCNEZq?= =?utf-8?B?YTdQcmxjS200WnNkY0FwY0ZLYkpxUFpyVWkrM3kvNnNRVk9GODNIRjVoR1B6?= =?utf-8?B?bXFRcm5FR2RYYjVyaDRiejJhcW5GR0VwMHF6aWNva3Q3bXBDbzd4ZU1pQXkr?= =?utf-8?B?ZGhOUEY3dnJKbTd3Uk5rc1gzMVNuRmVNbFZ3L01zaG03VW1FcU0rRHNiKzdh?= =?utf-8?B?a3ZEQVp0eG5xVHFTeFgwOVMzYnRKNkhsWWxpeS9IWmRPN2N4dkZ6VXJsclNK?= =?utf-8?B?MlVLdm56cm9oeWZRaVhFRjFjMTVpUnFUZHFyN1VsTmpwNE56WDdINjlkRSs0?= =?utf-8?B?eGQ4eVdRZ3ZQQ1RlU0FFQ2QvcVY2WXRDYXdNbE4yb3EveTRvbEhWS21TWTNn?= =?utf-8?B?a053TzhuL2hLQUl6ZUVZUTJpcUhHZ2lLWkgzQzhvS1BrWVFQN0pKZzdzb1R1?= =?utf-8?B?VitoMTZPbzhOV3JUU2pLNzFjNXF0LzR1S1lpM3QycUsycmlXMi91d1dFRlZM?= =?utf-8?B?UDZPU2RjL2VLSVNHSE1oT3RjU2NOWHRlSkxXcFZSeFEwRW4xdkRzRURIWE5E?= =?utf-8?B?UW5Ja3BPVFdLZGlIV2swWklzb3NJYXl6WkI5U0pTVlBrTXRsQWNHRy9KS0tJ?= =?utf-8?B?bUlnWVVoQUozYnh1ZEE4WW1KWDVDU2RHblBIY2EvME5wMDlvR2krdDJJbCts?= =?utf-8?B?elNpcG43T2lvRlp5Ukh5UnZoRWhWU2l3UmYzaXhtVkQxTkk0QTFUS01xWkVZ?= =?utf-8?B?VStKbytNV2VYNHB0V2xNb1dUdmtHM242a3dRcVNXQUxvNHJGUXV0MTZraXB0?= =?utf-8?B?dFo3ZTEwTDAzcWZKemhQOUFKTHI4M3IzRlM4ZlNKR2lucDd4ZmZuZlNrVzNu?= =?utf-8?B?VzRlbWRkYngvQzYxVTZjYmpGSHdSMmc4SlpaeTV4UUNHdWhLMjY4dUh4SXpW?= =?utf-8?B?dVRvdjV6ZGkwV1ROR0NkZHVwVlgzVmtjbzFSNVRvMDFmK0ZXdG1LS2dranhu?= =?utf-8?B?YzVDSTM2RGlneEVGaWgzeWcyZ2xrcm9HZkpzL21FdWtGeEVQaU9xSzNYR2gz?= =?utf-8?B?Z0tBdzlDbWE5SjVvS084dDBxbTZ3UG9ITkRPUmdXSFNSN1ZVcEU5R3BYZWpG?= =?utf-8?B?Ni9BNnQzVkRON08ybExtWWJpbFVWaFg4dy80d0cyZUMvUTVkYWVleDZCT0FS?= =?utf-8?B?bHI5aURCZi9iQ1oxSFRuWEVQS2ZTMXBTeHFjbktyM2ZNRzhWT2pJTDh6VTVj?= =?utf-8?B?T2ZBQ1RnbXVITUordFRnOGxFYnZRWUFQRnZIUTAxdUR6NFFtTW1ObVBYSlZJ?= =?utf-8?B?NTdHVTExcEdyN3RmN0Q2eXJPS20ySnhVK05OQUpYZ2hlajE5UkpoYnZ5WHJN?= =?utf-8?B?S0NZWjdzTUQ0ZlJUWmxpRE1rL2pDSS9SaHNVMm5xYWNOUFB3YVhhZjlGUGVL?= =?utf-8?B?VjJJMDZhM3pGTXdqcCtLUS9FRGJtZ0szZWNmUDR5Yk0vcWJwTXNUZnpGakN2?= =?utf-8?B?NmZSYUE2aWIyVUdZbEJibC9qR0RLcjFnY2RFM0pVWkwvcVJ5aE4rT2RCVGF4?= =?utf-8?B?cnV5QmRETlg5VjJTM0ZnRXRucFZleFY4UHkyNm8vZFlSQXdBbHRWK0pMSUwx?= =?utf-8?B?R0tVSjBBR3lRN0RVNEt6aWVmd2NKVUE1VkR4NVRqYlRuc1FyeUhWSFpHdWNj?= =?utf-8?B?UmRYTG1zSHJEdVJ6K01pbEVFNlBpbzZZU3NIb2w2RkY0OVVLUEk0SzdrUWtJ?= =?utf-8?B?MW1aUHRZKzBVTm1kRVVYWVVMdjU4QU1CK3FEbzdNQ3lsdkxvcDlHckRwMk1E?= =?utf-8?B?Q09DZmdZeDBBUzlQejIzREFNazFnOGNnOWNMTWZ0WUJHWDBZTE1wK3RpTlpJ?= =?utf-8?B?RDBCYkJXQW5mVk5TQS9xVXQyL0FwcSs2OFJPNTNaK3pOUitxV3hsWjZVS09Q?= =?utf-8?B?TnU5VFd1NGRqQ1c0d0tyc3hCSGg1dktIZnpjUE5KeXFwWE03RHMxdm4yYnlE?= =?utf-8?B?YTRhemtzdUdHS1htcUcvcXhjRDJocSszMExaOHpMVHowZlBPcW43RUdFbTh4?= =?utf-8?B?OUlZVERVckNsSzh1UE9JSUMyU3YyMUgvbWUzbzZUWGUvc2l0MGlHcDVRaWt5?= =?utf-8?B?ZG1JVEUxNUpQNC94MkVnWTNlcEVmOFQwdno2MmRIUm9sSzF6NWNKNnNCU1ZJ?= =?utf-8?Q?u9gu8+0nBboqH9CS7y?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 092583b6-87df-42f8-ce49-08dee9b086be X-MS-Exchange-CrossTenant-AuthSource: SN7PR12MB8131.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2026 18:22:31.8444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pGfsrHtkgcEajIqhXApuS4t5rA7KzSE0EiEOs5zmCshnDrzKP6okj0ed/jdhRD5QSRDSI4i4AMP37993zMZLvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: EAYPR12MB999157 On 7/23/26 22:02, Brian Gerst wrote: > Use generated constants or sizeof() instead of hardcoded values. > > No functional change. > > Signed-off-by: Brian Gerst > --- > arch/x86/include/asm/setup.h | 3 --- > arch/x86/kernel/asm-offsets.c | 2 ++ > arch/x86/kernel/head_32.S | 4 ++-- > drivers/firmware/efi/libstub/x86-stub.c | 6 +++--- > 4 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/include/asm/setup.h b/arch/x86/include/asm/setup.h > index 5534f4aaf73b..d23f4272d930 100644 > --- a/arch/x86/include/asm/setup.h > +++ b/arch/x86/include/asm/setup.h > @@ -21,11 +21,8 @@ > > #endif /* __i386__ */ > > -#define PARAM_SIZE 4096 /* sizeof(struct boot_params) */ > - > #define OLD_CL_MAGIC 0xA33F > #define OLD_CL_ADDRESS 0x020 /* Relative to real mode data */ > -#define NEW_CL_POINTER 0x228 /* Relative to real mode data */ > > #ifndef __ASSEMBLER__ > #include > diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c > index 081816888f7a..0c49bb50188d 100644 > --- a/arch/x86/kernel/asm-offsets.c > +++ b/arch/x86/kernel/asm-offsets.c > @@ -105,6 +105,8 @@ static void __used common(void) > OFFSET(BP_kernel_alignment, boot_params, hdr.kernel_alignment); > OFFSET(BP_init_size, boot_params, hdr.init_size); > OFFSET(BP_pref_address, boot_params, hdr.pref_address); > + OFFSET(BP_cmd_line_ptr, boot_params, hdr.cmd_line_ptr); > + DEFINE(SIZEOF_boot_params, sizeof(struct boot_params)); > > BLANK(); > DEFINE(PTREGS_SIZE, sizeof(struct pt_regs)); > diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S > index 5171cb746444..1f66ccc36fe8 100644 > --- a/arch/x86/kernel/head_32.S > +++ b/arch/x86/kernel/head_32.S > @@ -96,10 +96,10 @@ SYM_CODE_START(startup_32) > * page tables. > */ > movl $pa(boot_params),%edi > - movl $(PARAM_SIZE/4),%ecx > + movl $(SIZEOF_boot_params/4),%ecx > cld > rep movsl > - movl pa(boot_params) + NEW_CL_POINTER,%esi > + movl pa(boot_params) + BP_cmd_line_ptr,%esi > andl %esi,%esi > jz 1f # No command line > movl $pa(boot_command_line),%edi > diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c > index cef32e2c82d8..c3522d417344 100644 > --- a/drivers/firmware/efi/libstub/x86-stub.c > +++ b/drivers/firmware/efi/libstub/x86-stub.c > @@ -520,11 +520,11 @@ static efi_status_t efi_allocate_bootparams(efi_handle_t handle, > return status; > } > > - status = efi_allocate_pages(PARAM_SIZE, &alloc, ULONG_MAX); > + status = efi_allocate_pages(sizeof(struct boot_params), &alloc, ULONG_MAX); Why not sizeof(*boot_params) here and each place below instead of hardcoding the struct? Thanks, Tom > if (status != EFI_SUCCESS) > return status; > > - boot_params = memset((void *)alloc, 0x0, PARAM_SIZE); > + boot_params = memset((void *)alloc, 0x0, sizeof(struct boot_params)); > hdr = &boot_params->hdr; > > /* Assign the setup_header fields that the kernel actually cares about */ > @@ -537,7 +537,7 @@ static efi_status_t efi_allocate_bootparams(efi_handle_t handle, > /* Convert unicode cmdline to ascii */ > cmdline_ptr = efi_convert_cmdline(image); > if (!cmdline_ptr) { > - efi_free(PARAM_SIZE, alloc); > + efi_free(sizeof(struct boot_params), alloc); > return EFI_OUT_OF_RESOURCES; > } >