From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5A994A07 for ; Sat, 25 Apr 2026 16:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777133843; cv=none; b=ui680mTw4pA5J2EIf5s2cH2YLD6+fEz6VqsPk5k7jnkqfcu2FrYEJYG/eLVoqIuNF/9P+NcKGZqBnwJi/PnSMbE3Sm4eOHuxWkzZb/K5TJg+EIqxrflh+zLGOAKQOvdVRTGcZnne/IO7Yj3wW74T2pTfo7EaOF9MeDEd58VswWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777133843; c=relaxed/simple; bh=P714Idt1/wUElBaW+LenXDSfh/3pF+qhjIPw26muR/0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pLgf9XdYfE1TP+Rl0o4JXI6OyvA0Z8BwhEQ50BLXCMY0fzq2mTH9SqZSW38rgBwaWSKGjJAq7jB5PCMIj5LDzyWhxI2XMmf2egVHQQrCgy45Oh3JPXP/Rcxwy3Mzwq8N9EgTIa4/n2r9VmjzCZaPfdjPQUyUMAgm82nEV6BKZBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=tTAVejJy; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="tTAVejJy" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-40ede943bf0so5883632fac.2 for ; Sat, 25 Apr 2026 09:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777133840; x=1777738640; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f0RshBZIRutdI+obaiuuk2MoPoQSldBM8MBOZQb6H5Y=; b=tTAVejJyI73dOxSLfD4jMXwtJEqTrHe3cKuBQ20AaJXB7vJ/CeMWK5Lmz7eM+bxjVy DeCKohXZTx2MwH1dsl0TAoHHmzezNf3FR7wMjLjF70al2gls0NQHla6Xtyj7RmXEpsh8 vvnBXyY7ocD3GQO9k4734MClMSBjnvPO9sWg/tSaAr2Q32XPKHSuMp3Db4nmBRRzK34A Z+Rb/T1xqXjnK3U3p8bF2nVd48VpkoVwaEtnT+GEkxHVFuq/Tq8oj7C9Hf4InFp1tMzT YeckLu9woZ6jTAAyRvQT2tgiH6L9Xmf7UbkroYjPtJNNUXmMA99U7xQ+teyeVJ+Rzp+r +FMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777133840; x=1777738640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f0RshBZIRutdI+obaiuuk2MoPoQSldBM8MBOZQb6H5Y=; b=Rvc1g0CptWqFITtDkNoIT02wVeRG9RKcxryTHT/kEFloyikXA+6Hb3aNG5yIGfL6tE z2d10S1XX4QJABENqiLVh04O7vD8qobWWsVjzK0nFUG77SgQ82n2OktZkXK+43i5JfKH 5qHkyjWkLbUNkdHjaND2CG1r6fnqFoAQBglIbzbeYwHOnH1ZqI5VqN90qc4LaDVdUy6/ Fnt+ODZmbm/00yZ1f8nWrQeUV9yM9tTUzgwUixPCGnnXOay/Q1KB0XYIdPPjg7UJ/L8b gQ0lya/g5VqOPGUc7ftaEIAiO0tAfdgZ3m0ap4ynOehECoeKTMjr9Fl+jCwhhcyLX75K UU7Q== X-Forwarded-Encrypted: i=1; AFNElJ+XtvBtAPXgeat3mSGoSQlcTK3rbU/CKaaIm+sPwhlrN/J16rQxxy868pXUqzrNaNPH/lzO6D+0rM+h9+U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4287hO2MFUQRtXFgAmXJElVwVB62SAecGUjnTHluzihJbauTp wdnRY4/gwoVtGxgMvY3z7f8szzLWvD+FaVTDIo+z33N9X6ec0oxiMTjETkWPYp3LQT8= X-Gm-Gg: AeBDieud+W5fj+KuE38vB5tyLmcFmlIfZPipnxCpyH7jQTZtMfQ1ITXstmTZBrtZ9Xf CFKbEKZAK70VsvXlrzcqShiy6C7ot0plmGrhyiegudKapOpd8GUSjRZy9NLW70ysqRfnQhDWeUK djySoV30qHnqBPDO6MUEtP8hqg1ipQ2lGJFg43N8pNQb/S0FyE84mdedk721hUYDXEd5Qd2qHQv EkkKZ+VCN0mIs08FVObNN1o7SZ0JBkiafLese8A2RO67lTKlYGsTlu1fgaYsKE7lkncWZg5Eg/R wJhtbbO7eZZd6IDtEEBgCp51TXoOpmHmNGKnWTt712XRHNAoUfF/tfm2pxYnAJ9kUFNO5N394T2 IbYGC2mejMtmp8epxCPyMfzvjJ7oa0vBbtQKOsKSynqIjTH2KmCqkT0cB5aLJcAJVLONht1pCxt lOl0LWZHP0qRBb6Yllb2ZiERdQaUd7GbwxUbGBJKrKlam5W4PBaVMJj+Eedp+k/NcAhChMxLLPU S5OaTgAtV35 X-Received: by 2002:a05:6870:9f86:b0:42f:cfae:b54 with SMTP id 586e51a60fabf-42fcfae0ec5mr9611847fac.32.1777133840390; Sat, 25 Apr 2026 09:17:20 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:4237:7c82:cb4f:1d6a? ([2600:8803:e7e4:500:4237:7c82:cb4f:1d6a]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-42b930bd9f2sm21717224fac.8.2026.04.25.09.17.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Apr 2026 09:17:19 -0700 (PDT) Message-ID: <84cae83c-2d67-4927-aa40-6c416d4f862d@baylibre.com> Date: Sat, 25 Apr 2026 11:17:18 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: adc: meson-saradc: fix calibration buffer leak on error To: Felix Gu , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rosen Penev Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260426-meson_saradc-v1-1-6e96b2982c43@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260426-meson_saradc-v1-1-6e96b2982c43@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/25/26 11:07 AM, Felix Gu wrote: > meson_sar_adc_temp_sensor_init() allocates a buffer with > nvmem_cell_read(), but the old code leaked it if > syscon_regmap_lookup_by_phandle() failed. > > Switch buf to __free(kfree) so all return paths release it. > > Fixes: d6f2eac64403 ("iio: adc: meson: no devm for nvmem_cell_get") > Signed-off-by: Felix Gu > --- > drivers/iio/adc/meson_saradc.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > index 23991a3612bd..9708ddcc4919 100644 > --- a/drivers/iio/adc/meson_saradc.c > +++ b/drivers/iio/adc/meson_saradc.c > @@ -786,7 +786,7 @@ static int meson_sar_adc_clk_init(struct iio_dev *indio_dev, > static int meson_sar_adc_temp_sensor_init(struct iio_dev *indio_dev) > { Nice to see one of these cleanup.h patches that is actually fixing a bug. Should `#include ` though rather that relying on it being included through another header. With that fixed... Reviewed-by: David Lechner