From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1D7B23BCE3 for ; Sat, 3 Jan 2026 15:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767454721; cv=none; b=Nj0GhxR7kk2ZwASXCIr8Hq3JIUtR+w5ItjC0H1TMOgj5hRMRuu99fuEddwXbo4HDbqw4JK11rpLG6tjjFuSZhAigDPrZ8KveyvB93mOceSIwUPzOvS4Xx0CWi61SFZncNdQrqYwUUTVEg7n5ard2Tsy1sWKk/eQnBnSS/AJiFSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767454721; c=relaxed/simple; bh=Cq3k1/fXBP/fel0pjPIO4KMDsjM8pwucAIhaVZQ4XBg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I/NjT5dPKel50HwpT+bzLH8iAx+dak3wX1ihcmlYN2KeMECcMCIaTaS5ikWOcW0U+amQOT2jjjxaVTGJ1XV6k24pdwzV7J/Ng29KVgJboPNmvYxXrlNj9ruDiopqzPZGfPbudkzY3NAFbxuCdD9jq5QGHXfKrlCfH6e6WUgqv+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=me7GF99J; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="me7GF99J" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-64b560e425eso16927157a12.1 for ; Sat, 03 Jan 2026 07:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767454718; x=1768059518; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4hs0EhRoobDLxoEH08l0zC5fr9dWFdN5yFIFiuBMlNQ=; b=me7GF99JAULmF/6ay0IJjFgsGXTTukgbeEgebbP8q/Z4bsdZ4vL3NvJsWK/PCrrn0t TLw6gDPXD6DidR8zBY8BLlNs4IwmmYAdXHNdn9ETipEo9Zs2GPneXyINpnhyovBMsRGh 09qOy8YCggXhCMfKoLG9NV+EIvET66VXDeh91/0iufIhlqQO6luxHzdfsgXQAq+Dw5ey QFF+vSU8P/4sw8zI3XdcLImEXTzZOW569LgcX0VXHJ9DHiNoWAPcl1+N+Mc9SFHnrDWT CUa+rXF/pg+uaSjLO8MxwlZh5BBqpfXHf/Q96drNdzNI6KqVbj0NVEyqmw92luN6tGqD 6m2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767454718; x=1768059518; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4hs0EhRoobDLxoEH08l0zC5fr9dWFdN5yFIFiuBMlNQ=; b=Qffp9o5YNEdsxEThYb/1Nr37/8TGSr6McWvHgwogNrFC83V9xQehGIp4CWksgMqNsh eeftJZCqiLG/p0NcefhJ+gEXxBDd9rr+IrGJy8B2mricP/3OqiEi/CQkoLOKHjF2Fcb1 ni2GsqCeXCVWtI2aAzYDbjkiBbpYgKGT1aYTA3aF/KVfyoYDElQamnqQtp10vROpbz9b nb/jMrXXi38DYLLsTrGy+LHlkIFX4DnqE6C0Ar5fTe5MYcLlv+ifBJaT1Z7mReKUg8TO PsQ3S5FTtN8tweIVJhM/PWlx5LSvbL1GYR9VKE3tuK+kF86RI2Kf9v7iRSskWWwixEyC bVOg== X-Forwarded-Encrypted: i=1; AJvYcCXcIqQn/ljI0roVh1bGXUNFGZUhytLOP0u6Pn+PYigMIqhtLz9ymrwpqXMiEqQ37yWt3Y8VkJCe1/qjOTc=@vger.kernel.org X-Gm-Message-State: AOJu0YybeMq6QUDUUKXkjbxYnKkmj8tn0VKoWch25MxE7meS958dSEru YZd/BUASp7JGtV41LuYJxbMw8cUaMnr6ysYWxq7ooaTOKyNpYdYZ3gWagJo3Gp6L X-Gm-Gg: AY/fxX4n2B5ULr9p7CSV/j4MeBvwTSL2zzHfFQHrTUH9P4GKz6/CT9KO19XA1J6zKBL UFP3dsll0wiDf06PzPi36G6HZ7mEY7MMKCPA7CE6SYEdkFvhWUscL3V/197EqQVXrRBw9Xsmvlg FBQr97kd7UTOKlFv6uhOYNwHL1AyJ3UNyfxQ4NgjTy3LqKUXQFOV4R6gdJ2hfm7hJeRaUzHbCcI bMymRK0DSnVQU7yne3rjvAy9oEJshbU7MdscWGt26ljLmxetwWbYjmmg/8p0pKacfXl6TaU6BDl OgeCzGakyMTLBtrQNd9KUl7szfEBr+grE3JWn1k6P7ava+WRx23/N6nwlDGABGCwm8xQoXEFpeP EljD1dQU5PFur2zGH7Hwviv+3Fsw2pEK4gVovyRgmCvFONLRySdnDi37pKNnGjOb6A4FN+3UUe+ gMGBBctFfYQznsD3cJGfRA4Py2LJtVm0oV2WbOjnwdEPYWILrdVzRMGXpFq83df2I3eLrHJnLRX DJ+Rr92j/veiz1PBO6rZjDuEE5x/E+WpJmSCG5ZH8Bq6A== X-Google-Smtp-Source: AGHT+IHX3y0FmDy1TKEc3tmnS+B1SrOgQ3j6ATmu3whCYNr8VYjGOlmbeI9SRs33adJYXlB3knoEvw== X-Received: by 2002:a17:907:7638:b0:b80:6ddc:7dcd with SMTP id a640c23a62f3a-b806ddc842amr3076213466b.31.1767454717880; Sat, 03 Jan 2026 07:38:37 -0800 (PST) Received: from ?IPV6:2003:df:bf2d:e300:a75f:8613:8605:1c8b? (p200300dfbf2de300a75f861386051c8b.dip0.t-ipconnect.de. [2003:df:bf2d:e300:a75f:8613:8605:1c8b]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ad83dasm5150694466b.25.2026.01.03.07.38.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Jan 2026 07:38:37 -0800 (PST) Message-ID: <84cc5699-f9ab-42b3-a1ea-15bf9bd80d19@gmail.com> Date: Sat, 3 Jan 2026 16:38:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment To: Danilo Krummrich , Marko Turk Cc: dirk.behme@de.bosch.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20260103143119.96095-1-mt@markoturk.info> <20260103143119.96095-2-mt@markoturk.info> Content-Language: en-US From: Dirk Behme In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03.01.26 16:24, Danilo Krummrich wrote: > On Sat Jan 3, 2026 at 3:31 PM CET, Marko Turk wrote: >> inststance -> instance > > It's trivial in this case, but we usually write at least something along the > lines of "Fix a typo in the doc-comment of the Bar structure: 'inststance -> > instance'." > > Please also add a corresponding Fixes: tag. While looking at this some days ago as well I came up with Fixes: 3c2e31d717ac ("rust: pci: move I/O infrastructure to separate file") But that just moves the pre-existing typo from rust/kernel/pci.rs to rust/kernel/pci/io.rs. So I'm unsure if that move-only commit should be mentioned in Fixes:? Or if we should go back more to search for the commit introducing this typo? Best regards Dirk Btw: While we are at this file, do we want to add an 'is' in line 57 as well? // `pdev` valid by the invariants of `Device`. => ... is valid ... >> Signed-off-by: Marko Turk >> --- >> rust/kernel/pci/io.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/rust/kernel/pci/io.rs b/rust/kernel/pci/io.rs >> index 0d55c3139b6f..fba746c4dc5d 100644 >> --- a/rust/kernel/pci/io.rs >> +++ b/rust/kernel/pci/io.rs >> @@ -20,7 +20,7 @@ >> /// >> /// # Invariants >> /// >> -/// `Bar` always holds an `IoRaw` inststance that holds a valid pointer to the start of the I/O >> +/// `Bar` always holds an `IoRaw` instance that holds a valid pointer to the start of the I/O >> /// memory mapped PCI BAR and its size. >> pub struct Bar { >> pdev: ARef, >> -- >> 2.51.0 > >