From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D44A6C10F11 for ; Mon, 22 Apr 2019 11:44:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D4DA20693 for ; Mon, 22 Apr 2019 11:44:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vRphcY2t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727262AbfDVLoO (ORCPT ); Mon, 22 Apr 2019 07:44:14 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:44027 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfDVLoN (ORCPT ); Mon, 22 Apr 2019 07:44:13 -0400 Received: by mail-lj1-f196.google.com with SMTP id f18so10034211lja.10 for ; Mon, 22 Apr 2019 04:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MEffizkr1w0evm81+mxrQIEzWs/V2grZ0BdI3kw/UtE=; b=vRphcY2tDQgIFmqN+8UTuvs+qlwZ+xC/bDCfkvhD9WLZbKv7/DXK+9rlNAhOxl9blL N2QHJ4pt333Uz6KMmzhyw7Apv+jBhAxQdWpRUFA1k/i2f/QRTsngPTek5XdUnxjc9f4G t/zUMELEDKJvHhtMp5Xf2c50J7VADzLanirQuy+FDndILHavjfwaHk7Q2xwL9berdecM WUVbKdIIU/WKUJ9WYnb9bUE/zKM27fjoPxnL+VK0MWvTAfKETwhZYmgIU2vNKMUrbIaF pJVJLLRJqcs3jkqp9OKfsu8d6AvIN7JEnZLHkM4m1+eh3c3ozF/DJkrHvgatFi3T33d1 vxWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MEffizkr1w0evm81+mxrQIEzWs/V2grZ0BdI3kw/UtE=; b=kM0A0n4/ozjAMjWUXIq67D0zf+unHG4JoHOmr5aiOE2FCysdGpk8ECB791zkzQNQgr t3Td2PDZpjr/Zij2K9kpXxSg+YS1WK3oT/OTSy4laTkcPnsL6RuWA+v1A4nTgcwiThEQ 19GsabA9t+3vtskelBG0eFYulI1+W3+wJc3x/rdmCt4u1uoAmQZfqCAEcH9AaYI1dPj1 RFg6cO0GY49kzP0UeWJmiI72tqd81yKDbYyAFoT2R2g3rdKnkiqGzyfSjKZ7MWWBWO+a pPLsj0nzfSaqbXpWfQP3dgdKb3iIrRIxFEkK/LJmT/PDEVfn5Y2z5CuWRac8F82Iylo6 k1vA== X-Gm-Message-State: APjAAAUGSSE7Wv07wudeAORziz5Ne07+lGErFuET/2dyxbfwxH743LSo HKriNSa8gWVqTu6uYYGLy8SPXXtx X-Google-Smtp-Source: APXvYqxe/DhrrHGJDjY3g6cjvKH24Hxpl6lkNVsY+dIUBaG6/eziQP2JEfLPzwvSizhCGkFSWY9McA== X-Received: by 2002:a2e:3a0f:: with SMTP id h15mr9799850lja.194.1555933451429; Mon, 22 Apr 2019 04:44:11 -0700 (PDT) Received: from [192.168.2.145] (ppp94-29-35-107.pppoe.spdop.ru. [94.29.35.107]) by smtp.googlemail.com with ESMTPSA id r136sm2953254lff.65.2019.04.22.04.44.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2019 04:44:10 -0700 (PDT) Subject: Re: [PATCH RESEND] regulator: max77620: Fix regulator info setting for max20024 From: Dmitry Osipenko To: Axel Lin , Mark Brown Cc: Mark Zhang , Venkat Reddy Talla , Laxman Dewangan , Liam Girdwood , linux-kernel@vger.kernel.org References: <20190422053531.23123-1-axel.lin@ingics.com> <74253ed2-6b5a-0e59-25f0-05d7d8ce5431@gmail.com> Message-ID: <84db2f6a-f1b5-bd15-83ce-24ab321dff64@gmail.com> Date: Mon, 22 Apr 2019 14:44:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <74253ed2-6b5a-0e59-25f0-05d7d8ce5431@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 22.04.2019 14:39, Dmitry Osipenko пишет: > 22.04.2019 8:35, Axel Lin пишет: >> Current code always set pmic->rinfo[id] = &max77620_regs_info[id]; >> It should set to either max77620_regs_info or max20024_regs_info >> depends on the chip_id. >> >> Signed-off-by: Axel Lin >> --- >> This was sent on https://lkml.org/lkml/2019/2/23/482 >> >> drivers/regulator/max77620-regulator.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c >> index 1607ac673e44..0ad91a7f9cb9 100644 >> --- a/drivers/regulator/max77620-regulator.c >> +++ b/drivers/regulator/max77620-regulator.c >> @@ -803,7 +803,7 @@ static int max77620_regulator_probe(struct platform_device *pdev) >> continue; >> >> rdesc = &rinfo[id].desc; >> - pmic->rinfo[id] = &max77620_regs_info[id]; >> + pmic->rinfo[id] = &rinfo[id]; >> pmic->enable_power_mode[id] = MAX77620_POWER_MODE_NORMAL; >> pmic->reg_pdata[id].active_fps_src = -1; >> pmic->reg_pdata[id].active_fps_pd_slot = -1; >> > > That is a quite difficult bug to spot because the regulator parameters are mostly identical and the part that differs is usually unused in practice, good catch! Thank you very much! > > Reviewed-by: Dmitry Osipenko > Tested-by: Dmitry Osipenko > Axel, please also add a stable tag to the commit message to get the fix backported. Cc: stable