From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: konrad.dybcio@somainline.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: msm8996: align TLMM pin configuration with DT schema
Date: Thu, 13 Oct 2022 08:28:37 -0400 [thread overview]
Message-ID: <84dee7a6-f8f7-75ee-b0a2-5c1516e7c0fd@linaro.org> (raw)
In-Reply-To: <99ae66c725776f110272cdc2359241f7@somainline.org>
On 12/10/2022 14:32, konrad.dybcio@somainline.org wrote:
> On 2022-10-12 17:15, Krzysztof Kozlowski wrote:
>> DT schema expects TLMM pin configuration nodes to be named with
>> '-state' suffix and their optional children with '-pins' suffix.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 96 ++++------
>> arch/arm64/boot/dts/qcom/apq8096-ifc6640.dts | 68 ++------
>> .../dts/qcom/msm8996-sony-xperia-tone.dtsi | 26 +--
>> .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 10 +-
>> .../boot/dts/qcom/msm8996-xiaomi-gemini.dts | 8 +-
>> .../boot/dts/qcom/msm8996-xiaomi-natrium.dts | 4 +-
>> .../boot/dts/qcom/msm8996-xiaomi-scorpio.dts | 8 +-
>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 164 +++++++++---------
>> 8 files changed, 153 insertions(+), 231 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> index 5cdc7ac1a9c0..a3d1ff1aba8f 100644
>> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> @@ -422,82 +422,46 @@ &tlmm {
>> "NC", /* GPIO_148 */
>> "NC"; /* GPIO_149 */
>>
>> - sdc2_cd_on: sdc2_cd_on {
>> - mux {
>> - pins = "gpio38";
>> - function = "gpio";
>> - };
>> -
>> - config {
>> - pins = "gpio38";
>> - bias-pull-up; /* pull up */
>> - drive-strength = <16>; /* 16 MA */
>> - };
>> + sdc2_cd_on: sdc2-cd-on-state {
>> + pins = "gpio38";
>> + function = "gpio";
>> + bias-pull-up;
>> + drive-strength = <16>;
> How about drive-strength before bias- properties? I think most DTs have
> it like that.
Sure, I can move it.
>
> Other than that,
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-13 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:15 [PATCH 1/3] arm64: dts: qcom: msm8996-sony-xperia-tone: drop incorrect wlan pin input Krzysztof Kozlowski
2022-10-12 15:15 ` [PATCH 2/3] arm64: dts: qcom: msm8996: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-10-12 18:32 ` konrad.dybcio
2022-10-13 12:28 ` Krzysztof Kozlowski [this message]
2022-10-12 15:15 ` [PATCH 3/3] dt-bindings: pinctrl: qcom,msm8996: convert to dtschema Krzysztof Kozlowski
2022-10-12 16:27 ` Rob Herring
2022-10-12 18:33 ` [PATCH 1/3] arm64: dts: qcom: msm8996-sony-xperia-tone: drop incorrect wlan pin input konrad.dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84dee7a6-f8f7-75ee-b0a2-5c1516e7c0fd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®