From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA9393DA7E2 for ; Thu, 9 Apr 2026 15:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775746915; cv=none; b=cEKNAD5t5AN18CyXZ0i4NoCIgpyXfq0upI7CuiBJfqbfsy4TniNslZMmJIcGuzpn9YPCZBJEPcs+PNiULNCoCxVotUypeRYwtspB9YpQrV0HYCOa/v+nobYftvntiyAqUZjLkmcflJDy1Yhj/icG6ylAygGaXQg3wdM+wvqScu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775746915; c=relaxed/simple; bh=49JPbInX6e9XfodU0RMLb4/oPnMVnWJJAi/4wJnR0qM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eXdt0bR5XV9DNvi1vnUWUeamPlzXVlAB0mZ9Pktr2epNF5SV0f8jcrXiGFPCbL0/4fW1XeT71Nz+XeZgqzAGgQSenvJvGRbEsDFpC6HHU+tUcggdCGVE1WEdWkH3153yllXv4cY1I5Ta1J39l11rq052Rt7bmBh6Fysqy/qMwTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=OAkyLdYm; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="OAkyLdYm" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-7dbd08144deso798509a34.0 for ; Thu, 09 Apr 2026 08:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775746913; x=1776351713; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=akLM0X3PLFuI91BU41cd1SoLC/8+P7T/tJbdPoa5nQk=; b=OAkyLdYm4ZVcvuaSkTpcYc2SD6pUz8+GtrjyUHqIUaOnTNL2gkI0DMutC/V+KMt3nd 1CDIMNdBxGD8mnBsjDQDkHg2PwSXkLv8EZgvURA3CFLgOI2IMFZwo/rVYq3KPq2OdNyb yx7iomccrNfm9+qMlHBgOnFJuzaw5aRW2htWnNQlKG7m7Ws4CLClMH/XyoC1aLaApEWG 9c8vvl4G5yvg71t9gesL0iPskxUlJaqbP55hiVkpM+sW6CRZxA6br7b9UJksWpJECsP+ 8hxMwNDQs0xDRo7GdeB+u/QX8vKBIvZrAYOyipw42bnaVmLsy8GyjPFkQIEM/UchZa8x knrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775746913; x=1776351713; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=akLM0X3PLFuI91BU41cd1SoLC/8+P7T/tJbdPoa5nQk=; b=Eq0WhpLIN+V75SluQ1ilQmuD/aroJek+O1nDRigT68JbfMc+irPFHU+FdpnDPXS007 w7IxfFVG7OUGh+l6Cgcb/IRR48NtoJJo9vKAWgtArdZUVi8L0xbirdSt9vVBx8RAnbZO +mnPkMaj0WA5oSdOUrhb5OWEeuuTniftpBpXR+fZHqu1S2q7LpLV4v1D2gyP7sp3sIKu A0cl95oVDNvBYNdDnmrmVE1YMFqvtR7DvL38qhbyiup2UAy9W5o4DfOMupbePbEFUtc0 ZOb8rYQHWYYAIKOGRZ5X6GXjTMJHBe3SAUCLVU+BoINPmtEdZzGs2bXCz9GlbHyt3J+/ feKw== X-Gm-Message-State: AOJu0Yz/RYAtDjx6tp1PATODzal6aNm1ae50z6tIk09nDwOWBwTLEyyk sc89NHd1IT9SYdKSBJ+rrCIGpNqo/w6ZytdoidSYZiCFAAG/CtjG5HCr8y1YfkD9SGk= X-Gm-Gg: AeBDietYAajbHVrIOX7HyVrZ3lpol5+SK6JM1uW5PqeXDOSmlFZW79Y9/IWMLu4Hs5C EU0ysq7CWf8bKoMNyqjRjsFm3xZZk3T+UQJJl9uMbpXdTXWVAwMfH4YPcGTeYGEsacv3S/GTCSd EmaneOuylYVA79PKXVZR/Oqw56bzklJ8bMaYJEWhZH1FshxspMKOx9kAXTfEfoqQDslgVrmdhMm b61Ww0eurdGn64EfvU6V6hHhV8ZTV4TfIJ1u/mExmLk00ceBRH0/BS0nRLQhLnaNihPQavPwZ/j Zhm0CDIh3got6ODYb68/pmdK/4QHGcq6/eLw69gC4RCSSf7Zgfn7h/DdKwrJUUIcg/XBOgUkzU1 S9sF9pvlEMVy08K5XSVRDXeRP09Vo/IvxwCyBYR/9rjQdWogpLNgjst1Pp/2ZKZw+fhwNlDjMcL 74pHbkjTHFcpC5YDAMTU+E/KNwzPms4j9ZNO68PjyX+P/kYWIe8gZUefiuuNmZeyTWljxPE4lc1 x2KzqV6on7z X-Received: by 2002:a05:6820:3081:b0:686:d107:2865 with SMTP id 006d021491bc7-686d1073828mr8160295eaf.59.1775746904792; Thu, 09 Apr 2026 08:01:44 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:a548:cf0c:d054:fd01? ([2600:8803:e7e4:500:a548:cf0c:d054:fd01]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-682ba3cbe72sm10674670eaf.11.2026.04.09.08.01.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 08:01:44 -0700 (PDT) Message-ID: <84e57bae-358b-43f6-9455-ee6c84b576cb@baylibre.com> Date: Thu, 9 Apr 2026 10:01:43 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] iio: pressure: bmp280: fix stack leak in bmp580 trigger handler To: Greg Kroah-Hartman , linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , stable References: <2026040947-overhang-fax-02d0@gregkh> Content-Language: en-US From: David Lechner In-Reply-To: <2026040947-overhang-fax-02d0@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/9/26 8:40 AM, Greg Kroah-Hartman wrote: > bmp580_trigger_handler() declares its scan buffer on the stack without > an initializer and then memcpy()s 3 bytes of 24-bit sensor data into > each 4-byte __le32 field. The high byte of comp_temp and comp_press is > left uninitialized, and the channel storagebits is 32, so two bytes of > stack are pushed to userspace per scan. > > This is a regression from when the buffer lived in the private data, the > move to a stack-local struct dropped the implicit zeroing. > bme280_trigger_handler() was fixed up to handle this bug, but this > driver was not fixed because there was no padding hole, but rather a > short-fill issue. > > Fix this all by just zero-initializing the structure on the stack. > Reviewed-by: David Lechner