From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C985C48BCF for ; Sat, 12 Jun 2021 07:21:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E52461001 for ; Sat, 12 Jun 2021 07:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbhFLHXw (ORCPT ); Sat, 12 Jun 2021 03:23:52 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:33984 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbhFLHXv (ORCPT ); Sat, 12 Jun 2021 03:23:51 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15C7LlC1067900; Sat, 12 Jun 2021 02:21:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623482507; bh=YzSaoRQU35DpLlcWUVC889LLvvrRwlO1hWjuvl74KpI=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=e8BAXI0fJ7Jm+izmuW8MDcjtWCvDZaLnUwNuv8bInZPv7/D6MFNh6KobPkF2otcEA 89z8Tg3tLTBBTD6MtQvkVGIE8T0HkpvSK3exJ9LMp8N0Glrz54w+yzpl7rWF6TtRfe pdtyCxN4+jJOF4Bq6knLJRIKP40A6Q1O/wV9uoZ8= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15C7LlRN035598 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 12 Jun 2021 02:21:47 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 12 Jun 2021 02:21:46 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Sat, 12 Jun 2021 02:21:46 -0500 Received: from [10.250.234.148] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15C7LhVb089548; Sat, 12 Jun 2021 02:21:44 -0500 Subject: Re: [PATCH] arm64: dts: ti: k3-am64-main: Add SYSFW reserved ranges in OCRAM To: Nishanth Menon CC: Rob Herring , , , Linux ARM Mailing List , Aswath Govindraju References: <20210609140604.9490-1-vigneshr@ti.com> <20210611191640.lczsliyzasjie6lm@dismantle> From: Vignesh Raghavendra Message-ID: <84e5865f-e107-f0e1-ca8b-b6bd655e92e6@ti.com> Date: Sat, 12 Jun 2021 12:51:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210611191640.lczsliyzasjie6lm@dismantle> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Aswath On 6/12/21 12:46 AM, Nishanth Menon wrote: > On 19:36-20210609, Vignesh Raghavendra wrote: >> Last 256K of OCRAM (256K@0x701c0000) is reserved for SYSFW usage. Hence >> add an entry in DT so that its not used for generic pool memory >> allocation. > > Are you really sure?? I know that I had set a budget for 16K in sysfw > when I did the memory split up for sysfw of which 16k is actually used. > > Not sure where this 256K bucket started off from.. am I missing > something here? > Per: http://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am64x/firewalls.html 24 dmsc 0x44060000 0x4407BFFF dmsc,rwcd // alias for 0x701E0000 24 dmsc 0x701FC000 0x701FFFFF sproxy_private,rwcd 24 dmsc 0x4407C000 0x4407FFFF sproxy_private,rwcd 24 dmsc 0x701C0000 0x701DFFFF everyone,rwcd So it looks like only 128K@0x701E0000 is firewalled off. Will update the patch. This makes me wonder why ATF is being moved to 0x701a0000-0x701c0000 leaving a hole at 0x701C0000-0x701DFFFF? > >> >> Without this certain drivers using SRAM as generic shared memory pool >> may end up being allocated memory from this range and will lead to boot >> time crash when the reserved range is accessed (due to firewall >> violation). >> >> Signed-off-by: Vignesh Raghavendra >> --- >> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >> index f1c42ef05e52..77b88e536534 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >> @@ -16,6 +16,10 @@ oc_sram: sram@70000000 { >> atf-sram@0 { >> reg = <0x0 0x1a000>; >> }; >> + >> + dmsc-sram@1c0000 { >> + reg = <0x1c0000 0x40000>; > >> + }; >> }; >> >> gic500: interrupt-controller@1800000 { >> -- >> 2.31.1 >> >