From: Cai Xinchen <caixinchen1@huawei.com>
To: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>, <cgroups@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
<linux-fsdevel@vger.kernel.org>, <dhowells@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: [BUG?] fsconfig restart_syscall failed
Date: Fri, 22 Sep 2023 10:18:24 +0800 [thread overview]
Message-ID: <84e5fb5f-67c5-6d34-b93b-b307c6c9805c@huawei.com> (raw)
Hello:
I am doing some test for kernel 6.4, util-linux version:2.39.1.
Have you encountered similar problems? If there is a fix, please
let me know.
Thank you very much
--------------------------------------------------
util-linux version 2.39.1 call mount use fsopen->fsconfig->fsmount->close
instead of mount syscall.
And use this shell test:
#!/bin/bash
mkdir -p /tmp/cgroup/cgrouptest
while true
do
mount -t cgroup -o none,name=foo cgroup /tmp/cgroup/cgrouptest
ret=$?
if [ $ret -ne 0 ];then
echo "mount failed , $ret"
fi
umount /tmp/cgroup/cgrouptest
ret=$?
if [ $ret -ne 0 ];then
echo "umount failed, $ret"
fi
done
And as a result, we mount cgroup immediately after umount, it will return
failed.
in fsconfig syscall, we find this stack:
SYSCALL_DEFINE5(fsconfig, ...)
vfs_fsconfig_locked
if (fc->phase != FS_CONTEXT_CREATE_PARAMS)
return -EBUSY;
vfs_get_tree
fc->ops->get_tree // cgroup1_get_tree
if (!ret && !percpu_ref_tryget_live
(&ctx->root->cgrp.self.refcnt))
ret = 1;
...
if (unlikely(ret > 0)) {
msleep(10);
restart_syscall();
}
...
fc->phase = FS_CONTEXT_FAILED;
in mount syscall, no function will check fs->phase, and fc is recreate
in monnt syscall. However, in fdconfig syscall, fc->phase is not initial as
FS_CONTEXT_CREATE_PARAMS, restart_syscall will return -EBUSY. fc is created
in fsopen syscall.
next reply other threads:[~2023-09-22 2:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 2:18 Cai Xinchen [this message]
2023-09-22 8:08 ` Christian Brauner
2023-09-29 15:53 ` Alexander Mikhalitsyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84e5fb5f-67c5-6d34-b93b-b307c6c9805c@huawei.com \
--to=caixinchen1@huawei.com \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®