From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37293C63797 for ; Tue, 17 Jan 2023 06:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235675AbjAQGw5 (ORCPT ); Tue, 17 Jan 2023 01:52:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235683AbjAQGww (ORCPT ); Tue, 17 Jan 2023 01:52:52 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E18FD22789; Mon, 16 Jan 2023 22:52:47 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 1E6C224E19A; Tue, 17 Jan 2023 14:52:46 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 17 Jan 2023 14:52:45 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 17 Jan 2023 14:52:44 +0800 Message-ID: <84e783a6-0aea-a6ba-13a0-fb29c66cc81a@starfivetech.com> Date: Tue, 17 Jan 2023 14:52:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20230106030001.1952-1-yanhong.wang@starfivetech.com> <20230106030001.1952-3-yanhong.wang@starfivetech.com> <2328562d-59a2-f60e-b17b-6cf16392e01f@linaro.org> From: yanhong wang In-Reply-To: <2328562d-59a2-f60e-b17b-6cf16392e01f@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/1/6 20:44, Krzysztof Kozlowski wrote: > On 06/01/2023 03:59, Yanhong Wang wrote: >> Some boards(such as StarFive VisionFive v2) require more than one value >> which defined by resets property, so the original definition can not >> meet the requirements. In order to adapt to different requirements, >> adjust the maxitems number definition. >> >> Signed-off-by: Yanhong Wang >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 36 ++++++++++++++----- >> 1 file changed, 28 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index e26c3e76ebb7..f7693e8c8d6d 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -132,14 +132,6 @@ properties: >> - pclk >> - ptp_ref >> >> - resets: >> - maxItems: 1 >> - description: >> - MAC Reset signal. >> - >> - reset-names: >> - const: stmmaceth >> - >> power-domains: >> maxItems: 1 >> >> @@ -463,6 +455,34 @@ allOf: >> Enables the TSO feature otherwise it will be managed by >> MAC HW capability register. >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: starfive,jh7110-dwmac >> + > > Looking at your next binding patch, this seems a bit clearer. First of > all, this patch on itself has little sense. It's not usable on its own, > because you need the next one. > > Probably the snps,dwmac should be just split into common parts used by > devices. It makes code much less readable and unnecessary complicated to > support in one schema both devices and re-usability. > > Otherwise I propose to make the resets/reset-names just like clocks are > made: define here wide constraints and update all other users of this > binding to explicitly restrict resets. > > Thanks, refer to the definition of clocks. If it is defined as follows, is it OK? properties: resets: minItems: 1 maxItems: 3 additionalItems: true items: - description: MAC Reset signal. reset-names: minItems: 1 maxItems: 3 additionalItems: true contains: enum: - stmmaceth allOf: - if: properties: compatible: contains: const: starfive,jh7110-dwmac then: properties: resets: minItems: 2 maxItems: 2 reset-names: items: - const: stmmaceth - const: ahb required: - resets - reset-names else: properties: resets: maxItems: 1 description: MAC Reset signal. reset-names: const: stmmaceth Do you have any other better suggestions? > Best regards, > Krzysztof >