From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754510AbcEPRnk (ORCPT ); Mon, 16 May 2016 13:43:40 -0400 Received: from ausc60ps301.us.dell.com ([143.166.148.206]:28383 "EHLO ausc60ps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbcEPRni convert rfc822-to-8bit (ORCPT ); Mon, 16 May 2016 13:43:38 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=itmK6bRfUswZh0KbsDtHaZKfeyYjezkeqTW2cITV+THQ3feqjWCMoCd8 DQyMf8VIfkNYBzEW44cXxj0uRBacS8QycP+4G0d9ObuTcgGXOiEEgU2n/ CG5hAgRXR9oL5BuFxRAnn2ME7FcCFbxMXRK9gKyzbl8DkjOfhbxUY16w9 k=; X-LoopCount0: from 10.170.28.40 X-IronPort-AV: E=Sophos;i="5.26,627,1459832400"; d="scan'208";a="822322881" From: To: , CC: Subject: RE: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware Thread-Topic: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware Thread-Index: AQHRr4liYVOCDM3KLE6eRjApjCcdhJ+8IPWA//+0q2A= Date: Mon, 16 May 2016 17:43:35 +0000 Message-ID: <84e8efcd8dfe40a299d8ede84ae5c962@ausx13mpc124.AMER.DELL.COM> References: <1463413264-32500-1-git-send-email-mario_limonciello@dell.com> <5137db8c-644e-3306-882c-cc820394cbce@redhat.com> In-Reply-To: <5137db8c-644e-3306-882c-cc820394cbce@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.208.89.195] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Laura Abbott [mailto:labbott@redhat.com] > Sent: Monday, May 16, 2016 12:12 PM > To: Limonciello, Mario ; > ming.lei@canonical.com > Cc: LKML > Subject: Re: [PATCH] dell_rbu: Don't fallback to userhelper when loading > firmware > > On 05/16/2016 08:41 AM, Mario Limonciello wrote: > > dell_rbu previously would allow a userspace application to craft the > > payload after dell_rbu was loaded and abuse the udev userspace API. > > > > Instead require the payload to be crafted and placed in > > /lib/firmware/dell_rbu ahead of time. > > > > This adjusts dell_rbu to immediately load the firmware from > > /lib/firmware/dell_rbu when "init" is passed into image_type using the > > kernel helper. > > Looks like you missed the Signed-off-by line. > > Can you also drop the Kconfig dependency on > CONFIG_FW_LOADER_USER_HELPER? > > Thanks, > Laura Sure thing. > > > --- > > drivers/firmware/dell_rbu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c > > index d5f5b98..5ecf043 100644 > > --- a/drivers/firmware/dell_rbu.c > > +++ b/drivers/firmware/dell_rbu.c > > @@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp, > struct kobject *kobj, > > if (!rbu_data.entry_created) { > > spin_unlock(&rbu_data.lock); > > req_firm_rc = > request_firmware_nowait(THIS_MODULE, > > - > FW_ACTION_NOHOTPLUG, > > + FW_ACTION_HOTPLUG, > > "dell_rbu", > > &rbu_device->dev, > > GFP_KERNEL, > >