mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ralph Campbell <rcampbell@nvidia.com>
To: Alistair Popple <apopple@nvidia.com>, bskeggs@redhat.com
Cc: kherbst@redhat.com, lyude@redhat.com, airlied@linux.ie,
	daniel@ffwll.ch, nouveau@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	jhubbard@nvidia.com
Subject: Re: [PATCH] nouveau/svm: Fix to migrate all requested pages
Date: Thu, 28 Jul 2022 12:27:45 -0700	[thread overview]
Message-ID: <84ec4ad5-a580-1a43-27ed-d47dbdf7d1bc@nvidia.com> (raw)
In-Reply-To: <20220720062745.960701-1-apopple@nvidia.com>

On 7/19/22 23:27, Alistair Popple wrote:

> Users may request that pages from an OpenCL SVM allocation be migrated
> to the GPU with clEnqueueSVMMigrateMem(). In Nouveau this will call into
> nouveau_dmem_migrate_vma() to do the migration. If the total range to be
> migrated exceeds SG_MAX_SINGLE_ALLOC the pages will be migrated in
> chunks of size SG_MAX_SINGLE_ALLOC. However a typo in updating the
> starting address means that only the first chunk will get migrated.
>
> Fix the calculation so that the entire range will get migrated if
> possible.
>
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> Fixes: e3d8b0890469 ("drm/nouveau/svm: map pages after migration")

Thanks for fixing this!
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>


  reply	other threads:[~2022-07-28 19:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20  6:27 Alistair Popple
2022-07-28 19:27 ` Ralph Campbell [this message]
2022-07-28 20:17 ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84ec4ad5-a580-1a43-27ed-d47dbdf7d1bc@nvidia.com \
    --to=rcampbell@nvidia.com \
    --cc=airlied@linux.ie \
    --cc=apopple@nvidia.com \
    --cc=bskeggs@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jhubbard@nvidia.com \
    --cc=kherbst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®