From: Naidu Nama <naidu.nama@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: vkoul@kernel.org, neil.armstrong@linaro.org, mani@kernel.org,
robin.clark@oss.qualcomm.com, lumag@kernel.org,
abhinav.kumar@linux.dev, jesszhan0024@gmail.com, sean@poorly.run,
marijn.suijten@somainline.org, irlied@gmail.com, simona@ffwll.ch,
Saurabh Anand <saurabh.anand@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
quic_riteshk@quicinc.com, quic_vproddut@quicinc.com,
quic_mkuntuma@quicinc.com, mahadevan.p@oss.qualcomm.com
Subject: Re: [PATCH v2 2/3] drm/msm/dp: Remove redundant force_link_train flag
Date: Fri, 13 Nov 2026 10:22:49 +0530 [thread overview]
Message-ID: <84eed340-905b-43fa-9c63-135401920e5f@oss.qualcomm.com> (raw)
In-Reply-To: <gfzdwaeouexratptiktpzodi44x6ztsfttqajzr5wxtrluyqjx@axwlv5jlakcc>
On 11-11-2026 19:36, Dmitry Baryshkov wrote:
> On Wed, Nov 11, 2026 at 04:13:54PM +0530, naidu nama wrote:
>> From: Saurabh Anand <saurabh.anand@oss.qualcomm.com>
>>
>> force_link_train is always false when passed to
>> msm_dp_ctrl_prepare_stream_on(): the initial link is trained by
>> msm_dp_ctrl_on_link(), and the flag is cleared before stream preparation.
>> For active streams, it is never set.
>>
>> Remove the dead flag and parameter. Stream preparation still retrains
>> when channel equalization is incomplete.
>>
>> Signed-off-by: Saurabh Anand <saurabh.anand@oss.qualcomm.com>
>> ---
>> drivers/gpu/drm/msm/dp/dp_ctrl.c | 5 ++---
>> drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 +--
>> drivers/gpu/drm/msm/dp/dp_display.c | 4 +---
>> 3 files changed, 4 insertions(+), 8 deletions(-)
> The same SoB comment.
Sure, I will update in v3.
>
next prev parent reply other threads:[~2026-11-13 4:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 10:43 [PATCH v2 0/3] drm/msm/dp, phy: qcom: improve DP Type-C reconnect handli naidu nama
2026-11-11 10:43 ` [PATCH v2 1/3] phy: qcom: qmp-combo: delay Type-C mux switch while DP PHY is initializing naidu nama
2026-11-11 14:06 ` Dmitry Baryshkov
2026-11-13 4:51 ` Naidu Nama
2026-11-11 10:43 ` [PATCH v2 2/3] drm/msm/dp: Remove redundant force_link_train flag naidu nama
2026-11-11 14:06 ` Dmitry Baryshkov
2026-11-13 4:52 ` Naidu Nama [this message]
2026-11-11 10:43 ` [PATCH v2 3/3] drm/msm/dp: continue link training downgrade when cable is still plugged naidu nama
2026-11-11 14:08 ` Dmitry Baryshkov
2026-11-13 5:02 ` Naidu Nama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84eed340-905b-43fa-9c63-135401920e5f@oss.qualcomm.com \
--to=naidu.nama@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=irlied@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=mahadevan.p@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_mkuntuma@quicinc.com \
--cc=quic_riteshk@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=saurabh.anand@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®