From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B0DC433F4 for ; Fri, 31 Aug 2018 04:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1004220837 for ; Fri, 31 Aug 2018 04:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1004220837 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727318AbeHaIld (ORCPT ); Fri, 31 Aug 2018 04:41:33 -0400 Received: from gate.crashing.org ([63.228.1.57]:40251 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727070AbeHaIld (ORCPT ); Fri, 31 Aug 2018 04:41:33 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w7V4Zd03004846; Thu, 30 Aug 2018 23:35:40 -0500 Message-ID: <84f13bded54eda0817f9134f355d518d5b3a5f77.camel@kernel.crashing.org> Subject: Re: v4.17 regression: PowerMac G3 won't boot, was Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle() From: Benjamin Herrenschmidt To: Mac User , Rob Herring Cc: fthain@telegraphics.com.au, Frank Rowand , Chintan Pandya , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linuxppc-dev Date: Fri, 31 Aug 2018 14:35:39 +1000 In-Reply-To: <569e4bc3-2149-4b2d-562f-e400dd05a8a8@yahoo.com> References: <1520208889-3908-1-git-send-email-frowand.list@gmail.com> <1520208889-3908-2-git-send-email-frowand.list@gmail.com> <569e4bc3-2149-4b2d-562f-e400dd05a8a8@yahoo.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-08-30 at 20:39 -0600, Mac User wrote: > On 8/29/18 7:05 PM, Rob Herring wrote: > > > On Wed, Aug 29, 2018 at 7:44 PM Finn Thain wrote: > > > Hi Frank, > > > > > > Linux v4.17 and later will no longer boot on a G3 PowerMac. The boot hangs > > > very early, before any video driver loads. > > > > > > Stan and I were able to bisect the regression between v4.16 and v4.17 and > > > arrived at commit 0b3ce78e90fc ("of: cache phandle nodes to reduce cost of > > > of_find_node_by_phandle()"). > > > > > > I don't see any obvious bug in 0b3ce78e90fc or b9952b5218ad. But if you > > > revert these from v4.18 (which is also affected) that certainly resolves > > > the issue. > > > > Perhaps a bad assumption on phandle values causing a problem. Can you > > provide a dump of all the phandle or linux,phandle values from > > /proc/device-tree. > > > > Rob > > Rob, > > As suggested by Finn, I installed device-tree-compiler and > powerpc-ibm-utils. > > Running "dtc -I fs -H both /sys/firmware/devicetree/base" > resulted in the following errors: > > DTC: fs->dts on file "/sys/firmware/devicetree/base" > ERROR (name_properties): "name" property in > /pci/multifunc-device/pci1799,1#1 is incorrect ("pci1799,1" instead of > base node name) > ERROR (name_properties): "name" property in /pci/mac-io/ide#1 is > incorrect ("ide" instead of base node name) > ERROR (name_properties): "name" property in > /pci/mac-io/ide#1/atapi-disk#1 is incorrect ("atapi-disk" instead of > base node name) > ERROR (name_properties): "name" property in /cpus/PowerPC,750/l2-cache#1 > is incorrect ("l2-cache" instead of base node name) > ERROR: Input tree has errors, aborting (use -f to force output) > > If I force output with "-f", the resulting file has no occurrences > of "phandle". Are you booting with BootX or Open Firmware ? > Running "lsprop /proc/device-tree | grep -i phandle" results in no > output. > > Please let me know if there's some other way to get information that > would be helpful. > > thanks > > -Stan