From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C65C433DF for ; Fri, 9 Oct 2020 14:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5FBE222B9 for ; Fri, 9 Oct 2020 14:18:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="hxFVkoe9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388678AbgJIOSc (ORCPT ); Fri, 9 Oct 2020 10:18:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388649AbgJIOSb (ORCPT ); Fri, 9 Oct 2020 10:18:31 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DB2FC0613D2 for ; Fri, 9 Oct 2020 07:18:31 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id b69so10684342qkg.8 for ; Fri, 09 Oct 2020 07:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2Nsozhx6Vbc7+gevBK4suxhbi1tLEGMu37jB4LFRAPw=; b=hxFVkoe9fUSNiPI+uQ12JsKm6OjRLbKc/6lbFpVRDpIhsRf4KNWmimf4Uw4bwdRTz5 uQebX3pJKZMtpcnAIYfdaL/HusqLmmVCjy1WhA7fNAyfon0iBRnmnTuq2eXAKWGAKu/g /vTH9xfC6VEOLORYAQpLlpSOhlk9U2mh95fmy7zrpVmL8CpQGirmNAr8bviupqSX4BiN JsjOaIWFbd15tmtcIRr9ygyReyr9DpipdN4qGf3pIBBGAQj2KR4tjY8vTI0zqQxk5GwQ Ocn5+xIj9xtTzKOSYGRzic4/Nq4+1UxKLsdYs+sy/07AkRNYMjjoJc4aPs5x3V89ALRG 9rTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2Nsozhx6Vbc7+gevBK4suxhbi1tLEGMu37jB4LFRAPw=; b=Z83/il86P19eUJ6KCC4YlOw8LD1zSxpuwEOs5XzWs7VZwOsxbPoe1k8gpUzTgFSX4E r4InisMIbQA9i6q2AiMmo3KToIWgZsy9Vd2/9ZqIqbRrEOa2xkI1vM5pEk1beCA+FwFA HtQf8zZmJoUCHE00tdKS2AsXsBHNB0bMnIMTqMbu7ZeT4hEBMKvZko4s2b1b6a8P6W9v qiwGj6aJGKnVIJeMXy1Gp/fneOmC6ADOWI7ETjt0lfbm3QLlgGu9AHZEtA2ft/T2oY15 j0ZqdoSG0rKWOlxZg67Xw7UfyZi8wSJMrHRN6ITzSXER4aG8bnuaghEWwciHGHHvu/dk kXeA== X-Gm-Message-State: AOAM531mT4WVTexMWu5uK+Iq7rxoC+HvC4dfCDsqWw50HnOoVQLIv3m9 lyS1tnkJhiBH7Dui7MJ3SNU1EA== X-Google-Smtp-Source: ABdhPJwWctAz3Cj788czTSYpVZIZN+OINVRMuTkx431OvmGfAhyvUvX02fo6IXvszZ32Z1TA67pjlA== X-Received: by 2002:a37:4587:: with SMTP id s129mr12042169qka.99.1602253110784; Fri, 09 Oct 2020 07:18:30 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a8:11e8::107d? ([2620:10d:c091:480::1:f1f8]) by smtp.gmail.com with ESMTPSA id t7sm5107903qkm.130.2020.10.09.07.18.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2020 07:18:29 -0700 (PDT) Subject: Re: [PATCH 6/7] btrfs: Promote to unsigned long long before shifting To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: ericvh@gmail.com, lucho@ionkov.net, viro@zeniv.linux.org.uk, jlayton@kernel.org, idryomov@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-btrfs@vger.kernel.org, clm@fb.com, dsterba@suse.com, stable@vger.kernel.org References: <20201004180428.14494-1-willy@infradead.org> <20201004180428.14494-7-willy@infradead.org> From: Josef Bacik Message-ID: <84f3800c-445e-6dbf-2381-56840d7bba69@toxicpanda.com> Date: Fri, 9 Oct 2020 10:18:27 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201004180428.14494-7-willy@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/4/20 2:04 PM, Matthew Wilcox (Oracle) wrote: > On 32-bit systems, this shift will overflow for files larger than 4GB. > > Cc: stable@vger.kernel.org > Fixes: 53b381b3abeb ("Btrfs: RAID5 and RAID6") > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Josef Bacik Thanks, Josef