From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D28AC433FF for ; Tue, 13 Aug 2019 03:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A69220840 for ; Tue, 13 Aug 2019 03:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727129AbfHMDUc (ORCPT ); Mon, 12 Aug 2019 23:20:32 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4666 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726516AbfHMDUc (ORCPT ); Mon, 12 Aug 2019 23:20:32 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C41CBBDF5305D4C95974; Tue, 13 Aug 2019 11:20:29 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 13 Aug 2019 11:20:21 +0800 Subject: Re: [PATCH 3/3] staging: erofs: xattr.c: avoid BUG_ON To: Gao Xiang , Greg Kroah-Hartman , , CC: LKML , , "Chao Yu" , Miao Xie , , Fang Wei References: <20190813023054.73126-1-gaoxiang25@huawei.com> <20190813023054.73126-3-gaoxiang25@huawei.com> From: Chao Yu Message-ID: <84f50ca2-3411-36a6-049a-0d343d8df325@huawei.com> Date: Tue, 13 Aug 2019 11:20:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190813023054.73126-3-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/8/13 10:30, Gao Xiang wrote: > Kill all the remaining BUG_ON in EROFS: > - one BUG_ON was used to detect xattr on-disk corruption, > proper error handling should be added for it instead; > - the other BUG_ONs are used to detect potential issues, > use DBG_BUGON only in (eng) debugging version. BTW, do we need add WARN_ON() into DBG_BUGON() to show some details function or call stack in where we encounter the issue? > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,