From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14999C3F2D1 for ; Thu, 5 Mar 2020 16:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E77B52072D for ; Thu, 5 Mar 2020 16:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726177AbgCEQCj (ORCPT ); Thu, 5 Mar 2020 11:02:39 -0500 Received: from smtprelay0252.hostedemail.com ([216.40.44.252]:59879 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725946AbgCEQCj (ORCPT ); Thu, 5 Mar 2020 11:02:39 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 68BD5180A9556; Thu, 5 Mar 2020 16:02:38 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: pen85_16eb2d8e49438 X-Filterd-Recvd-Size: 1615 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA; Thu, 5 Mar 2020 16:02:37 +0000 (UTC) Message-ID: <84f8504924380fc6380216d03d28a2285e3d106e.camel@perches.com> Subject: Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select From: Joe Perches To: John Garry Cc: Mark Brown , linux-spi , LKML Date: Thu, 05 Mar 2020 08:01:02 -0800 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-03-05 at 15:53 +0000, John Garry wrote: > On 05/03/2020 15:15, Joe Perches wrote: > > commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash > > controller driver") likely inadvertently used a select statement > > with a CONFIG_ prefix, remove the prefix. > > > > Signed-off-by: Joe Perches > > It's a pity checkpatch can't pick this stuff up... You are free to write a rule and submit a patch. The grammar is pretty hard to verify from a patch fragment though. There are 2 existing nominal false positives. $ git grep 'select\b.*\bCONFIG_' -- '*/Kconfig*' drivers/edac/Kconfig: select CONFIG_ACPI_NFIT. drivers/edac/Kconfig: select CONFIG_ACPI_NFIT.