From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6BCC7618E for ; Sat, 22 Apr 2023 12:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbjDVMP1 (ORCPT ); Sat, 22 Apr 2023 08:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjDVMPZ (ORCPT ); Sat, 22 Apr 2023 08:15:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A3B211C for ; Sat, 22 Apr 2023 05:15:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD9576138B for ; Sat, 22 Apr 2023 12:15:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DB8AC433EF; Sat, 22 Apr 2023 12:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682165724; bh=dLzgToQ+97zNNFKyQ4T4DaBcoPkeYRwGP3sxxYoPM9E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eldrpYS8vH7GeFYeEKT4IhBo9fFMy7vhetIHJvkjuyjRUb365ddyzEQsRkdD7HYWM Rko3d3jdLDvUNvOm8zTGkAlRwiw1QsmBVMD0DJaJcPo8XD8iYvUUhkjiX+7ewPkKMY y1Sm1eznUkLbw42qZOSsLyke9JjMbuGA2wb8dU8dziT/cnU5znOTp5qE2hiKLOGq6K hvIofEQGg00LGGvOA46Odk+jy+LG0Q3NfwH4O2nXj520h9HCC9KBNcmdohYY5LvVDL VZqNhey9RMG1yiOoGcYHfR5BAml+cHwHpNRmHszlbATz2dPZyRmrZb9FJUJAcUKYAf mGKATj5TgiRww== Message-ID: <84f8a1d4-a0c6-c618-b3e0-4d0f4d4d5a8d@kernel.org> Date: Sat, 22 Apr 2023 20:15:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree Content-Language: en-US To: Jaegeuk Kim Cc: Qi Han , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20230418060954.67585-1-hanqi@vivo.com> From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/22 3:20, Jaegeuk Kim wrote: > On 04/21, Chao Yu wrote: >> On 2023/4/18 14:09, Qi Han wrote: >>> This comment make no sense and is in the wrong place, so let's >>> remove it. >>> >>> Signed-off-by: Qi Han >>> --- >>> fs/f2fs/extent_cache.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c >>> index 28b12553f2b3..1f6d7de35794 100644 >>> --- a/fs/f2fs/extent_cache.c >>> +++ b/fs/f2fs/extent_cache.c >>> @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode) >>> if (!test_opt(sbi, AGE_EXTENT_CACHE)) >>> return false; >>> - /* don't cache block age info for cold file */ >>> if (is_inode_flag_set(inode, FI_COMPRESSED_FILE)) >>> return false; >> >> Should move it here instead of removal? >> >> /* don't cache block age info for cold file */ > > Not worth to comment this, as the code is exactly saying that. Correct. Reviewed-by: Chao Yu Thanks, > >> >>> if (file_is_cold(inode))