From: "Martin Hundebøll" <martin@geanix.com>
To: Esben Haabendal <esben.haabendal@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org
Cc: Kurt Kanzenbach <kurt@linutronix.de>,
Angelo Dureghello <angelo@sysam.it>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Sanchayan Maity <maitysanchayan@gmail.com>,
Yuan Yao <yao.yuan@nxp.com>,
linux-kernel@vger.kernel.org, Esben Haabendal <eha@deif.com>
Subject: Re: [PATCH 01/12] spi: spi-fsl-dspi: Drop unreachable else if statement
Date: Wed, 20 Jun 2018 10:40:54 +0200 [thread overview]
Message-ID: <84f8dca3-d1af-5190-270b-5f5319ae4987@geanix.com> (raw)
In-Reply-To: <20180620073442.20913-2-esben.haabendal@gmail.com>
On 2018-06-20 09:34, Esben Haabendal wrote:
> From: Esben Haabendal <eha@deif.com>
>
> The if statement just above this if/else statement triggers on the same
> condition, and then invalidates it.
>
> Signed-off-by: Esben Haabendal <eha@deif.com>
> Cc: Martin Hundebøll <martin@geanix.com>
For the entire series:
Acked-by: Martin Hundebøll <martin@geanix.com>
> ---
> drivers/spi/spi-fsl-dspi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> index 0630962ce442..3ca9b9608801 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -593,8 +593,7 @@ static int dspi_eoq_write(struct fsl_dspi *dspi)
> dspi_pushr |= SPI_PUSHR_EOQ;
> if ((dspi->cs_change) && (!dspi->len))
> dspi_pushr &= ~SPI_PUSHR_CONT;
> - } else if (tx_word && (dspi->len == 1))
> - dspi_pushr |= SPI_PUSHR_EOQ;
> + }
>
> regmap_write(dspi->regmap, SPI_PUSHR, dspi_pushr);
>
>
--
Kind regards,
Martin Hundebøll
Embedded Linux Consultant
+45 61 65 54 61
martin@geanix.com
Geanix IVS
DK39600706
next prev parent reply other threads:[~2018-06-20 8:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 7:34 [PATCH 00/12] XSPI mode for LS1021A DSPI Esben Haabendal
2018-06-20 7:34 ` [PATCH 01/12] spi: spi-fsl-dspi: Drop unreachable else if statement Esben Haabendal
2018-06-20 8:40 ` Martin Hundebøll [this message]
2018-06-20 7:34 ` [PATCH 02/12] spi: spi-fsl-dspi: Drop unneeded use of dataflags bits Esben Haabendal
2018-06-20 7:34 ` [PATCH 03/12] spi: spi-fsl-dspi: Fix per transfer cs_change handling Esben Haabendal
2018-06-20 13:27 ` Mark Brown
2018-06-20 13:40 ` Esben Haabendal
2018-06-20 7:34 ` [PATCH 04/12] spi: spi-fsl-dspi: Simplify transfer counter handling Esben Haabendal
2018-06-20 7:34 ` [PATCH 05/12] spi: spi-fsl-dspi: Support 4 to 16 bits per word transfers Esben Haabendal
2018-06-20 7:34 ` [PATCH 06/12] spi: spi-fsl-dspi: Fixup regmap configuration Esben Haabendal
2018-06-20 7:34 ` [PATCH 07/12] spi: spi-fsl-dspi: Fix MCR register handling Esben Haabendal
2018-06-20 7:34 ` [PATCH 08/12] spi: spi-fsl-dspi: Add support for XSPI mode registers Esben Haabendal
2018-06-20 7:34 ` [PATCH 09/12] spi: spi-fsl-dspi: Framesize control for XSPI mode Esben Haabendal
2018-06-20 7:34 ` [PATCH 10/12] spi: spi-fsl-dspi: XSPI FIFO handling (in TCFQ mode) Esben Haabendal
2018-06-20 7:34 ` [PATCH 11/12] spi: spi-fsl-dspi: Advertise 32 bit for XSPI mode Esben Haabendal
2018-06-20 7:34 ` [PATCH 12/12] spi: spi-fsl-dspi: Enable extended SPI mode Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84f8dca3-d1af-5190-270b-5f5319ae4987@geanix.com \
--to=martin@geanix.com \
--cc=angelo@sysam.it \
--cc=broonie@kernel.org \
--cc=eha@deif.com \
--cc=esben.haabendal@gmail.com \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=yao.yuan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®