From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9323B2FBE1F for ; Sat, 28 Feb 2026 16:50:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772297405; cv=none; b=XByAOFcsD9V6C5V6G7bQ27+n4JlCQEmVjb0WBjB8Qpspa17IwWO3X58l53VJpoMgEQVpnVBsbTWh8iR6zgKZJ2pS18gWWEDHvZj+CB0PlF5pTYlMZrLFTVUy0eA47/5kM9ZTDmlN+h/MnvEgbq7n0i4Sm2slp0k0zLNhgcHtcRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772297405; c=relaxed/simple; bh=l8EH17lWrfvjOatQpXujT58XPwHIhCRA7xEfz2ukHkI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=RLdrN7jy3phJ13L3q80PAQlUjS6uIIH/WQeLWVbgR+VsF/rffqwdvY0aBC27ELhLc8UdtzHUx9uMACpy3ISeQvpx468QaQpSDY5A3JsfNg3XqVNqnpwQHIel/CpIiGl3J7ZYnDV7qv2AF+tStRZmQBKXOEbPJsFiNuJDX4Hhn1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=p5C/D4l6; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="p5C/D4l6" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-45f10d7eb81so1281898b6e.3 for ; Sat, 28 Feb 2026 08:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772297401; x=1772902201; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Uuk0Fk7x52M96YnEPuk+cTgxxh8er/i4OgmVOBy10Ow=; b=p5C/D4l6uzn3OEeqriyPknESdUlhhWnC+sUfI5UFaSpqpObGdzvcqXJIJQxVzB/Y7w 82p4PAicJ79lbvaxmrE6l+bSz8IIiXU3ozc+GmULrM8ZQLuXjtPXlwRSWPC4cVjnK71b unDNCkVBk3bYwQ5Vl3pvMxFvrKKDZBKnKPINdOwuJH/lg2VymtwcXrsKlcpowRujvuAO /z5dWacWukoHL0kZ3jr6VMcU0gXcadKWFP5ab/7Vmyqc2S0TL7Wi8ku3Z8r0Ds7EYFUB MHB0tlOUPI6N9YXICsqhxmHNrSf6KqUJ8qHx8Dz+C/FumtxvWJH89NJiCgjWsJ8gTFzd OKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772297401; x=1772902201; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uuk0Fk7x52M96YnEPuk+cTgxxh8er/i4OgmVOBy10Ow=; b=Flwu/VHxgyRZjcWYmQn26u9Qh46CdRRzQZ0tgaqCcPAQ3mdH4HauM2e9gmWQoD9UPJ rNUIB6SXTajsLziVwf9Q01FgQ7jW2Mccd8cGsf84L39saiUP3+0E/cx5yZt0QjMm+nZW eecCv1cMgorbJe5qwp1pethtmYPf5Tz6Lw3Nok3MdFvUyNzK2z+O6CxA7Szx2Aq+gvUe fTy0dlz0OPed/keHY52AgQ/6W3Z5WZ2V0es8DxhOdSkoHIMNGs+7C+7vDjYQ31EIoT2V nww7eA+tENTPJ4pDWkuLRokiU2LmVU8Q7HrjjOWRwxrsu5PFZmKAx3ViicHdrY8BpXmZ KeHA== X-Forwarded-Encrypted: i=1; AJvYcCVVhaYRcLnLM3QY6KQHhTnZ5emV0nTFLHM4SRb8ou/k1ZcqqSCyUWVt8VrwDf1p2ocMR9SaJxm9+5j+Ukg=@vger.kernel.org X-Gm-Message-State: AOJu0YzY3Q29mnZagWTTqCLy5VT0EnkerlJZBQgkppTB7HAMAQSPm44p ZHqj+ks6nrBJMIwdWdVadX+6Tgy8rGzgnYkUoo6lfSKDEjgrhIe50DgRn1Ax5sstRw8= X-Gm-Gg: ATEYQzyIupxlqzbVPrjc4qANPM8r6X2ZlwgnvDzAhGOuGxVGlQmbaAoPCuXGYhMAtG/ HBKxXPzffngcGs5rNuo995n8Ai0zlVrji1ZBniDxzc9+hLcTp6dWflxfvzfufoFDzA4SP7k2c+1 EhDSnh69SwQfI9EI21P/kuIpV1ZggV+LRFDphw7ZSy+TMcg3mmSe2gjP4IuaKleBtiPq31TkJwd 2HRuEY8Mk+RWRVNQlwnEa/IQetUb/8S8rxjqQOYW5WLDZhH5L2Jckj938IM0xQb/IG6D0uZxmwo Pm4xeZihuOq7i1qyfzo8fmoZlHyj6XDVb4IcZgdl+p+Vlcd+hkjPyEep8UE3q13gwRn//me2n0B dOmcss1sy+qeIu0tiured+8iRJfn4IuONokt7Rb9HR5kJ9eBlBaVHMp8oh2ieyfW+/Q7n01P4gI tU0FX/6nZ7V5xKROvpnNUNZBtUPm5yuG/Emoc1pA+2omyOxMA6OUph977Cr5cUtlxKIXa/VSSWU A== X-Received: by 2002:a05:6808:67c8:b0:44f:e954:ba44 with SMTP id 5614622812f47-464bea2890bmr4199475b6e.28.1772297401404; Sat, 28 Feb 2026 08:50:01 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:1031:c44e:9f1f:17c1? ([2600:8803:e7e4:500:1031:c44e:9f1f:17c1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4160d26d20asm6907738fac.15.2026.02.28.08.50.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Feb 2026 08:50:01 -0800 (PST) Message-ID: <84fae6b8-d188-4e5c-af06-b342f3d27514@baylibre.com> Date: Sat, 28 Feb 2026 10:50:00 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: accel: adxl380: fix FIFO watermark bit 8 always written as 0 To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Ramona Gradinariu , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260227124305.55271-1-antoniu.miclaus@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260227124305.55271-1-antoniu.miclaus@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/26 6:43 AM, Antoniu Miclaus wrote: > FIELD_PREP(BIT(0), fifo_samples & BIT(8)) produces either 0 or 256, > and since FIELD_PREP masks to bit 0, 256 & 1 evaluates to 0. Use !! > to convert the result to a proper 0-or-1 value. > > Fixes: df36de13677a ("iio: accel: add ADXL380 driver") > Signed-off-by: Antoniu Miclaus > --- > drivers/iio/accel/adxl380.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c > index 8fab2fdbe147..a51d1d61c412 100644 > --- a/drivers/iio/accel/adxl380.c > +++ b/drivers/iio/accel/adxl380.c > @@ -877,7 +877,7 @@ static int adxl380_set_fifo_samples(struct adxl380_state *st) Some relevant context... u16 fifo_samples = st->watermark * st->fifo_set_size; > ret = regmap_update_bits(st->regmap, ADXL380_FIFO_CONFIG_0_REG, > ADXL380_FIFO_SAMPLES_8_MSK, > FIELD_PREP(ADXL380_FIFO_SAMPLES_8_MSK, > - (fifo_samples & BIT(8)))); > + !!(fifo_samples & BIT(8)))); Technically, this works, but in terms of understanding the code I think fifo_samples >= BIT(8) would make more sense. fifo_samples is a count, not bit flags. > if (ret) > return ret; >