mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Huacai Chen <chenhuacai@kernel.org>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 4/4] LoongArch: Remove -fno-jump-tables for objtool
Date: Mon, 15 Jul 2024 18:35:04 +0800	[thread overview]
Message-ID: <8506fd62-5c48-bbfa-d4ec-4ef237cbe5df@loongson.cn> (raw)
In-Reply-To: <ae3ff9787e9d3f41b71e8e4168610a01d5304371.camel@xry111.site>

On 07/13/2024 05:10 PM, Xi Ruoyao wrote:
> On Fri, 2024-07-12 at 17:49 +0800, Xi Ruoyao wrote:
>> On Fri, 2024-07-12 at 17:15 +0800, Tiezhu Yang wrote:
>>> -ifdef CONFIG_OBJTOOL
>>> -KBUILD_CFLAGS			+= -fno-jump-tables
>>> -endif
>>> +KBUILD_AFLAGS			+= $(call cc-option,-mannotate-tablejump) $(call cc-option,-Wa$(comma)-mannotate-tablejump)
>>> +KBUILD_CFLAGS			+= $(call cc-option,-mannotate-tablejump) $(call cc-option,-Wa$(comma)-mannotate-tablejump)
>>
>> KBUILD_AFLAGS isn't needed, and $(call cc-option,-Wa$(comma)-mannotate-
>> tablejump) will always expand to nothing because the assembler does not
>> have -mannotate-tablejump.
>>
>> The assembler never creates a jump table itself.

Thanks, you are right, I will modify it in the formal v1 series.

> BTW have you discussed with Lulu about the -mannotate-tablejump patch?
> I guess maybe an intra-Loongson discussion would be helpful.

Yes, I have discussed with Loongson compiler team some days ago
and will discuss more to reach an agreement in the next few days.

Thanks,
Tiezhu


  reply	other threads:[~2024-07-15 10:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12  9:15 [RFC PATCH 0/4] Add jump table support for objtool on LoongArch Tiezhu Yang
2024-07-12  9:15 ` [RFC PATCH 1/4] objtool: Check local label in find_jump_table() Tiezhu Yang
2024-07-12  9:15 ` [RFC PATCH 2/4] objtool: Check various types in add_jump_table() Tiezhu Yang
2024-07-12  9:15 ` [RFC PATCH 3/4] objtool/LoongArch: Add support for jump table Tiezhu Yang
2024-07-12  9:15 ` [RFC PATCH 4/4] LoongArch: Remove -fno-jump-tables for objtool Tiezhu Yang
2024-07-12  9:40   ` Huacai Chen
2024-07-15 10:32     ` Tiezhu Yang
2024-07-12  9:49   ` Xi Ruoyao
2024-07-13  9:10     ` Xi Ruoyao
2024-07-15 10:35       ` Tiezhu Yang [this message]
2024-07-12 10:19 ` [RFC PATCH 0/4] Add jump table support for objtool on LoongArch Jinyang He
2024-07-15  9:56   ` Tiezhu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8506fd62-5c48-bbfa-d4ec-4ef237cbe5df@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=chenhuacai@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=peterz@infradead.org \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®