From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AB94EB64D7 for ; Sun, 18 Jun 2023 17:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjFRRuo (ORCPT ); Sun, 18 Jun 2023 13:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjFRRum (ORCPT ); Sun, 18 Jun 2023 13:50:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C9ECE49 for ; Sun, 18 Jun 2023 10:50:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4C2A60039 for ; Sun, 18 Jun 2023 17:50:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C5F9C433C0; Sun, 18 Jun 2023 17:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687110640; bh=bLzXVhy+xeEKfGXoMV41qKelHKb8eMbvoUzE4zOYJjc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lU0/Nnr5fMWEeIs6RsF8lhHQWpJV4b/CGrN5ZAiQQeVXnHYWyes798NUt+Amw8BHz Wv/DWmw3sfwYsNE/hU+Smut3RXEf36m2m+d+9x5SFu5viohtOhnFHZtceeQc5D3eeH LCcaQGBIaRoHzNxwsat4Pbz8OI0ZtOK/hDht2pRQ7kzi2BFnPzjVT7cFCQ7AUIg27B FBHMgcPefrFrRzRdj0i/vRDOLigCOroqFQZLDk85kC8YZyosm2+ndM5FW14elYbwSo J7zRN3sqVRyoUmUhtDzZtrUDbcAOSrIkqi/Lu2XPH49Fw/yjDaHe23suXK72cIzlHN wUaZAFEAgzlJw== Message-ID: <85077827-d11d-d3e6-0d23-9e60974cad0f@kernel.org> Date: Sun, 18 Jun 2023 10:50:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v7 04/22] net/tcp: Prevent TCP-MD5 with TCP-AO being set To: Dmitry Safonov , Eric Dumazet , Paolo Abeni , Jakub Kicinski , "David S. Miller" Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Ard Biesheuvel , Bob Gilligan , Dan Carpenter , David Laight , Dmitry Safonov <0x7f454c46@gmail.com>, Donald Cassidy , Eric Biggers , "Eric W. Biederman" , Francesco Ruggeri , Herbert Xu , Hideaki YOSHIFUJI , Ivan Delalande , Leonard Crestez , Salam Noureddine , netdev@vger.kernel.org References: <20230614230947.3954084-1-dima@arista.com> <20230614230947.3954084-5-dima@arista.com> Content-Language: en-US From: David Ahern In-Reply-To: <20230614230947.3954084-5-dima@arista.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/14/23 4:09 PM, Dmitry Safonov wrote: > Be as conservative as possible: if there is TCP-MD5 key for a given peer > regardless of L3 interface - don't allow setting TCP-AO key for the same > peer. According to RFC5925, TCP-AO is supposed to replace TCP-MD5 and > there can't be any switch between both on any connected tuple. > Later it can be relaxed, if there's a use, but in the beginning restrict > any intersection. > > Note: it's still should be possible to set both TCP-MD5 and TCP-AO keys > on a listening socket for *different* peers. Does the testsuite cover use of both MD5 and AO for a single listening socket with different peers and then other tests covering attempts to use both for a same peer?