From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751185AbeAVHAx (ORCPT ); Mon, 22 Jan 2018 02:00:53 -0500 Received: from mout01.posteo.de ([185.67.36.65]:35194 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbeAVHAv (ORCPT ); Mon, 22 Jan 2018 02:00:51 -0500 Subject: Re: [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe() To: SF Markus Elfring , linux-input@vger.kernel.org, Andi Shyti , Dmitry Torokhov , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Rob Herring , Simon Budig , =?UTF-8?Q?Stefan_Sch=c3=b6fegger?= Cc: LKML , kernel-janitors@vger.kernel.org References: <45f8a6c2-423b-5bc1-6512-c5b954c5620b@users.sourceforge.net> From: Martin Kepplinger Message-ID: <850ca75e-6b13-8e08-b97e-2512e0841152@posteo.de> Date: Mon, 22 Jan 2018 08:00:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <45f8a6c2-423b-5bc1-6512-c5b954c5620b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-01-21 20:19, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 21 Jan 2018 20:10:03 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Martin Kepplinger > --- > drivers/input/touchscreen/edt-ft5x06.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > index c53a3d7239e7..9d2799c90150 100644 > --- a/drivers/input/touchscreen/edt-ft5x06.c > +++ b/drivers/input/touchscreen/edt-ft5x06.c > @@ -978,10 +978,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client, > dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n"); > > tsdata = devm_kzalloc(&client->dev, sizeof(*tsdata), GFP_KERNEL); > - if (!tsdata) { > - dev_err(&client->dev, "failed to allocate driver data.\n"); > + if (!tsdata) > return -ENOMEM; > - } > > chip_data = of_device_get_match_data(&client->dev); > if (!chip_data) >