From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3E7C433DB for ; Mon, 22 Feb 2021 16:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEEE764F04 for ; Mon, 22 Feb 2021 16:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231708AbhBVQ53 (ORCPT ); Mon, 22 Feb 2021 11:57:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbhBVQzU (ORCPT ); Mon, 22 Feb 2021 11:55:20 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 434ECC061797; Mon, 22 Feb 2021 08:53:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=Xontruqu8j+EPMvm5EjNyBu/NSdc8+024n4YCJagARM=; b=a8MmetQYLpF4NLef/YICcdNTy/ afMUJaPrVrNTnnoSGRe1hihGD/C/EBf378uxVce3/7GYgw40czleiTYg3EUO22CwlgeP4UDUDThC+ ageS9Hlgu9IEahx7WnZ3ZJmBJH8F5ZzrDiJieesfNObAIZ223M2A6j2lFhQ7y1gcSA9V/NOZa9/xZ WYsFEy4tajKdgB10/CI3B1vENmzb8bEyoXaJLMprP5ifXGF9KckTdQOgbCKvjeKejOuHG4qoPC3E4 kTnWvwIwnnipQisKMDkja7wwkrSHd/UqKb65KrH7DpgvLIP4cIpMtednuQjHuSYFhxrqrFPdil99J vBUMU+VA==; Received: from [2601:1c0:6280:3f0::d05b] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEET5-0006AE-EU; Mon, 22 Feb 2021 16:53:55 +0000 Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO To: Jason Gunthorpe Cc: Leon Romanovsky , Arnd Bergmann , Zhu Yanjun , Julian Braha , Doug Ledford , RDMA mailing list , LKML References: <21525878.NYvzQUHefP@ubuntu-mate-laptop> <20210222155845.GI2643399@ziepe.ca> <20210222164645.GK2643399@ziepe.ca> From: Randy Dunlap Message-ID: <850d8bf2-c5a0-9fee-f95f-2dfc7d22a528@infradead.org> Date: Mon, 22 Feb 2021 08:53:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210222164645.GK2643399@ziepe.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/22/21 8:46 AM, Jason Gunthorpe wrote: > On Mon, Feb 22, 2021 at 08:26:10AM -0800, Randy Dunlap wrote: >> On 2/22/21 7:58 AM, Jason Gunthorpe wrote: >>> On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: >>>> On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: >>>>> On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky wrote: >>>>>> >>>>>> On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: >>>>>>> commit 6e61907779ba99af785f5b2397a84077c289888a >>>>>>> Author: Julian Braha >>>>>>> Date: Fri Feb 19 18:20:57 2021 -0500 >>>>>>> >>>>>>> drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO >>>>>>> >>>>>>> When RDMA_RXE is enabled and CRYPTO is disabled, >>>>>>> Kbuild gives the following warning: >>>>>>> >>>>>>> WARNING: unmet direct dependencies detected for CRYPTO_CRC32 >>>>>>> Depends on [n]: CRYPTO [=n] >>>>>>> Selected by [y]: >>>>>>> - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y] >>>>>>> >>>>>>> This is because RDMA_RXE selects CRYPTO_CRC32, >>>>>>> without depending on or selecting CRYPTO, despite that config option >>>>>>> being subordinate to CRYPTO. >>>>>>> >>>>>>> Signed-off-by: Julian Braha >>>>>> >>>>>> Please use git sent-email to send patches and please fix crypto Kconfig >>>>>> to enable CRYPTO if CRYPTO_* selected. >>>>>> >>>>>> It is a little bit awkward to request all users of CRYPTO_* to request >>>>>> select CRYPTO too. >>>>> >>>>> The same issue and similar patch is in this link: >>>>> >>>>> https://patchwork.kernel.org/project/linux-rdma/patch/20200915101559.33292-1-fazilyildiran@gmail.com/#23615747 >>>> >>>> So what prevents us from fixing CRYPTO Kconfig? >>> >>> Yes, I would like to see someone deal with this properly, either every >>> place doing select CRYPTO_XX needs fixing or something needs to be >>> done in the crypto layer. >>> >>> I have no idea about kconfig to give advice, I've added Arnd since he >>> always seems to know :) >> >> I will Ack the original patch in this thread. > > The one from Julian? Yes. > >> How many Mellanox drivers are you concerned about? > > ?? This is about rxe OK. >> You don't have to fix any other drivers that have a similar issue. > > Why shouldn't they be fixed too? Of course, but it's not just on you and/or Leon to fix them. > There is nearly 1000 places that use a 'select CRYPTO_*' in the > kernel. > > I see only 60 'select CRYPTO' statements. Correct. :( We (community) tend to fix bug reports, not do global audits to see what needs to be fixed (with a few exceptions). I'll gladly wait to see what Arnd says. -- ~Randy