From: Bart Van Assche <bvanassche@acm.org>
To: manivannan.sadhasivam@linaro.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Abel Vesa <abel.vesa@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Amit Pundir <amit.pundir@linaro.org>,
Nitin Rawat <quic_nitirawa@quicinc.com>,
stable@vger.kernel.org,
Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
Subject: Re: [PATCH 0/3] scsi: ufs: qcom: Suspend fixes
Date: Thu, 12 Dec 2024 09:51:40 -0800 [thread overview]
Message-ID: <8511253c-d496-4c87-9625-bcaefa440c64@acm.org> (raw)
In-Reply-To: <20241211-ufs-qcom-suspend-fix-v1-0-83ebbde76b1c@linaro.org>
On 12/11/24 9:40 AM, Manivannan Sadhasivam via B4 Relay wrote:
> This series fixes the several suspend issues on Qcom platforms. Patch 1 fixes
> the resume failure with spm_lvl=5 suspend on most of the Qcom platforms. For
> this patch, I couldn't figure out the exact commit that caused the issue. So I
> used the commit that introduced reinit support as a placeholder.
>
> Patch 3 fixes the suspend issue on SM8550 and SM8650 platforms where UFS
> PHY retention is not supported. Hence the default spm_lvl=3 suspend fails. So
> this patch configures spm_lvl=5 as the default suspend level to force UFSHC/
> device powerdown during suspend. This supersedes the previous series [1] that
> tried to fix the issue in clock drivers.
If Avri's comment is addressed, feel free to add my reviewed-by to this
series.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-12-12 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 17:40 Manivannan Sadhasivam via B4 Relay
2024-12-11 17:40 ` [PATCH 1/3] scsi: ufs: qcom: Power off the PHY if it was already powered on in ufs_qcom_power_up_sequence() Manivannan Sadhasivam via B4 Relay
2024-12-11 17:40 ` [PATCH 2/3] scsi: ufs: qcom: Allow passing platform specific OF data Manivannan Sadhasivam via B4 Relay
2024-12-12 11:06 ` Avri Altman
2024-12-12 14:13 ` Neil Armstrong
2024-12-11 17:40 ` [PATCH 3/3] scsi: ufs: qcom: Power down the controller/device during system suspend for SM8550/SM8650 SoCs Manivannan Sadhasivam via B4 Relay
2024-12-12 17:51 ` Bart Van Assche [this message]
2024-12-13 12:28 ` [PATCH 0/3] scsi: ufs: qcom: Suspend fixes Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8511253c-d496-4c87-9625-bcaefa440c64@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abel.vesa@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rdwivedi@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®