From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807BA481AAC for ; Mon, 14 Sep 2026 16:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789403678; cv=none; b=BUwHHp/iH1SjRYKHn4LfextlRpejHEIk/CwSF3eoeNiFo9M7TUZspOv7E6Dn2M2V5oPqir/8JRapnK9te/RP2r4Q0tfH1yD1YYSUBBzjBcDOkCRwA8QRG9yTEeCH5D2rrRaE1ZBy/jyZNmKbaQJEzx3x/rjYq0XxVApaQ8oANmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789403678; c=relaxed/simple; bh=wsPjLf4erG75POPC5Tzih1/0LmpF5rAW/u7DH/I6EuU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i6ORP/aGeSDoL+R8wiVt7eLO/roKfg4cUMNuX3FtftGLQyvA9w0xyL3D1Zca9exkdnnwLdjI8piHOBqC37QJ5IDQuibU6uN4XB515DvpObpe28FzNBSsWfdhZCEr/2Rq2+B3j1vOT1JP9R9IgdEwLvkHpAheYQtIXABE60vbX2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O1S9GLB+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UtS+eF6u; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O1S9GLB+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UtS+eF6u" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68ED0WDq4157615 for ; Mon, 14 Sep 2026 16:34:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5pxU/5l6A0Bab/y/7YnNiJxy/wwtfvfJ4udS7mKNrII=; b=O1S9GLB+CK2iB+LS oEhJhYnIYA+ckNkuAhPNpcfozZQqPtegK/yV2/C7IMdTB0ZxzolCmXIoBZbaYUyg +23qZLRnHLFOpRxh93kF0BHG0cH3qkpUIKbe50wFZaTuOBIRKfGhBCTB/XZAH9MP 1Zk7uDZl7bnX7By331mi3d8Lwm2RJj+MN+CW3IeEZ23vkHUcPUnG1nXtasPjWdtj LjuKu7WrmHVQDNO+dyrAVVIU54mSH5qSgkGW2Msv9+Vz9zovrWavP/EWjphiY4tI kVWiU7Q8FLyp3u1LLkQbNoWvMsIotBpNouni/3Oqh1BzVsquegPbJjrbkNE8TrCU M7WG9g== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gpd1f20ts-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 16:34:36 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3989c51d5daso988172a91.2 for ; Mon, 14 Sep 2026 09:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789403675; x=1790008475; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5pxU/5l6A0Bab/y/7YnNiJxy/wwtfvfJ4udS7mKNrII=; b=UtS+eF6uHQN/gSR2Z1jhbv62zXK4OWmhFhlqp3Lr/0nOSPYRXC8e39ShFXTUqFG2os jxyHcPf16E2uyUmJRKQ8ZJWKCx5PNHzGAh+CH6J2R/Sd6Pf7LEdihixGIHCXMopnOVJs u+bsSOXnJYWWswJeofE54C8+RHBQVaFzJQVXzbkA96jB9gruwW5AP31HjMUh8iLsm+cB 6HrGQkNTIz82fJfscaZQLrj5w6hb7DybJPtGP9IoxzZWPVN1d5kklog9ZTgCT4IMIcF8 HUiN6OxJ6PvIUQyDWYemSrHaFqpHq1OumO5xC+B7WgF5Jskog+6Q6Ei8UqCSxIKYZLjg X/Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789403675; x=1790008475; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5pxU/5l6A0Bab/y/7YnNiJxy/wwtfvfJ4udS7mKNrII=; b=WHwp9DKOZGqn9zsqMpTcgnjJxN8kht4aYPYTxkydd85pFVHPpu7mCEz2eo4ebfjjg6 zK9/mvlXtL7T02MU+uRD9MwnQEfxh1n20sHB3KnDcWloeFDL/20Um3H/H89qJTWJzRAA DuNLizSbWEmU2kILq93WK8ghSxC4pyRf2w5KAbETbhmSjY1HLu1foTVas2ijgSVewcP4 nPmYjIVg+fMVLfoFx/bzJDB99e7FLv6LwdQD8ZKDdC8XinHOIafo9A8LlY8njyHud/Tw jaUHxUNmW4pRvG4/gMEmlfAvWdE91gJZ65klLJ7r/UWzm7lBFFCcJfUmMC2BgRaOwanj RZ1A== X-Forwarded-Encrypted: i=1; AKwUvByZnqNrfiBMj8YGkDwkoAvOnunVSZB9kjvd95CNe2xk/oEXLrgmmo+U7QcEZj7XwK4QN2jfeo7w7c4wWAw=@vger.kernel.org X-Gm-Message-State: AFuF++lX/oqgr57mDE7U9EW2Pz9UpprifVHMUAGdvXExDyRkiN8KXIXZ fdktCQ9kal6Kh+IL2iXeVfN99a2Ltm0dsx0JvldsnjLyHhka07u4lW6blLD5PBuLft184/ASx2y JpWwmSLaUHX3dIH8syakx/9ghSuvlH3+jHnnjf5GCD6h8uHkMya51me1IzoaE0W6+qFI= X-Gm-Gg: AYBFou3Qt+MFbwRuvKMyngfZ4D0N7H2FO+zz3agylNnTd45FrrENiMeMxFpGWaZGUuZ szXJDsSv7xxYkipuF6oOa7xvFbqalbfzqx6dRIccekFfqryVMG81RQnGeLEiVSG7etliexVCtmk y6FJRbLqDdk3M51QCIiawFk9Y+EwYSPwdmXX4L54acOHsan0U1pFAD1/vhjbpmDg0sclN8rJaK6 VzUTfJI9CO4QGKFFVp4a2ktc9YFH9e6tRO/jr66vlFymJKZ+1+f4HsqvM3y+ZrkgLqOw/t0nGWL 1IU6FXUbPiAhHhgeTMrKQQU7uePpHSLkbsMrxXOUSgngEyZX/NIYiVa0nkMwZJKWgFW2zIPoLUI fAb0QW+SthFWsixMeLX0mbGgXhAOqXuwAOzRCnBMwjMzVGUdIpJ81v6g36LNWlgjSAA== X-Received: by 2002:a17:90b:390d:b0:396:d27b:86a4 with SMTP id 98e67ed59e1d1-39dec02ca06mr4689175a91.2.1789403675372; Mon, 14 Sep 2026 09:34:35 -0700 (PDT) X-Received: by 2002:a17:90b:390d:b0:396:d27b:86a4 with SMTP id 98e67ed59e1d1-39dec02ca06mr4689138a91.2.1789403674876; Mon, 14 Sep 2026 09:34:34 -0700 (PDT) Received: from [10.249.18.74] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39dfdd28acbsm240663a91.10.2026.09.14.09.34.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2026 09:34:34 -0700 (PDT) Message-ID: <8511d685-b0e8-424d-b189-da35d18d3d02@oss.qualcomm.com> Date: Tue, 15 Sep 2026 00:34:30 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] Bluetooth: coredump: Fix skb leak in hci_devcd_append() stub To: Luiz Augusto von Dentz Cc: Marcel Holtmann , Abhishek Pandit-Subedi , Manish Mandlik , Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> <20260913-misc_fix-v1-1-558c1e4028b9@oss.qualcomm.com> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: _ZmbGprAD8DZSeyUUv4PIel6NehvDeB4 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDIzNyBTYWx0ZWRfXzXXbB+t4OuU0 WumAAL3qpOnElWp6I8lwrhha06IAvqYQjMFi4LdzRSjnx9iPf2gDdYOdeFGMSqGcxQTbry4bJRf AQvDnOTPCk3c2zP2xKZe69fVC7Tm8K0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDIzNyBTYWx0ZWRfXyNmFmnY4sQIg H8IRLqhE2ZBajcWW0ZJ/bn2bCFKSB7OxlYxASbA6s0SvJtnRnKP/bDHJq/hxZp5ykGL02T5ZIX8 tM7lyxdvbkarsjl7F1Q7UGcdFCudvGD9kf2LG7J/A7KdBW0EGWjVto4JUVDJbaBV31S8bFlAOv8 gzg3DWANZHV/SDGQN6alIhQWnT208EkSfNheuRyIXuD3oF8ntZbLbfx9rFtCChZtvEkjsWRZ+os Bc1Tbgw9xg6cPVmw4mnr/HYoyH/WUIIopR/HwG7WYEnisIZ4MOWKrd+pcleJ0aBb6ToPoQTk/aU a/5RppQLUEuEk+ImGjr57urZOa1Jzptyby4QOaUQuHT893BM/lxUXw7TMjw3D3QAkZTyVtLu1wo sl7mUwj0F8o8QBayCqQFXSEY5jjzFrza6svqydLKsnfwqzq37doCJqx5sUgdB4WxvxMni+PkVV1 PNZPdoV1nXXL2rXSeUA== X-Authority-Analysis: v=2.4 cv=XKel2ghE c=1 sm=1 tr=0 ts=6aa8221c cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=ppDuoXucZiPIag5SSHgA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: _ZmbGprAD8DZSeyUUv4PIel6NehvDeB4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_03,2026-09-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140237 On 9/14/2026 9:57 PM, Luiz Augusto von Dentz wrote: >> static inline int hci_devcd_append(struct hci_dev *hdev, struct sk_buff *skb) >> { >> + kfree_skb(skb); > I don't think freeing it here is a good idea; in fact I think the bug Agree, but freeing it here is the simplest fix. > must be fixed in the caller so it properly frees all clones, etc, > actually it may need to check if hci_devcd_init fails and stops > cloning and calling hci_devcd_append as a result. It would require a persistent variable to track whether a devcoredump collection failure has ever occurred, for every devcoredump packet reported by the controller.