From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5B71E423EAB; Fri, 24 Jul 2026 10:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784889556; cv=none; b=mR7W4IXbRDZZ8HCbKa9JnLnwvdY7ivoKKZcpAa5tcLMPOdHh6Bt3ew6aa47sk2Ho+aJBPr/PeYtFxDxli8PHT79Njg09GrxOM3RiYYB/1DiF8LP4fn+mng+EuAtPk4KsriBo0j56HJzkeiR6CuNFjaszo6k8ThTHJfDX9lJ25Bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784889556; c=relaxed/simple; bh=8ucxzJzKRncGbmLH/iEQkI2exC3zh2zSlJ8zSRx26rg=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=n+lTg9bhKsnUMqIxKWSulmHpfvYbd5WtiYNP5oNDqvJGaXBC9rQmLNyfVPA0kwrSW6LaSv6CXDtlMXFH6Hc/KVuXjRwIG80ABl+2INXJIgGCmxo/vVclcxYJv7WmFCnG8SjY1t4YR0XXmAlJeQlNXZ3xTerT2vhsc0wl1Pbr4uI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=nPz4q9Un; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="nPz4q9Un" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7116A1595; Fri, 24 Jul 2026 03:39:06 -0700 (PDT) Received: from [10.2.198.93] (unknown [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EF243F66F; Fri, 24 Jul 2026 03:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784889550; bh=8ucxzJzKRncGbmLH/iEQkI2exC3zh2zSlJ8zSRx26rg=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=nPz4q9UnTmIpC3f1IrnhhOXc+A/Z2VLc2MvO7S07Y0dMBj6vYrB5Dye4ym8oVNhXD BOcxcXhOs2SceDUmzESNakuvRw/Lz60Kb4I5oFZwEpDHzbiEUv3iW7H4ZPf9e+CZSj HrNea7YK425Wt8aVXd2zUUsc5hB2FRPkxg9XWQf4= Message-ID: <85146377-9c7a-43d9-a5af-b976d25cb93f@arm.com> Date: Fri, 24 Jul 2026 11:38:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: usama.anjum@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-openrisc@vger.kernel.org Subject: Re: [PATCH RFC v2 08/20] mm: vmscan: remove stack copy address of pud pass in wallk_pud_range() To: Yeoreum Yun , Russell King , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Catalin Marinas , Will Deacon , Arnd Bergmann , Andrew Morton , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Johannes Weiner , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , Tianrui Zhao , Bibo Mao , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jonas Bonn , Stefan Kristiansson , Stafford Horne References: <20260722-dummy_ptxp3-v2-0-d9e4bad31e0a@arm.com> <20260722-dummy_ptxp3-v2-8-d9e4bad31e0a@arm.com> From: Usama Anjum Content-Language: en-US In-Reply-To: <20260722-dummy_ptxp3-v2-8-d9e4bad31e0a@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/07/2026 4:30 pm, Yeoreum Yun wrote: > The behaviour of pXdp_get() will change with generic compile-time folded > page tables. To prepare for that, replace passing the address of a stack > copy of a pXd to walk_pmd_range() with passing the pud pointer directly, > allowing folded entries to be ignored. > > There should be no functional change. > > Signed-off-by: Yeoreum Yun Probably my reviewed-by tag was lost in previous version. Posting here again: Reviewed-by: Muhammad Usama Anjum > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 06e103f9781e..0c9c4ac89e09 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3727,7 +3727,7 @@ static int walk_pud_range(p4d_t *p4d, unsigned long start, unsigned long end, > if (!pud_present(val) || WARN_ON_ONCE(pud_leaf(val))) > continue; > > - walk_pmd_range(&val, addr, next, args); > + walk_pmd_range(pud + i, addr, next, args); > > if (need_resched() || walk->batched >= MAX_LRU_BATCH) { > end = (addr | ~PUD_MASK) + 1; >