From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 161CC129A6B; Tue, 26 Mar 2024 18:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711477913; cv=none; b=QXUK0/d/rW2fov4COfLAoB5ilmjiY/o00faWPK2X2LdP/jqoh9I8jpyAyd13RV/zioBhDJUqcaVH82qU46n+x0q5ivz+jSwyuuB7A0G4huL0tExjBmhY0TZ5kfKEmTvUEnLazTFoez1SziXhWpa9xrS1WYTDrcyyxtbFK0CdiuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711477913; c=relaxed/simple; bh=VVjLnoHtX11k4peMT3Slbcl09nUBcsgl29+K07jw/UQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=m1e/Nay6EwzQewmKTQcKUmRwaqBoTLcpnx+uB73VZ33ljld9qxSTxnSM8+hwGMMJGK3TIlrD8qRKE5FtuIAJVXIcv9ic/lFc3M9ImS1PI4tCAm8152aSsV/tRK+SQPLI9COk/M+U+e6gvKIFWFCdprvRG1qMfhDlxNLt/L1gTQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=MaHdzFbT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="MaHdzFbT" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42QIOYRB029149; Tue, 26 Mar 2024 18:31:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=GiHiaL1bOe/EXbSYTdniLPpYaBRiQap8rwEvH/06QSs=; b=Ma HdzFbTlivB4jJEP8Yaxuhh63DFVObMMzYKWyOOUkUI6zyYt9U1TEnSnEaFNC6/K7 kroit2tPzZz5b6ZERQ4HiD+UZhw+3cfvSsqo7rLKfspAGt0E4LUDTucpziQMX+A8 FqfQzNNmohRLZW4zJ6sLnS4TgsXpVgeolNmSxRWhswUKVfnoL0o/CubiMUsuMWfS eE+w2swZRDxSvg8qrexnkrLONY0iJUKudknNSVkchXjJlI6kX9XhlzxG/5wg30gw de/wFB7rMDy8+H8/sPTAiEmQXFq16EPBwriWGTBlIrm5RUntPNZ+RKGkE+PAVrJS gE9wkpeDjzXP0JgxuLcQ== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3x41k68d5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 18:31:43 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42QIVgov023006 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 18:31:42 GMT Received: from [10.71.109.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 26 Mar 2024 11:31:40 -0700 Message-ID: <85204b78-7b24-61cd-4bae-3e7abc6e4fd3@quicinc.com> Date: Tue, 26 Mar 2024 11:31:38 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used Content-Language: en-US To: Dmitry Baryshkov , Miguel Ojeda CC: Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , , linux-kernel References: From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 8ye9dJjpHj1CMyW79gz2c4cjYopMDVqy X-Proofpoint-GUID: 8ye9dJjpHj1CMyW79gz2c4cjYopMDVqy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-26_08,2024-03-21_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=999 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2403260133 On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: > On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda > wrote: >> >> Hi, >> >> In today's next, I got: >> >> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable >> 'out' set but not used [-Werror,-Wunused-but-set-variable] >> >> `out` seems to be there since commit 64d6255650d4 ("drm/msm: More >> fully implement devcoredump for a7xx"). >> >> Untested diff below assuming `dumper->iova` is constant -- if you want >> a formal patch, please let me know. > > Please send a proper patch that we can pick up. > This should be fixed with https://patchwork.freedesktop.org/patch/581853/. We can pickup that one with a Fixes tag applied. >> >> Cheers, >> Miguel >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c >> b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c >> index 1f5245fc2cdc..a847a0f7a73c 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c >> @@ -852,7 +852,7 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu, >> (block->type << 8) | i); >> >> in += CRASHDUMP_READ(in, REG_A6XX_HLSQ_DBG_AHB_READ_APERTURE, >> - block->size, dumper->iova + A6XX_CD_DATA_OFFSET); >> + block->size, out); >> >> out += block->size * sizeof(u32); >> } > > >