From: Shrikanth Hegde <sshegde@linux.vnet.ibm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, peterz@infradead.org, dietmar.eggemann@arm.com,
linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com,
yu.c.chen@intel.com, tim.c.chen@linux.intel.com
Subject: Re: [PATCH] sched: move access of avg_rt and avg_dl into existing helper functions
Date: Wed, 20 Dec 2023 20:18:44 +0530 [thread overview]
Message-ID: <85230ed0-26a0-4f08-aab0-f0a6ce03abe8@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAKfTPtCRoLULQkRTZcJfXvSSqZYV2oRN0a3_AFiuqD7k0LtL-Q@mail.gmail.com>
On 12/20/23 7:29 PM, Vincent Guittot wrote:
Hi Vincent, thanks for taking a look.
> On Wed, 20 Dec 2023 at 07:55, Shrikanth Hegde
> <sshegde@linux.vnet.ibm.com> wrote:
>>
>> This is a minor code simplification. There are helper functions called
>> cpu_util_dl and cpu_util_rt which gives the average utilization of DL
>> and RT respectively. But there are few places in code where these
>> variables are used directly.
>>
>> Instead use the helper function so that code becomes simpler and easy to
>> maintain later on.
>>
>> Signed-off-by: Shrikanth Hegde <sshegde@linux.vnet.ibm.com>
>> ---
>> kernel/sched/fair.c | 12 +++++-------
>> 1 file changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index bcea3d55d95d..02631060ca7e 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -9212,19 +9212,17 @@ static inline bool cfs_rq_has_blocked(struct cfs_rq *cfs_rq)
>>
>> static inline bool others_have_blocked(struct rq *rq)
>> {
>> - if (READ_ONCE(rq->avg_rt.util_avg))
>> + if (cpu_util_rt(rq))
>> return true;
>>
>> - if (READ_ONCE(rq->avg_dl.util_avg))
>> + if (cpu_util_dl(rq))
>> return true;
>>
>> if (thermal_load_avg(rq))
>> return true;
>>
>> -#ifdef CONFIG_HAVE_SCHED_AVG_IRQ
>> - if (READ_ONCE(rq->avg_irq.util_avg))
>> + if (cpu_util_irq(rq))
>
> cpu_util_irq doesn't call READ_ONCE()
>
I see. Actually it would be right if cpu_util_irq does call READ_ONCE no?
Sorry i havent yet understood the memory barriers in details. Please correct me
if i am wrong here,
since ___update_load_avg(&rq->avg_irq, 1) does use WRITE_ONCE and reading out this
value using cpu_util_irq on a different CPU should use READ_ONCE no?
>
>> return true;
>> -#endif
>>
>> return false;
>> }
>> @@ -9481,8 +9479,8 @@ static unsigned long scale_rt_capacity(int cpu)
>> * avg_thermal.load_avg tracks thermal pressure and the weighted
>> * average uses the actual delta max capacity(load).
>> */
>> - used = READ_ONCE(rq->avg_rt.util_avg);
>> - used += READ_ONCE(rq->avg_dl.util_avg);
>> + used = cpu_util_rt(rq);
>> + used += cpu_util_dl(rq);
>> used += thermal_load_avg(rq);
>>
>> if (unlikely(used >= max))
>> --
>> 2.39.3
>>
next prev parent reply other threads:[~2023-12-20 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 6:55 Shrikanth Hegde
2023-12-20 10:11 ` [tip: sched/core] sched/fair: Use existing helper functions to access ->avg_rt and ->avg_dl tip-bot2 for Shrikanth Hegde
2023-12-20 13:59 ` [PATCH] sched: move access of avg_rt and avg_dl into existing helper functions Vincent Guittot
2023-12-20 14:48 ` Shrikanth Hegde [this message]
2023-12-21 16:16 ` Vincent Guittot
2023-12-22 8:02 ` Shrikanth Hegde
2023-12-20 19:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85230ed0-26a0-4f08-aab0-f0a6ce03abe8@linux.vnet.ibm.com \
--to=sshegde@linux.vnet.ibm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®