Re: [PATCH v1 0/4] MediaTek DRM - DSI driver cleanups

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 24/05/23 11:34, AngeloGioacchino Del Regno ha scritto:
> This series performs some cleanups for mtk_dsi, enhancing human
> readability, using kernel provided macros where possible and
> also reducing code size.
> 
> Tested on MT8173 and MT8192 Chromebooks (using a DSI<->DP bridge)
> and on MT6795 Sony Xperia M5 (DSI video mode panel).
> 
> Please note:
> This series depends and can be applied only on top of [1].
> 
> [1]: https://lore.kernel.org/lkml/20230523104234.7849-1-angelogioacchino.delregno@collabora.com/
> 
> AngeloGioacchino Del Regno (4):
>    drm/mediatek: dsi: Use GENMASK() for register mask definitions
>    drm/mediatek: dsi: Cleanup functions mtk_dsi_ps_control{_vact}()
>    drm/mediatek: dsi: Use bitfield macros where useful
>    drm/mediatek: dsi: Replace open-coded instance of HZ_PER_MHZ
> 
>   drivers/gpu/drm/mediatek/mtk_dsi.c | 198 +++++++++++++----------------
>   1 file changed, 88 insertions(+), 110 deletions(-)
> 

Hello CK,

this series still applies and it's a nice cleanup.

Is there anything wrong with this? Can you please check it out?

Thanks,
Angelo