From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 615E2406803 for ; Wed, 10 Jun 2026 13:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781097188; cv=none; b=H2hpJdb5UI7jWs/3mfupudkR+Za4NZxcfbS5am50luYSVWMraAOEMYdsHEm25TY4cBLCjZPTdppW0UlUD0CsqK/oxsTDyVoa6m42q1xf9HRlQf6uO/6CCv2YFwNZ84+tOVujVzkRGKB9qiEWXopXzfRIeHpf+N26AAoh76w60y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781097188; c=relaxed/simple; bh=bsr7pJ5YEZy946+9gdtl1hv8ZREddttX2UY5gd/ijJ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FxL7CBjvlFi9E+kq0m68d4j68BCd0PLim9OImucvTxLf0/7ubD0KpFiF3A0GCXsyYsmfq/K8pjQ40vNVe9nzd2rBFaJWFElhfEkQnypXnw5UwNkuzSpsEwnblBPS8tfrcVP+qOkQPe5/Afvp8rci/0x76MiQZTUGAzZ/h5d3E3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d/kx6CLg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z145d8NS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d/kx6CLg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z145d8NS" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65ACBism1138112 for ; Wed, 10 Jun 2026 13:13:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qaSgPTMhlo8CQK8cSLxNg0Oqjf6PBr9dF4U4OY2jF/U=; b=d/kx6CLgd6zQUrwP hhmIoyfQN/yAa2wZXHYVkz/3dhUpgTCsVM+nQKg1IPOs5JJJH8oTtfO7k5PnRorA 5yCO8l1VyXHXODD2wT/S+AwqJB/BT2lKltdKCr/wHTEZfvD1FQpmGRoIhXoRAiPy kHXlzJEUqdDpt12JphD5zOB6gleeQghxeC/XDQrKGMR8GrDDanDlC6650ZrKhkrd VTUg8HdWVQ1OqNWtHFAnc/eMOI+JnvtmpAi/mIw12441z6PrXOSpuetNP5nLcerX hcFniXgNBUzZXF2F3HfiWq1V6yk4T1H5ByQjyU/gdEVpdy8sMeKAKth6zloxMMZ/ tbC2Rg== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epwr2jj48-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 13:13:06 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-6c6d4a825d5so297365137.1 for ; Wed, 10 Jun 2026 06:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781097186; x=1781701986; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qaSgPTMhlo8CQK8cSLxNg0Oqjf6PBr9dF4U4OY2jF/U=; b=Z145d8NSdErqQr1e08mcoeJPFi1slbIDCLcxCwsSkw04GLrpe9NoAeiWtpb7wWs+uh 0J4sPBBKxExbkORkCnc6rvJ+usSGnMtHzJT512GdRuub8jyX+xQ+aWqsVcfPBYBYrj/u W8qMRI85rE41hI7dLuBH+3EBspbvfa3sIz4E5bz7G07soYZP5ff9/JPQ+RbV2FknncFV gE1Wp6cqkgbm29mMoA8LwF/V7RE/kVJSkh64u/g+/uTCSLZvrLN8QsotQ+saAHl8jcP8 TLYn4o88QEpJWz48GBi/Uokxc9sUnbo7+LfIzxoEQNh64BI5AGNZc6UgMnFmVg/j7iQG 9VUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781097186; x=1781701986; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qaSgPTMhlo8CQK8cSLxNg0Oqjf6PBr9dF4U4OY2jF/U=; b=D2WUA7j9jXvxqUQLduT/LCLUJbO7YErCfVl/POgEz+YkmcarxEf5f8MoZEeQ6tMU8j QI/98syDeS7v3dtb7uq43VDQ+EogrgaagQyoge+lLfDoSfQDGIvQorEn5hXqO1TaP76l rWeFwqHOOKa7qBuppGCZY14aPe6tYVR9GDuNUDEL24Lybr4b1s+rnsTZ5Dx14F2IkmWl PRh+Xe9dM35qlucfB6VopHodYspAMnoJU5VyAvoLZqUcAFwlRy3PGmswJ+0weWegXa6P 84KtGk31TIea/H7lbhECx3tN/Tj3G3WuhXt0r4glscSqIxxiktRHdnBkWwqtUzXmsqp9 /Dcw== X-Forwarded-Encrypted: i=1; AFNElJ+pn7YzWWnfwHAhgMZbnSk5PBe1IaOcrzyjBCM+iOktVmqklAs9QMrmbgTQ8+kpHm6rl4H+mHGbu+iiSZ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzh4f50mpKDauEs1B047T4QNcIGuScYPmskNoe6YFjMjqNNTyhi drgdEy7aze/3Xwy5GxG0bVD9yJ8ozynP3rrVIPTIb1J/hi+T+MSHeB9qyKxELWooY8C6esIoZHr ZYZNKwKfglrCbShhnKLvjPEqtL7qVGnhWIE5hWR2HGbLvc5DeMJMoYjKwGw8+FxrLVXs= X-Gm-Gg: Acq92OFBYFKRFa/7t7XSSWFeyxO+LTwn1WVkYMwoPzcPS0Qenk+l5/buMLQoeqHpd7g l3YODiUsw5FVIBE/QBvY/KxQPIgoi9jI2loFumB6Cb5lKvj3eOQTVl2wq6UHiLvraXQi20bnexU q3386Z2Vd6D9Ttl4im9bdejm+z+JKDV61CBKtPMNaJz6j1hxfbT5qktHV6ckhzU4Mid8knd0Ok6 h23mR21Z4nAF2pzumZYSvzLLWGBmdH4p5r2i8mHb630PKhHB0z+KQvYnDPvE6K+FZ4RTpRC74M9 k/xVqsh799057SlZfiQGGPyLeKh89UwfetlJdNSzvUXu0Q41I7xqucvMOBZsZeMDBQPVTtjEAfT J5qBggzFXcz7OCtStUl9lKliO/FcH4qTFB4bpHnbgeOIg/ptFBOqF3L0g X-Received: by 2002:a05:6102:f07:b0:632:8717:e553 with SMTP id ada2fe7eead31-6feff065149mr3913053137.7.1781097185735; Wed, 10 Jun 2026 06:13:05 -0700 (PDT) X-Received: by 2002:a05:6102:f07:b0:632:8717:e553 with SMTP id ada2fe7eead31-6feff065149mr3913032137.7.1781097185087; Wed, 10 Jun 2026 06:13:05 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf2f2da4447sm912289566b.10.2026.06.10.06.13.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 06:13:04 -0700 (PDT) Message-ID: <852caded-eacf-4ac1-8fe5-83dd9285ef11@oss.qualcomm.com> Date: Wed, 10 Jun 2026 15:13:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Fix up QUSB2 PHY description for MSM8996/SM61[12]5 To: Dmitry Baryshkov Cc: Konrad Dybcio , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Iskren Chernev , Greg Kroah-Hartman , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610-topic-8996_61x5_qusb2phy-v1-0-d7135980e78f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Gu1yPE1C c=1 sm=1 tr=0 ts=6a2962e2 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=nlUS1CZQJJjccDyTXbgA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDEyNiBTYWx0ZWRfX0empgoCiR1Ps YXvsUma0g5R1v3x63v+zlz2tJrhxyqukOR4cORBRZ9yO4ttfVCwh+j3WHbxx2oTFoxwgz+d8bh9 xLxIir9IEXiHdTI9zDnqBEW5j8+kRIaduupQOhoR45EmftApz3kK7LCtNfVktZeim306c4z9L+w yACXMhyQnC9h8a0pRdpkCn7FZU3H3W5RNx9ZPhhkEYMRoaBINFaKDaZst43EjRJ9MPtEHaT143R Ws0hjsJtg9YENbER3cvyL+tFTIO1GNE0/LzhcFTnypeewXK9ttdg2HRR0hWoZqQAEFcRkR07B/r 2qAEXcMDMQu3C5GUwupRBS06y7WpwNQaqGVDgejrX69eAgehmsn/rpVQK0/wgacIdsabsHppvNj zgkbeyO1T+TqbgOpmO8Z2sORMxc2ZckTemX81h46qtEghslVBBbkUpEppFNYBUeFMuhm4b56ntl tNX2Lh1/rW8XqsD8iQw== X-Proofpoint-ORIG-GUID: 8E95VE9DxJyza6dkhdEdipbH4kNTM1RD X-Proofpoint-GUID: 8E95VE9DxJyza6dkhdEdipbH4kNTM1RD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 adultscore=0 clxscore=1015 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100126 On 6/10/26 3:03 PM, Dmitry Baryshkov wrote: > On Wed, Jun 10, 2026 at 02:49:31PM +0200, Konrad Dybcio wrote: >> On 6/10/26 2:04 PM, Konrad Dybcio wrote: >>> The MSM8996 QUSB2PHY was not being guaranteed a power source. >>> The SM6125's QUSB2PHY was believed to be idential as the 96 one. It >>> wasn't. This series tackles that, freeing us of some dt checker >>> errors about vdd-supply not found on MSM8996 boards. >>> >>> Compile-tested only, but docs confirm my findings.. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>> Konrad Dybcio (4): >>> dt-bindings: phy: qcom,qusb2: Straighten out SM6125 and MSM8996 >>> phy: qcom-qusb2: Fix SM6115 init sequence >>> arm64: dts: qcom: msm8996: Add VDD_MX to QUSB2 PHYs >>> arm64: dts: qcom: sm6125: Fix QUSB2 compatible >>> >>> .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 31 ++++++++++++++++++++-- >>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 10 +++++++ >>> arch/arm64/boot/dts/qcom/sm6125.dtsi | 3 ++- >>> drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 +-- >>> 4 files changed, 43 insertions(+), 5 deletions(-) >>> --- >> >> Note that msm8996pro may need even more looking into, but that's a >> story for another day > > JFYI, MSM8996 Pro is being used in the DRM / Mesa CI. If there is an > important difference, it would be nice to get it sorted out too. reg 96 pro 0x80 0xF8 0xD0 [!] QUSB2PHY_PORT_TUNE1 0x84 0xB3 0xB3 0x88 0x83 0x83 0x8C 0xC0 0xC0 0x90 none 0x02 [!] QUSB2PHY_PORT_TUNE5 0x08 0x30 0x30 0x0C 0x79 0x79 0x10 0x21 0x21 0x9C 0x14 0x14 0x1C 0x9F 0x9F 0x18 0x00 0x00 apparently this is indeed SoC-specific (via docs) but also apparently may not be very important (although should be fixed regardless as some designs may rely on this) Konrad