From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE903112D3 for ; Fri, 12 Sep 2025 14:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757687118; cv=none; b=WD754F2hmiKhfJ3bPHlcp0aBB8cFgSLCfPsD95IIGNpjRlcppY8LXfefrLxW5CuXpJ0fdqlaN4PcgRcX3u8VNlwauzNITy9HeXHW/4+jhEm8tcTJq2P6x373VmvriTdNISCtuw58bdbYDljZmWILSUsZDizNGenVJNRS5g6y5bs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757687118; c=relaxed/simple; bh=QAMrmmDJgAIqODGOhUrefaqS6U2Scv2+ord9t+JpIhI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=urKiItut1qk4kVti+tZTatIYuim5a4eQsCDZWVT0R3grsI6dTkNjXw+FKBiKwTbB8vzk4FmY2JvBQFBaWYaRamLaeyiWFQe2bhinxkHd8Q3G8DoTM2bcJy2S6DE1yOZTi9u/u/lmhsvDWvoTXKvXgKHQESGkljG3HjBkQH3GS30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ITTGI8IE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ITTGI8IE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757687115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gn3WhgefbhqadhZ+e2VS3g6y1n7EinfOM5ykIxfpPls=; b=ITTGI8IEYS693XakVLg4WSSwvqZfefn4zoC6E5WjV3iT0cFkdZWBeSeclogqG4jEhly3kB pdC5wm3yG0MelWA1BRdbKZXpd/ncPvRNwykYF8uUlWAQy9fp7cMYMosnn7iMOTvgOODv7s h7dTnNYn4D7i8o7ceO1t/ILVDXBlozg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-g_PWHr4yMNqc6fcTFTux2A-1; Fri, 12 Sep 2025 10:25:14 -0400 X-MC-Unique: g_PWHr4yMNqc6fcTFTux2A-1 X-Mimecast-MFC-AGG-ID: g_PWHr4yMNqc6fcTFTux2A_1757687113 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3e3f8616125so1906383f8f.1 for ; Fri, 12 Sep 2025 07:25:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757687113; x=1758291913; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gn3WhgefbhqadhZ+e2VS3g6y1n7EinfOM5ykIxfpPls=; b=dNgtdcnnS781GHKrIdeibysWG88EcSKeASNqxlr39caYsRs5M0wJxZiDYPJY8DNcZB NFbecKZtO4fNzsACxPn1Wb5M2kO4iI1DkF/o9vJ8me8gfUOWKmiWy+vWQAQgf1cwXh8o jjX1dJb/tnQsJZYR0FV0iUObJ9M8WVWYUjHeQrZ8d5ImmYLX5Vc11hiqhnzRQWP54khw QHerpLxJv/C/9BF6VYbHhHhstlpkeDmVVZLlmd8AnUeqTVi+C+ySKw0Onopq+9VHqqCS BKAGKGXRXCNMKPtjf74k8qDv8cVEDMFkBhPWS85tl2TCg5cLtPZzyp601SwuYzN8G6m9 ueoQ== X-Forwarded-Encrypted: i=1; AJvYcCXhC040uXQcBXeYVHcgcM9e6EMz6AoH710VbrNxsU+VBsjKw7LSZT7c0gdZyUVnBi2Ai41PrHQnofZtNP8=@vger.kernel.org X-Gm-Message-State: AOJu0YwUaUlyY1EF84aCtwUt0xSuOh+4NXw+Ea7BMXDpBvYOMq6ky8cq VN7+djOtPTML7YglVDT8xl5K+6UjOTCAjLcBqkdQslMO+5q/c7VCfOgK6IwHK5sbjjYTXGSnHQn cKz4TigYXCGeGx2oQo5+XEUxHvOnXN3y9WJ2t+0KV/BY1TW6qn7ZXkWNaJ6Sgq9dEyg== X-Gm-Gg: ASbGnctVhwdhYr0pnOQ1FPafRgz+yPycBludY06c4Zn8mMYB+XtkEiVDaIuWBLazl/Y P1MC4kxFHuoeYOh8tH5fJkYjYtjA184HWf+zYbEqHgM2AgvxgnBedfsa9xo51aiwngywJc1mcZc DVTscbXNZGgXRrbK0FGaCzDF0o9MrhmuJFoxN3MhrMhfpLLax5bbf1Qhd9L2rpOpT7wJieJsu3R hfPcNrHS40JK4lmw/SrI//g+jJlSmi5lgi5ftijn1biuA2rRLbyRbhbletC5C29Ug8UMTQxrDA2 1pxDLLjXTVycxu3q9CfSVPn0B+4UrZ1VhUARI718AxRFappnsP91vQKB0hGg6/M06VmX2lErO5Q Ts342p/6j0GRjcKyFGI7YqlF+DXcrAyWv5PISoVsd3IjQNN4Fj1Eps5EeaimR1VT2jcA= X-Received: by 2002:a05:6000:186a:b0:3c6:c737:d39f with SMTP id ffacd0b85a97d-3e765792e71mr3311106f8f.3.1757687112568; Fri, 12 Sep 2025 07:25:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5Dw0WMhxC0tkHYzo2PeBegNsNsLTmAmmO9jpDPgYtz3v1hBhfjXrJHgGEloPWOm+UgdFZUw== X-Received: by 2002:a05:6000:186a:b0:3c6:c737:d39f with SMTP id ffacd0b85a97d-3e765792e71mr3311069f8f.3.1757687111967; Fri, 12 Sep 2025 07:25:11 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607e9e6asm6786163f8f.62.2025.09.12.07.25.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 07:25:11 -0700 (PDT) Message-ID: <852d6f8c-e167-4527-9dc9-98549124f6b1@redhat.com> Date: Fri, 12 Sep 2025 16:25:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] mm: introduce local state for lazy_mmu sections To: Alexander Gordeev Cc: Kevin Brodsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andreas Larsson , Andrew Morton , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "David S. Miller" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, Mark Rutland References: <4b4971fd-0445-4d86-8f3a-6ba3d68d15b7@arm.com> <4aa28016-5678-4c66-8104-8dcc3fa2f5ce@redhat.com> <15d01c8b-5475-442e-9df5-ca37b0d5dc04@arm.com> <7953a735-6129-4d22-be65-ce736630d539@redhat.com> <781a6450-1c0b-4603-91cf-49f16cd78c28@arm.com> <9ed5441f-cc03-472a-adc6-b9d3ad525664-agordeev@linux.ibm.com> <74d1f275-23c3-4fd8-b665-503c7fc87df0@redhat.com> <248b4623-8755-4323-8a44-be4af30e4856-agordeev@linux.ibm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12.09.25 16:05, Alexander Gordeev wrote: > On Fri, Sep 12, 2025 at 03:02:15PM +0200, David Hildenbrand wrote: >> How would that work with nesting? I feel like there is a fundamental problem >> with nesting with what you describe but I might be wrong. > > My picture is - flush on each lazy_mmu_disable(), pause on lazy_mmu_pause() > and honour only top-level arch_enter_lazy_mmu_mode_pte(mm, start, end, ptep) > context on all nested levels. > > In theory (and if I got it right, you leave the door open for this possibility) > every (mm, start, end, ptep) context could be stored for each nesting level > (as an opaque arch-specific data?). Yes, I explained that we could do that, for example, by returning a "struct arch_lazy_mmu_state" from enable() and feeding it into disable(). I would just wish that we could avoid that ... As an alternative, you could store it somewhere else as an array (percpu variable? task_struct) and support only a limited number of nesting levels. The current nesting level could always be retrieved from the task_struct, for example. Maybe s390x really wouldn't need support for more than one nesting level right now. > > But I do not really expect it ever, since arch_enter_lazy_mmu_mode_pte() > is only to be called in PTE walkers that never span more than one page > table and follow the pattern: Well, the cover letter here states: "Unfortunately, a corner case (DEBUG_PAGEALLOC) may still cause nesting to occur on arm64. Ryan proposed [2] to address that corner case at the generic level but this approach received pushback; [3] then attempted to solve the issue on arm64 only, but it was deemed too fragile." So I guess we should support nesting cleanly, at least on the core-mm side. I guess we could start with saying "well, s390x doesn't fully support nesting yet but doing so just requires changing the way we manage this per-nesting-level state internally". s390 is trying to do something different than the other archs here, so that naturally concerns me :) But if it's really just about forwarding that data and having s390 store it somewhere (task_struct, percpu variable, etc), fine with me. -- Cheers David / dhildenb