From: Michal Simek <monstr@monstr.eu>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] microblaze: Make virt_to_pfn() a static inline
Date: Wed, 23 Aug 2023 10:33:46 +0200 [thread overview]
Message-ID: <85367a42-0dd4-edba-db42-47475b158c8d@monstr.eu> (raw)
In-Reply-To: <CACRpkdYG1hhotoUj0o6+o=rFBfgrhKn9QjC2BywZdEmaoOwD-g@mail.gmail.com>
On 8/23/23 10:07, Linus Walleij wrote:
> On Tue, Aug 8, 2023 at 10:40 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> +static inline const void *pfn_to_virt(unsigned long pfn)
>
> I think maybe I should not have put const there. It means the
> pointer shouldn't be modified and I think there is code that
> does that, or cast to some other pointer which is not const:ed
> and then use things like ++ on the resulting type.
>
> If you run into compile warnings you can just delete the const,
> or I can send a follow-up patch.
Thanks for letting me knoe.
I compiled it by my default toolchain and didn't see any issue.
It should be tmr in linux-next and more bots will run over it.
But if you want to fix it please send the follow up patch on the top of this one
and I will take it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP/Versal ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal/Versal NET SoCs
TF-A maintainer - Xilinx ZynqMP/Versal/Versal NET SoCs
prev parent reply other threads:[~2023-08-23 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 8:40 Linus Walleij
2023-08-23 7:29 ` Michal Simek
2023-08-23 8:07 ` Linus Walleij
2023-08-23 8:33 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85367a42-0dd4-edba-db42-47475b158c8d@monstr.eu \
--to=monstr@monstr.eu \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®