From: Joe Perches <joe@perches.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Andy Whitcroft <apw@canonical.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] checkpatch: Add check item for RFC tags is outside the subject prefix
Date: Fri, 15 Oct 2021 09:50:58 -0700 [thread overview]
Message-ID: <8536d4a99103982688de6cdaeea51bc92a67af90.camel@perches.com> (raw)
In-Reply-To: <20211015075853.4038-1-caihuoqing@baidu.com>
On Fri, 2021-10-15 at 15:58 +0800, Cai Huoqing wrote:
> Some patches have been sent, the RFC tag of which is
> outside the subject prefix is incorrect. like this:
> "Subject: [PATCH v2] RFC:"
>
> Perfer "Subject: [RFC PATCH v2]" to "Subject: [PATCH v2] RFC:",
> so add check item for it.
typo of prefer but does this matter enough to make it a test?
Same typo in next patch.
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3121,6 +3121,12 @@ sub process {
> "A patch subject line should describe the change not the tool that found it\n" . $herecurr);
> }
>
> +# Check if RFC tags is outside the subject prefix
> + if ($in_header_lines && $line =~ /^Subject:.*patch\s*.*]\s*rfc:/i) {
> + WARN("RFC_TAG_PREFIX",
> + "RFC tag is outside subject prefix, try \"git format-patch --rfc\"\n" . $herecurr);
> + }
> +
> # Check for Gerrit Change-Ids not in any patch context
> if ($realfile eq '' && !$has_patch_separator && $line =~ /^\s*change-id:/i) {
> if (ERROR("GERRIT_CHANGE_ID",
prev parent reply other threads:[~2021-10-15 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 7:58 Cai Huoqing
2021-10-15 7:58 ` [PATCH 2/2] docs: checkpatch: Add the description for RFC_TAG_PREFIX waining messsage Cai Huoqing
2021-10-15 16:50 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8536d4a99103982688de6cdaeea51bc92a67af90.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=caihuoqing@baidu.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®