From: Jacek Kowalski <jacek@jacekk.info>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vlad URSU <vlad@ursu.me>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] e1000e: ignore factory-default checksum value on TGP platform
Date: Mon, 23 Jun 2025 18:18:10 +0200 [thread overview]
Message-ID: <8538df94-8ce3-422d-a360-dd917c7e153a@jacekk.info> (raw)
In-Reply-To: <b7856437-2c74-4e01-affa-3bbc57ce6c51@jacekk.info>
Vlad,
could you verify that the following patch works for you?
> diff --git a/drivers/net/ethernet/intel/e1000e/defines.h b/drivers/net/ethernet/intel/e1000e/defines.h
> index 8294a7c4f122..01696eb8dace 100644
> --- a/drivers/net/ethernet/intel/e1000e/defines.h
> +++ b/drivers/net/ethernet/intel/e1000e/defines.h
> @@ -637,6 +637,7 @@
>
> /* For checksumming, the sum of all words in the NVM should equal 0xBABA. */
> #define NVM_SUM 0xBABA
> +#define NVM_SUM_FACTORY_DEFAULT 0xFFFF
>
> /* PBA (printed board assembly) number words */
> #define NVM_PBA_OFFSET_0 8
> diff --git a/drivers/net/ethernet/intel/e1000e/nvm.c b/drivers/net/ethernet/intel/e1000e/nvm.c
> index e609f4df86f4..37cbf9236d84 100644
> --- a/drivers/net/ethernet/intel/e1000e/nvm.c
> +++ b/drivers/net/ethernet/intel/e1000e/nvm.c
> @@ -558,6 +558,11 @@ s32 e1000e_validate_nvm_checksum_generic(struct e1000_hw *hw)
> checksum += nvm_data;
> }
>
> + if (hw->mac.type == e1000_pch_tgp && checksum == (u16)NVM_SUM_FACTORY_DEFAULT) {
> + e_dbg("Factory-default NVM Checksum on TGP platform - ignoring\n");
> + return 0;
> + }
> +
> if (checksum != (u16)NVM_SUM) {
> e_dbg("NVM Checksum Invalid\n");
> return -E1000_ERR_NVM;
--
Best regards,
Jacek Kowalski
next prev parent reply other threads:[~2025-06-23 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 15:58 [PATCH v2 1/2] e1000e: disregard NVM checksum on tgp when valid checksum mask is not set Jacek Kowalski
2025-06-23 16:01 ` [PATCH v2 2/2] e1000e: ignore factory-default checksum value on TGP platform Jacek Kowalski
2025-06-23 16:18 ` Jacek Kowalski [this message]
2025-06-24 18:17 ` Vlad URSU
2025-06-24 18:34 ` Jacek Kowalski
2025-06-24 18:54 ` Vlad URSU
2025-06-24 9:53 ` Simon Horman
2025-06-24 12:51 ` Jacek Kowalski
2025-06-24 16:03 ` Simon Horman
2025-06-24 16:08 ` Jacek Kowalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8538df94-8ce3-422d-a360-dd917c7e153a@jacekk.info \
--to=jacek@jacekk.info \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vlad@ursu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®